From patchwork Sun Aug 27 02:22:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 806198 X-Patchwork-Delegate: bmeng.cn@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="u847KTom"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3xfz9Y1jqhz9sRm for ; Sun, 27 Aug 2017 12:19:13 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id C3E18C221F0; Sun, 27 Aug 2017 02:18:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 8A28AC2223C; Sun, 27 Aug 2017 02:18:40 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 40E63C221AB; Sun, 27 Aug 2017 02:18:38 +0000 (UTC) Received: from mail-io0-f193.google.com (mail-io0-f193.google.com [209.85.223.193]) by lists.denx.de (Postfix) with ESMTPS id B2000C22194 for ; Sun, 27 Aug 2017 02:18:37 +0000 (UTC) Received: by mail-io0-f193.google.com with SMTP id m40so1547860ioi.5 for ; Sat, 26 Aug 2017 19:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=aT790oOA46UoW1YSTKpUnT4o9QMLf9WSO9THgIPTKFc=; b=u847KTomLC72bAkoPrwcRePp9GNzo80vOu/NWoIXqsL5wrKuCzccXPc93BPvRL139z ESXdcoqqr5UX8sN+nATTNLNGd/hvhEg+NfXUtDfAgZHvRlmeYKdiYWUqVdfRJCrqhXSn r63WmmeF8Wu+bHHshVDHnZURHQso/fmJ9BctfMI9Hs3DNSceRuTfZWoB3UfhtBGRdcik vV8/I8ingolanjDCgCCHfqBCTd5dFJXc4L26Wvpy/lFdxv1FnR+MYrOqfaYcUwUbjc2B hSFbW2Msp9oK8+oos10SET9nPASWguHFI+fXLtG8Vk6vLog32RGq3zKlusfsukNq4vPW h+Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=aT790oOA46UoW1YSTKpUnT4o9QMLf9WSO9THgIPTKFc=; b=uVrFEsP633PfxdG8XiUUjutWK/22PbqHcYUAZzzmYGutYPkj5Zl40Vm62g8emIMFSn 1FuDgnJ8xAO9DuH8ZdLTe+AoQ/JqwSBUV/Lk48xbuGPzd5cij9mZxy/50w9z+DjH6ug4 zHkPjk0avlYOkBCh70nWWWBSUnrUfLftqleq1B04yUp3sjw0spELKE++Rbc9oFLqtQLV 9gbFjpCl6Z9PmImRboOxzvLKwmsNCxwh1PdcWL86nT/zj0nJPfnHlYwdlmFVvXtNRivW 2cn0zB8i0/wbr+X02RukEUruTf/USkot+ijbbJ/wMaHpdRUaUgBI/e2pVR34Wts7nERZ aP6g== X-Gm-Message-State: AHYfb5iSWsnQUPRbRNbYlfpbtafl5dM66zVq02lE6oYIJGxfWWR8vMcf tVyg4/U7HUe+RA== X-Received: by 10.107.15.135 with SMTP id 7mr2563933iop.57.1503800316705; Sat, 26 Aug 2017 19:18:36 -0700 (PDT) Received: from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com. [147.11.156.139]) by smtp.gmail.com with ESMTPSA id w135sm2385424itc.42.2017.08.26.19.18.35 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 26 Aug 2017 19:18:35 -0700 (PDT) From: Bin Meng To: Simon Glass , Stefan Roese , U-Boot Mailing List Date: Sat, 26 Aug 2017 19:22:59 -0700 Message-Id: <1503800579-19321-2-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1503800579-19321-1-git-send-email-bmeng.cn@gmail.com> References: <1503800579-19321-1-git-send-email-bmeng.cn@gmail.com> Subject: [U-Boot] [PATCH 2/2] x86: ich-spi: Clear atomic preop only when SPI settings are not locked X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The atomic preop register can only be written when SPI settings are not locked, otherwise it's read-only. Signed-off-by: Bin Meng Reviewed-by: Stefan Roese --- drivers/spi/ich.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/ich.c b/drivers/spi/ich.c index 5a3d690..22fc83d 100644 --- a/drivers/spi/ich.c +++ b/drivers/spi/ich.c @@ -563,7 +563,8 @@ static int ich_spi_xfer(struct udevice *dev, unsigned int bitlen, } /* Clear atomic preop now that xfer is done */ - ich_writew(ctlr, 0, ctlr->preop); + if (!lock) + ich_writew(ctlr, 0, ctlr->preop); return 0; }