| Message ID | 1500889921-26802-1-git-send-email-andy.yan@rock-chips.com |
|---|---|
| State | Accepted |
| Commit | 77c17f43543735a6b8e74e49793320ae82b25d6d |
| Delegated to: | Philipp Tomsich |
| Headers | show |
> printf will increase the code size more than 1kb, but platform > like rk3036 has no enough space for it. > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > --- > > Changes in v3: > - use puts instead of printf, which suggested by Simon > > Changes in v2: None > > arch/arm/mach-rockchip/bootrom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> printf will increase the code size more than 1kb, but platform > like rk3036 has no enough space for it. > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > > Changes in v3: > - use puts instead of printf, which suggested by Simon > > Changes in v2: None > > arch/arm/mach-rockchip/bootrom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> printf will increase the code size more than 1kb, but platform > like rk3036 has no enough space for it. > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > > Changes in v3: > - use puts instead of printf, which suggested by Simon > > Changes in v2: None > > arch/arm/mach-rockchip/bootrom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied to u-boot-rockchip, thanks!
diff --git a/arch/arm/mach-rockchip/bootrom.c b/arch/arm/mach-rockchip/bootrom.c index da36f92..4ca9962 100644 --- a/arch/arm/mach-rockchip/bootrom.c +++ b/arch/arm/mach-rockchip/bootrom.c @@ -9,8 +9,8 @@ void back_to_bootrom(void) { -#if defined(CONFIG_SPL_LIBGENERIC_SUPPORT) && !defined(CONFIG_TPL_BUILD) - printf("Returning to boot ROM..."); +#if defined(CONFIG_SPL_LIBCOMMON_SUPPORT) && !defined(CONFIG_TPL_BUILD) + puts("Returning to boot ROM..."); #endif _back_to_bootrom_s(); }
printf will increase the code size more than 1kb, but platform like rk3036 has no enough space for it. Signed-off-by: Andy Yan <andy.yan@rock-chips.com> --- Changes in v3: - use puts instead of printf, which suggested by Simon Changes in v2: None arch/arm/mach-rockchip/bootrom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)