diff mbox

[U-Boot,1/2] sandbox: remove os_putc() and os_puts()

Message ID 1500264512-30507-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit 47b98ad0f6779485d0f0c14f337c3eece273eb54
Delegated to: Simon Glass
Headers show

Commit Message

Masahiro Yamada July 17, 2017, 4:08 a.m. UTC
They are unused since commit d8c6fb8cedbc ("sandbox: Drop special
case console code for sandbox").

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/sandbox/cpu/os.c | 11 -----------
 include/os.h          | 20 --------------------
 2 files changed, 31 deletions(-)

Comments

Simon Glass July 28, 2017, 4:19 a.m. UTC | #1
On 16 July 2017 at 22:08, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> They are unused since commit d8c6fb8cedbc ("sandbox: Drop special
> case console code for sandbox").
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  arch/sandbox/cpu/os.c | 11 -----------
>  include/os.h          | 20 --------------------
>  2 files changed, 31 deletions(-)
>

I hope it was OK to remove those :-)

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass July 28, 2017, 6:44 p.m. UTC | #2
On 16 July 2017 at 22:08, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> They are unused since commit d8c6fb8cedbc ("sandbox: Drop special
> case console code for sandbox").
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  arch/sandbox/cpu/os.c | 11 -----------
>  include/os.h          | 20 --------------------
>  2 files changed, 31 deletions(-)
>

I hope it was OK to remove those :-)

Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!
diff mbox

Patch

diff --git a/arch/sandbox/cpu/os.c b/arch/sandbox/cpu/os.c
index 7243bfc1b1fd..22d6aab53481 100644
--- a/arch/sandbox/cpu/os.c
+++ b/arch/sandbox/cpu/os.c
@@ -413,17 +413,6 @@  int os_get_filesize(const char *fname, loff_t *size)
 	return 0;
 }
 
-void os_putc(int ch)
-{
-	putchar(ch);
-}
-
-void os_puts(const char *str)
-{
-	while (*str)
-		os_putc(*str++);
-}
-
 int os_write_ram_buf(const char *fname)
 {
 	struct sandbox_state *state = state_get_current();
diff --git a/include/os.h b/include/os.h
index 049b248c5b01..2bf4bdb1b836 100644
--- a/include/os.h
+++ b/include/os.h
@@ -241,26 +241,6 @@  const char *os_dirent_get_typename(enum os_dirent_t type);
 int os_get_filesize(const char *fname, loff_t *size);
 
 /**
- * Write a character to the controlling OS terminal
- *
- * This bypasses the U-Boot console support and writes directly to the OS
- * stdout file descriptor.
- *
- * @param ch	Character to write
- */
-void os_putc(int ch);
-
-/**
- * Write a string to the controlling OS terminal
- *
- * This bypasses the U-Boot console support and writes directly to the OS
- * stdout file descriptor.
- *
- * @param str	String to write (note that \n is not appended)
- */
-void os_puts(const char *str);
-
-/**
  * Write the sandbox RAM buffer to a existing file
  *
  * @param fname		Filename to write memory to (simple binary format)