| Message ID | 1496733316-9788-2-git-send-email-philipp.tomsich@theobroma-systems.com |
|---|---|
| State | Accepted |
| Commit | 1208523935613a2574f52028ec0d0e2466dcd067 |
| Delegated to: | Simon Glass |
| Headers | show |
On 6 June 2017 at 01:15, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote: > When enabling CONFIG_DISPLAY_ROCKCHIP_HDMI, compile-time warning for > the following implicitly defined functions are raised due to a missing > include directive: > > drivers/video/rockchip/rk_hdmi.c: In function 'rk_hdmi_probe': > drivers/video/rockchip/rk_hdmi.c:150:2: warning: implicit declaration of function 'rk_setreg' [-Wimplicit-function-declaration] > rk_setreg(&priv->grf->soc_con6, 1 << 15); > ^~~~~~~~~ > drivers/video/rockchip/rk_hdmi.c:153:2: warning: implicit declaration of function 'rk_clrsetreg' [-Wimplicit-function-declaration] > rk_clrsetreg(&priv->grf->soc_con6, 1 << 4, > ^~~~~~~~~~~~ > > This change fixes this by including <asm/hardware.h> in rk_hdmi.c. > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > > --- > > Changes in v3: > - adds an include-directive to the (pre-RK3399 enabled) rk_hdmi to > fix implicit definition warnings > > Changes in v2: None > > drivers/video/rockchip/rk_hdmi.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: Simon Glass <sjg@chromium.org>
On 6 June 2017 at 01:15, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote: > When enabling CONFIG_DISPLAY_ROCKCHIP_HDMI, compile-time warning for > the following implicitly defined functions are raised due to a missing > include directive: > > drivers/video/rockchip/rk_hdmi.c: In function 'rk_hdmi_probe': > drivers/video/rockchip/rk_hdmi.c:150:2: warning: implicit declaration of function 'rk_setreg' [-Wimplicit-function-declaration] > rk_setreg(&priv->grf->soc_con6, 1 << 15); > ^~~~~~~~~ > drivers/video/rockchip/rk_hdmi.c:153:2: warning: implicit declaration of function 'rk_clrsetreg' [-Wimplicit-function-declaration] > rk_clrsetreg(&priv->grf->soc_con6, 1 << 4, > ^~~~~~~~~~~~ > > This change fixes this by including <asm/hardware.h> in rk_hdmi.c. > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > > --- > > Changes in v3: > - adds an include-directive to the (pre-RK3399 enabled) rk_hdmi to > fix implicit definition warnings > > Changes in v2: None > > drivers/video/rockchip/rk_hdmi.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: Simon Glass <sjg@chromium.org> Applied to u-boot-rockchip, thanks!
diff --git a/drivers/video/rockchip/rk_hdmi.c b/drivers/video/rockchip/rk_hdmi.c index cd695ca..0479d6e 100644 --- a/drivers/video/rockchip/rk_hdmi.c +++ b/drivers/video/rockchip/rk_hdmi.c @@ -14,6 +14,7 @@ #include <regmap.h> #include <syscon.h> #include <asm/gpio.h> +#include <asm/hardware.h> #include <asm/io.h> #include <asm/arch/clock.h> #include <asm/arch/grf_rk3288.h>
When enabling CONFIG_DISPLAY_ROCKCHIP_HDMI, compile-time warning for the following implicitly defined functions are raised due to a missing include directive: drivers/video/rockchip/rk_hdmi.c: In function 'rk_hdmi_probe': drivers/video/rockchip/rk_hdmi.c:150:2: warning: implicit declaration of function 'rk_setreg' [-Wimplicit-function-declaration] rk_setreg(&priv->grf->soc_con6, 1 << 15); ^~~~~~~~~ drivers/video/rockchip/rk_hdmi.c:153:2: warning: implicit declaration of function 'rk_clrsetreg' [-Wimplicit-function-declaration] rk_clrsetreg(&priv->grf->soc_con6, 1 << 4, ^~~~~~~~~~~~ This change fixes this by including <asm/hardware.h> in rk_hdmi.c. Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> --- Changes in v3: - adds an include-directive to the (pre-RK3399 enabled) rk_hdmi to fix implicit definition warnings Changes in v2: None drivers/video/rockchip/rk_hdmi.c | 1 + 1 file changed, 1 insertion(+)