From patchwork Thu May 11 02:43:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 760919 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3wNcqs0NK8z9s7v for ; Thu, 11 May 2017 12:43:51 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="g30WfuT3"; dkim-atps=neutral Received: by lists.denx.de (Postfix, from userid 105) id ADB01C21CE0; Thu, 11 May 2017 02:43:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAD_ENC_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2704DC21CE0; Thu, 11 May 2017 02:43:41 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 5534BC21CE0; Thu, 11 May 2017 02:43:39 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0052.outbound.protection.outlook.com [104.47.0.52]) by lists.denx.de (Postfix) with ESMTPS id 9F005C21C3C for ; Thu, 11 May 2017 02:43:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GjEGduVTI/XsfVbz0H5SNbvIvIr3rsR7qQ7dkABIRsU=; b=g30WfuT3y81rvgjDllP8cTImdiIqvXxBKX09ySgpf5D1KmIR301hTEtHECDrh1Zfc9JcdyTLaNF66Wn3HHpFZ2HqSUhPM3CyQKE5alU1IB0gYPCRCShUzO/e9umFGZIDhpZF1qvyr29+984YkhibYWJvvd7sNTpRth3CK4CTYb8= Authentication-Results: chromium.org; dkim=none (message not signed) header.d=none; chromium.org; dmarc=none action=none header.from=nxp.com; Received: from linux-7smt.suse (192.158.241.86) by VI1PR04MB1167.eurprd04.prod.outlook.com (10.162.121.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1084.16; Thu, 11 May 2017 02:43:31 +0000 From: Peng Fan To: Date: Thu, 11 May 2017 10:43:02 +0800 Message-ID: <1494470582-23661-1-git-send-email-peng.fan@nxp.com> X-Mailer: git-send-email 2.6.2 MIME-Version: 1.0 X-Originating-IP: [192.158.241.86] X-ClientProxiedBy: HK2PR04CA0087.apcprd04.prod.outlook.com (10.170.154.159) To VI1PR04MB1167.eurprd04.prod.outlook.com (10.162.121.13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bec8579a-3a13-46be-2c55-08d498178585 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:VI1PR04MB1167; X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1167; 3:jtzew0T8vSR9Oajk0UJTYyxpQzw0FXL0hNLkaI6gG8Uyd3UOoVZ4jp7tLhuopoenSASFH5aJDjDiSKuMnjzOh0EU6HA7LN+0P2FcWLfzbB6iQ0DHE+7LPNMIIwZUfC9FqsNDK3th51TgB3VzQSsfagoqvw49cBqWJNkNFf0d76ofQ1yonGNjdpXYv4hG14IuvkSuTap6DGbrDuj8FV/ceRe/FnRpUuAIAil2shHczlWXjr2jnAE/ONRgpwFI2xmOT3ff+Ul/qBV50hRMr7IC2KDBtXnbV/wrg17mzjWMS6u1NCibq+QNwK5cxdCWJlA6Mewu1S2WCoMjlHkr4hKCUQKxGL3H8sJfbCBpCwuYndo=; 25:PUghPZM1b1w1puacOP4/wBwAvXDOK73Ufq1FO1AD8eVsOxukRVEi8wPVWb4l2SCWEQFBcrwJ0YP8zm6YrSlmYu/D8gikd1/i+2xZIru9rJfkeZeUrl1PQcIErmyyOZRR0Em0hoUN8idMQY5DzpLeU+o+MMD4ibmwqyRA1kfjzhDpV0qM6y+IRJ/AF71ppBMQTuZU9U5fcT7lTot/WiTx51ErgBq7wbcyR67Rq5wZAm5pqC813JGO8L9LmDJ+9VjnnUWstzhgMTOveLCf/1dr+VmtLk5Rq+vm3SMlZf9X5jXLo4zDpoxV0AwwOP/Y75xCi+STfs+HBh+sliuik8kYVf8rmK9sgFLw8fJlDPJ25ALIX5C6evwsHtKjUGK3Zk6ly/G0UOVz5uRvC7JE0dMsWEf2GCJp39l1oaG29MtT1+v/qZvtxDh73XsEfgrPct7QvsENNr7F/rBP6ZHeACsroRSAqY0XtkjQ3HvHN5VWpc8= X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1167; 31:nQagn3QazW3E2iZW5nYuOt9crFLBLHDfnpoAA7pm2ICBaey5D0VZeb6tpjLBINC9+sMr0Ujpq/d8jXKFNty5K/HVrTUmXDnyfYCy37Hiod2PvWFCeVmXU3pbQeve0e+ko7G7bepdtCtTM3dom6aHTQETH04hi1fxvnFqzvApG6nOc1MAiZps4lrCINuiMm+RS4Cepo55h9tfJ0c0lAvKBj8vvcTXdGEh/sFfTv00dV8=; 20:I7rNeBi4H78QWvRie9xfb/LGBs7fyxF6BHwwoz8t3zEn3NAyDYRZGXmTaBBInqVVEpJOxwDUtPixEQt9OxTcfSbX2AjXFtY6Q9vv8EEZd7HyEVwz/GG8EbtcWVw3zvfAjC/8MCD2+lYyzwKsko1tok38BBNMys82mvIyZR7C+ZjFJnpToTf9u60QfRwF5kcR6ovWnHyx0mMcN3tlmKtUsD1O3Qw6PFZN1f1N7i9IgVpQObA/fTORLOjilY1OsBB3igs5HgCNqJlIpTcMwQ+H5pCBJ4GE2IzSMWlU81CFmnCn5FuMQjxjXkgYmrwf2AwM5dprCEAnIzZIl9+KV9OdFo2IdE+ClS4CoM1KWFtnqzkB9S4o1rLq17z3cBkJqyL0vXK08gSUs15RO4+deAOpwWzLFXVK1Fn1weJg6wd2T3ZT2wBZ2jgIsJGLi4Y0kTvW/0y11oQatqrT9+VZUxtkQMh18qLbdSDQL++nXN0r9MXk8y5yPmpP40yBId+kRZ3J X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123564025)(20161123562025)(6072148); SRVR:VI1PR04MB1167; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB1167; X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1167; 4:LF3W8ib9nMK5T1KVe6JZUVmhHmfO6A6h+7Yfv2JOddxKPfg4nWv+3tgMFlK+JFcW0lzAZhORRSZepJaPDFt74EgwWTFY3R2XkYIn4yIAKV2QFwHBZ3FkDvRUOp35/GneWWt8xd8Pic58U7u3LPWaz5nhblG2VKl/35+V7bwYA8HlWq/vN2LMRCOsEFYgR79OlkHwvTpm4M97v+uKnfC+zPTPb/9yFyPgp/vEBMNI6+IsWbV5vU7l/0MYcTCr5Lv4p1xSERa84/76hqYvJwWfecHTMaH9AFDqk6PG2z+kvrwAG+HyQFSQEVvJXZtlyV0QVNXRTX4osu/PjG/YUvNItTuxheK4SOp5r9+cMm8RjILx1ju0y/zXWpCamHxABKjFt/gSCILDR/tO/N74bzPWfLDRDdJ+DaZN5vfCM9kUph2jhJ6NERms9mcMt30lU+U2uCD9BTnDsY1YxfQ8wL29K59LXxF4nRO37napcdHD9OCk0W5H99JpkOG/40f+6bgHv4TY8VPJEKw8i3aJ4RcUFb00iyYECaC5DVE9tvlULmuW7GPUr173OL1GJMqu+Pl0jQTst8Ts05Z/9OTTy/ICklETyZ6ytUt2mYLcsS7yBOmWXRScq9GU6+Ed8b7VDDzRMv2SL4ZDuUF+IPRRvO7ij5bVWMcJbCGc8XpqX2KD3FMQR3KKKyN/mAbiX1v5xN3WoYfpMC1mCnPvlYot37z3DKhLDGYip9v3hHUr5vKRaXF/pcFl5HdGCAkP/zSgSLMkDllQVuAHXvLoB84GzkGfJEVwHISJjqbjc1O3R4IjWRW0LUXf2FaaVuGLODTWRrwr4EGVe+jriFFIJWD9HzT/qY1fPTk19+PiifkwTCn0Y9w= X-Forefront-PRVS: 0304E36CA3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39450400003)(39850400002)(39840400002)(39410400002)(39860400002)(39400400002)(189998001)(53936002)(86362001)(110136004)(38730400002)(25786009)(54906002)(42186005)(6512007)(6506006)(6486002)(36756003)(5660300001)(47776003)(66066001)(4326008)(5003940100001)(305945005)(81166006)(2351001)(7736002)(8676002)(6666003)(6916009)(478600001)(50226002)(3846002)(50986999)(33646002)(48376002)(6116002)(50466002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1167; H:linux-7smt.suse; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR04MB1167; 23:Z7i4hSgaC76VRe+tegkQ4wKALU5we6vMQHR3YAKGC?= =?us-ascii?Q?4TlYTJBSS/okuWfqJNs2niqGbFIRZvfNwFg3hsg9B+A+8Ei6bhy5PBxqUCKK?= =?us-ascii?Q?TyAhl7S1fK0sST3H+O6123qkSml8cRUnSkRBYeQqc2U1YyyeMfbmLxZ51S8m?= =?us-ascii?Q?t3f4kahkvWShOiXFZIcveGkiZKSZ1ewiOAc6ErXDD2OrjprBjTNJ9+32Vsf5?= =?us-ascii?Q?8N/gmvRDyjOljvub3Nvs8TjPL5y4z92I6cwrR+pmnSO6BsJA6JmVB7HCmbkK?= =?us-ascii?Q?7Z4p0pd/89p61UQImqmeoepoi6KfNxnnXc8KY7avrzDF+528Vx0IUr/ZLQnP?= =?us-ascii?Q?BWApRg2gzBy/BKmEJ0Do0bVdmwlWef1gelhsvqovk00YXcGVNnccBHGoYxhK?= =?us-ascii?Q?kaI0ueN5d0A4buS/lDZ5xh5sPli70wCSNmvgwDBcNbiuUiHMXzCvjbOCdmhb?= =?us-ascii?Q?r+UJ+I8lND0cygDKKTrGJfpSOEFxsDDHR3CS6JStESw2S4JEzoWyrwb4NzDf?= =?us-ascii?Q?CeRJGk91QAJ97bVIiJYXmKlSQ9F1FqJzVeSJ+aPYu+J0PkevL9pMMn4ibjK2?= =?us-ascii?Q?KVNxk8PIhkRQfjlaHpSwSEkfsJj0SKaEnrePuGj7RcDYP/85Eg5Du+AH81UU?= =?us-ascii?Q?kuliKx2K/wHWIWy0DT7Ut3M61vAGJuy8yJ0sQTgB90zEA+MEt+uWbhLI94y3?= =?us-ascii?Q?ij4W/5KzyTcnQTlzOr/NUhkecpJl35KWWMVPlg24qVyXYxa0NDacWc/tpCbr?= =?us-ascii?Q?HIs9C/paiTs8d26Xa/uHdKpfkzKZio0b+aco5TOn6TLRI1vW86Brr2skdozM?= =?us-ascii?Q?hV3blQzTLpjUueqDiZeGmViEGAH9v3U7O/skoPTO+M716GbxvLRIo6//Gp9+?= =?us-ascii?Q?HWs4nhB8xi/uKrZBHM9xWRkM1oNW9Q1fEQ/J+TmBHpE8Q0gOI/s14xm3TZVP?= =?us-ascii?Q?A971uPCEZodJZN3yj3LzaNfvJuFJe74M04Fe+xLbxhkMjYxkIh7IHc068itC?= =?us-ascii?Q?+TatFX4ZVytcjNnGQGq6fwfGJMNOg83rORbxUi3Vf1hcJxCH8mPtFiSY8JpF?= =?us-ascii?Q?82M548=3D?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1167; 6:OA0Z6tWkbRoA2bIRdZPyFujOwtwe+tA1AEl0dRl6XBPuSWnkp4Mt++TM4piyuWNS2XvyaIarKnPi4iMsPyOA4VJdcqg0dMgHEXqtSS0BL2HLkXfPhJm/zu3GHa+k7bO1XyTWsjN0sVJ5Nsvc+KPz5C9ZB2yEy7Ob+gjsu4BmtXzw5OZYe9mleva5UCESxzgZs3kbLLUjCJ4pxRclR+74O+LXqxOpdvCZYGZwjU6cl5uwzoxdHIPPCYEnEacgWcM/0jl75KWjVnbT/tXC54N40K0o4L5mAgSmnlVhtpta9atW/vgzbUIc28nTISfh/pf/qRM+PnfIuqyMAxiLVJLs5MTPVuFp7cXJZsFqLU7mzrdKIfKSRzhZ3qY73e4YS7mWh9onkTlJv10E2/rO0GC3XXnM98euKNEg6v8igvTlgfCDsz+S4vvZRVaoFOeWNlhVKPXctbYC7uHY19nrUSx4eEhviRIJZI4fqoEgqydeIqh2qhtaGW6gYQ/z75f35DJQAwkERgS/gmpxxTwhSTwJd+GrSshj0ZglmdrLEEyThhg=; 5:suFeBhe+UexmyaarH4GNBlUUCkKRpKuLYynr+/qobRzjZ8TAlDJ1pziYjsaIZQ/M+uyOsNpTBGsrJsfIy9ip/kGCgFFlPPyBeqcq9NuKODRna+BU1fMFbCwrkmERjBGRQ4LA5zEnveHZ0ewOq+bGCg==; 24:PGpi8l8mSjklYwbmk8OKvctKfsem8Y2dyA5u1USa2No+gGkI7XHxgFPWzODEUbx73kF+OK8V0p90aYmq2glQUnpM7nTR4Zr8eSauVOAYJZI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1167; 7:CXzFiI7gyaIf5Lj10cJOW6X15x0pr3UccZtMhhcHtbTS7S6XlBacNFuZX+Hhx/AHW2sENcQGhzkBpLO/eRfjOLpTQsUzBMdyoHgjOoLTrlBB7pFPAh3mb0CJZ2e5X517S1sXvYXNzQ9L8TQ+oEZit19hmc67OByo9fW8xpAVprykuKSKpBWZrR/0xK2ciY4KzZ0TVGZxUOAOoF8CvCbA8jqDgF73xnQX4iIgAmLQOF+2HKE+UvOVqwGdZN9zSxehH+GfWSd9NG2AMDHg2YR45fGLC5ojxPgHYIMqX5vO7R9b3BhARPoM0+bsmRANHlsmLxfqn8vBpuoHHliUSqU++A== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2017 02:43:31.0816 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1167 Cc: u-boot@lists.denx.de, Stefan Agner Subject: [U-Boot] [PATCH] pinctrl: imx: fix memory leak X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Each time set_state is called, a new piece memory will be allocated for pin_data, but not freed, this will incur memory leak. When error, the devm API could not free memory automatically. So need call devm_kfree when error. Issue reported by Coverity Signed-off-by: Peng Fan Cc: Simon Glass Cc: Stefan Agner Cc: Stefano Babic --- drivers/pinctrl/nxp/pinctrl-imx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/nxp/pinctrl-imx.c b/drivers/pinctrl/nxp/pinctrl-imx.c index f0321c4..31a28e1 100644 --- a/drivers/pinctrl/nxp/pinctrl-imx.c +++ b/drivers/pinctrl/nxp/pinctrl-imx.c @@ -53,6 +53,7 @@ static int imx_pinctrl_set_state(struct udevice *dev, struct udevice *config) if (fdtdec_get_int_array(gd->fdt_blob, node, "fsl,pins", pin_data, size >> 2)) { dev_err(dev, "Error reading pin data.\n"); + devm_kfree(pin_data); return -EINVAL; } @@ -78,6 +79,7 @@ static int imx_pinctrl_set_state(struct udevice *dev, struct udevice *config) if ((mux_reg == -1) || (conf_reg == -1)) { dev_err(dev, "Error mux_reg or conf_reg\n"); + devm_kfree(pin_data); return -EINVAL; } @@ -166,6 +168,8 @@ static int imx_pinctrl_set_state(struct udevice *dev, struct udevice *config) } } + devm_kfree(pin_data); + return 0; }