diff mbox

[U-Boot,2/3] net: fec_mxc: avoid transfer dev_id -1 to get mac address from fuse

Message ID 1491824675-29627-2-git-send-email-peng.fan@nxp.com
State Accepted
Commit f01e4e1e148b11b4021e241e3940c664bcd79b71
Delegated to: Stefano Babic
Headers show

Commit Message

Peng Fan April 10, 2017, 11:44 a.m. UTC 
From: Andy Duan <fugang.duan@nxp.com>

Avoid transfer parameter dev_id value with "-1" to .fec_get_hwaddr(),
it should transfer fec->dev_id to get mac address from fuse.

Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
---
 drivers/net/fec_mxc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefano Babic April 12, 2017, 4:22 p.m. UTC | #1 
On 10/04/2017 13:44, Peng Fan wrote:
> From: Andy Duan <fugang.duan@nxp.com>
> 
> Avoid transfer parameter dev_id value with "-1" to .fec_get_hwaddr(),
> it should transfer fec->dev_id to get mac address from fuse.
> 
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> ---
>  drivers/net/fec_mxc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index ac7afb5..d67a69b 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -1086,8 +1086,8 @@ static int fec_probe(bd_t *bd, int dev_id, uint32_t base_addr,
>  #endif
>  	eth_register(edev);
>  
> -	if (fec_get_hwaddr(dev_id, ethaddr) == 0) {
> -		debug("got MAC%d address from fuse: %pM\n", dev_id, ethaddr);
> +	if (fec_get_hwaddr(fec->dev_id, ethaddr) == 0) {
> +		debug("got MAC%d address from fuse: %pM\n", fec->dev_id, ethaddr);
>  		memcpy(edev->enetaddr, ethaddr, 6);
>  		if (!getenv("ethaddr"))
>  			eth_setenv_enetaddr("ethaddr", ethaddr);
> 

Right !

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index ac7afb5..d67a69b 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -1086,8 +1086,8 @@  static int fec_probe(bd_t *bd, int dev_id, uint32_t base_addr,
 #endif
 	eth_register(edev);
 
-	if (fec_get_hwaddr(dev_id, ethaddr) == 0) {
-		debug("got MAC%d address from fuse: %pM\n", dev_id, ethaddr);
+	if (fec_get_hwaddr(fec->dev_id, ethaddr) == 0) {
+		debug("got MAC%d address from fuse: %pM\n", fec->dev_id, ethaddr);
 		memcpy(edev->enetaddr, ethaddr, 6);
 		if (!getenv("ethaddr"))
 			eth_setenv_enetaddr("ethaddr", ethaddr);