| Message ID | 1490107789-15797-1-git-send-email-tharvey@gateworks.com |
|---|---|
| State | Rejected |
| Headers | show |
On Tue, Mar 21, 2017 at 7:56 AM, Stefano Babic <sbabic@denx.de> wrote: > On 21/03/2017 15:49, Tim Harvey wrote: >> Signed-off-by: Tim Harvey <tharvey@gateworks.com> >> --- >> board/gateworks/gw_ventana/gw_ventana.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/board/gateworks/gw_ventana/gw_ventana.c b/board/gateworks/gw_ventana/gw_ventana.c >> index dc8cd88..7052663 100644 >> --- a/board/gateworks/gw_ventana/gw_ventana.c >> +++ b/board/gateworks/gw_ventana/gw_ventana.c >> @@ -132,9 +132,9 @@ static void setup_iomux_enet(int gpio) >> /* toggle PHY_RST# */ >> gpio_request(gpio, "phy_rst#"); >> gpio_direction_output(gpio, 0); >> - mdelay(10); >> + mdelay(2); >> gpio_set_value(gpio, 1); >> - mdelay(100); >> + mdelay(15); >> } > > Reviewed-by: Stefano Babic <sbabic@denx.de> > > Tim, I have seen some warnings by compiling your new boards. Reason is > that the new configs (emmc, nand) are missing from the MAINTAINERS file. > Can you send a patch to fix this ? You can see the warnings if you run > "buildman gw_ventana" - thanks ! > Will do - thanks for the heads-up! Please drop this patch... I'm still having reliability issues with the MV88E6176 phy reset. The datasheet doesn't give much details about the reset requirements so I'll leave them overly conservative. Thanks, Tim
diff --git a/board/gateworks/gw_ventana/gw_ventana.c b/board/gateworks/gw_ventana/gw_ventana.c index dc8cd88..7052663 100644 --- a/board/gateworks/gw_ventana/gw_ventana.c +++ b/board/gateworks/gw_ventana/gw_ventana.c @@ -132,9 +132,9 @@ static void setup_iomux_enet(int gpio) /* toggle PHY_RST# */ gpio_request(gpio, "phy_rst#"); gpio_direction_output(gpio, 0); - mdelay(10); + mdelay(2); gpio_set_value(gpio, 1); - mdelay(100); + mdelay(15); } #ifdef CONFIG_USB_EHCI_MX6
Signed-off-by: Tim Harvey <tharvey@gateworks.com> --- board/gateworks/gw_ventana/gw_ventana.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)