diff mbox

[U-Boot,1/4] config: rk3036: enable configs for USB HOST

Message ID 1478600022-18822-2-git-send-email-kever.yang@rock-chips.com
State Accepted
Commit 1e352124b94f977fb7bbb516ea09ef345a70ee09
Delegated to: Simon Glass
Headers show

Commit Message

Kever Yang Nov. 8, 2016, 10:13 a.m. UTC
rk3036 using dwc2 usb controller, need enable relate configs for it.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 configs/kylin-rk3036_defconfig  | 3 +++
 include/configs/rk3036_common.h | 7 +++++++
 2 files changed, 10 insertions(+)

Comments

Simon Glass Nov. 11, 2016, 4:16 p.m. UTC | #1
Hi Kever,

On 8 November 2016 at 03:13, Kever Yang <kever.yang@rock-chips.com> wrote:
> rk3036 using dwc2 usb controller, need enable relate configs for it.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
>  configs/kylin-rk3036_defconfig  | 3 +++
>  include/configs/rk3036_common.h | 7 +++++++
>  2 files changed, 10 insertions(+)

Acked-by: Simon Glass <sjg@chromium.org>

Are these added in the right order? Did you use 'make savedefconfig' afterwards?

>
> diff --git a/configs/kylin-rk3036_defconfig b/configs/kylin-rk3036_defconfig
> index 424cdab..5a8b85a 100644
> --- a/configs/kylin-rk3036_defconfig
> +++ b/configs/kylin-rk3036_defconfig
> @@ -36,3 +36,6 @@ CONFIG_RAM=y
>  CONFIG_SYSRESET=y
>  CONFIG_CMD_DHRYSTONE=y
>  CONFIG_ERRNO_STR=y
> +CONFIG_CMD_USB=y
> +CONFIG_USB=y
> +CONFIG_USB_STORAGE=y
> diff --git a/include/configs/rk3036_common.h b/include/configs/rk3036_common.h
> index 4eef3f8..92be29e 100644
> --- a/include/configs/rk3036_common.h
> +++ b/include/configs/rk3036_common.h
> @@ -79,6 +79,13 @@
>  #define CONFIG_G_DNL_VENDOR_NUM                0x2207
>  #define CONFIG_G_DNL_PRODUCT_NUM       0x310a
>
> +/* usb host */
> +#ifdef CONFIG_CMD_USB
> +#define CONFIG_USB_DWC2
> +#define CONFIG_USB_HOST_ETHER
> +#define CONFIG_USB_ETHER_SMSC95XX
> +#define CONFIG_USB_ETHER_ASIX
> +#endif
>  #define ENV_MEM_LAYOUT_SETTINGS \
>         "scriptaddr=0x60000000\0" \
>         "pxefile_addr_r=0x60100000\0" \
> --
> 1.9.1
>

Regards,
Simon
Simon Glass Nov. 25, 2016, 7:38 p.m. UTC | #2
On 11 November 2016 at 09:16, Simon Glass <sjg@chromium.org> wrote:
> Hi Kever,
>
> On 8 November 2016 at 03:13, Kever Yang <kever.yang@rock-chips.com> wrote:
>> rk3036 using dwc2 usb controller, need enable relate configs for it.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>>  configs/kylin-rk3036_defconfig  | 3 +++
>>  include/configs/rk3036_common.h | 7 +++++++
>>  2 files changed, 10 insertions(+)
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> Are these added in the right order? Did you use 'make savedefconfig' afterwards?

No response - please send a follow-up patch if needed.

Applied to u-boot-rockchip, thanks!
diff mbox

Patch

diff --git a/configs/kylin-rk3036_defconfig b/configs/kylin-rk3036_defconfig
index 424cdab..5a8b85a 100644
--- a/configs/kylin-rk3036_defconfig
+++ b/configs/kylin-rk3036_defconfig
@@ -36,3 +36,6 @@  CONFIG_RAM=y
 CONFIG_SYSRESET=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_CMD_USB=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
diff --git a/include/configs/rk3036_common.h b/include/configs/rk3036_common.h
index 4eef3f8..92be29e 100644
--- a/include/configs/rk3036_common.h
+++ b/include/configs/rk3036_common.h
@@ -79,6 +79,13 @@ 
 #define CONFIG_G_DNL_VENDOR_NUM		0x2207
 #define CONFIG_G_DNL_PRODUCT_NUM	0x310a
 
+/* usb host */
+#ifdef CONFIG_CMD_USB
+#define CONFIG_USB_DWC2
+#define CONFIG_USB_HOST_ETHER
+#define CONFIG_USB_ETHER_SMSC95XX
+#define CONFIG_USB_ETHER_ASIX
+#endif
 #define ENV_MEM_LAYOUT_SETTINGS \
 	"scriptaddr=0x60000000\0" \
 	"pxefile_addr_r=0x60100000\0" \