From patchwork Fri Oct 14 20:17:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: York Sun X-Patchwork-Id: 682437 X-Patchwork-Delegate: yorksun@freescale.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3swf7T1F1Jz9s9Y for ; Sat, 15 Oct 2016 07:18:45 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9D9BAA7544; Fri, 14 Oct 2016 22:18:41 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cI3dCqOgjmRp; Fri, 14 Oct 2016 22:18:41 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 3A2CFA7559; Fri, 14 Oct 2016 22:18:36 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9D7B74B9F9 for ; Fri, 14 Oct 2016 22:18:30 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2-MH3nIgdY4R for ; Fri, 14 Oct 2016 22:18:30 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0058.outbound.protection.outlook.com [104.47.36.58]) by theia.denx.de (Postfix) with ESMTPS id 043664B98A for ; Fri, 14 Oct 2016 22:18:26 +0200 (CEST) Received: from DM2PR03CA0038.namprd03.prod.outlook.com (10.141.96.37) by BL2PR03MB323.namprd03.prod.outlook.com (10.141.68.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.649.16; Fri, 14 Oct 2016 20:18:23 +0000 Received: from BN1BFFO11FD028.protection.gbl (2a01:111:f400:7c10::1:126) by DM2PR03CA0038.outlook.office365.com (2a01:111:e400:2428::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.16 via Frontend Transport; Fri, 14 Oct 2016 20:18:23 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nvidia.com; dkim=none (message not signed) header.d=none; nvidia.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD028.mail.protection.outlook.com (10.58.144.91) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.669.7 via Frontend Transport; Fri, 14 Oct 2016 20:18:22 +0000 Received: from oslab-l16.am.freescale.net ([10.213.174.90]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u9EKIJ1T011361; Fri, 14 Oct 2016 13:18:20 -0700 From: York Sun To: U-Boot Mailing List Date: Fri, 14 Oct 2016 13:17:56 -0700 Message-ID: <1476476277-10527-2-git-send-email-york.sun@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1476476277-10527-1-git-send-email-york.sun@nxp.com> References: <1476476277-10527-1-git-send-email-york.sun@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131209499034123437; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(104016004)(2950100002)(5003940100001)(586003)(5660300001)(68736007)(626004)(11100500001)(47776003)(76176999)(6916009)(7846002)(189998001)(48376002)(50466002)(85426001)(8936002)(6666003)(69596002)(77096005)(33646002)(86362001)(4326007)(50226002)(229853001)(92566002)(19580395003)(36756003)(87936001)(106466001)(81166006)(8676002)(19580405001)(8666005)(97736004)(110136003)(81156014)(356003)(105606002)(2906002)(305945005)(50986999)(7059030)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:BL2PR03MB323; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD028; 1:P2JjN6oPHKWq0FZu2+M3xemVoD62v+2NTG0F/m8mUhCGwQ2r1TyFfuy6Y2qeL4oQTH7NDD0ZubZtqZfADwUGA5lHoPFS82ga6BWj3QTD1nz6xdYygUvGdvZbID8roxSr8goFMZcLU8/9GG+W/ERwYU+69vkgpBV8cKrwGXb3Fb5vVX/jOkv5a2zBBym6MJen5e6gZb0xXwyt3YC6ky6SQro46K9urxrMTmaz3zut54js6dRZ3GAG+emxU/o5bUaxJkwGGUbKJiYYEr++Bef+uO499KBSjg1kp2YpO2tkXIV0CsMBWqaA3OZdT5pvhU7FqIAPVh8Eo3wydWVpTcUl1CiP3a2ExA4zDOyhy/e4aWPuMIYKWhLQWC58370fHf/mOV2vjyvwhW31FwDQZ5iZpDI1Ddyt+DSWmQIsJ94f/gzXPcyN/tGb+zOGtD/WwKadlTDUYIjXo3yU1RFu7cDeoRWfADqXuS83/QgCKzYmh9BZVdCGMl0hEdbCJS/dgPlWWpFOZrR0l35HYCdJEtBcCXITT/6th5kV+rTVWc5RwFHsWeDiTR6DUlgPFIyBgPN9/QnJdG5UhiS43UleXMxtoPEqtw6thSWUxCUrBTW8LfNokI7IRug8cCYcaqxwim+P MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: ef342c1b-1103-4bac-fcad-08d3f46f3f8c X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB323; 2:0jJnUDuHVYn/sdhyq9lm0eJ4Qah+y3tTj5Cb4DEifoZKXU2R1XcR94FXvUltXzt/kQooxp5DPV/V7WBBY6F85kqegUMCrSDWSmmKLnTRCAkoAY474dZuc2qnSlsJEwMfAodscML5tWQItfcz+DS5JJmwfPN7KJSo3hcB2htv57FK9+S4GaDv+92zk5I+CF59K4lv+vFvFXtPH9w/KBZfZQ==; 3:y0SK8uf2a5uqaNL6cPqdzx3iwADa5elstE1Oid0bLLjilgWL4ICFG6dZVJT+erjGxOMxL+4BEZbn3rPGNY0WcbNUBFE6Ni5nBZHX4iTGtadI0T8CIMXIMQOQAMToiH3sXAzw+q/mSKCmVa75hpBanWRgt9ANsHO0GkkudLDD4HKaY/24kyzZYdmHtkssuCwMfiWSGjOoDh7okAEUgd0318+wDCtllC7A1BHXKZamZzJcxauTGUHP4647mp5nYxeA X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB323; X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB323; 25:mhDd18q8lGV/Wc2cMOHDCwIB2E0Fz/AOKBG7KntsEZFJ6FbU9HmukoBgmj6CPBVE63KIwnglruzk2OhA/8gTrwzy2UTjm+VeeH9dt3Tp3PGmlg1lSbKVgWb/mHe6yvA7etS4EJ+19wMaoeFSSXycLIdX6ll1YCl1ZSC0WU0MnxWv2VhzHB0IlFNUvDLYLB1N7byfnLw2h6tJbfO4BN59yvz8TJ4rxDPDf18lE1JOrGzgOLYWaSkNGJxnxa65lNpPUzBBb5xxREoc22ySzLFvytGzwiYCEet9C9Hw5lDs4h5m0LG2yQN+0gSmwY3BUNxJpYdYitoKpsXLa/FLrgQDZ6Wg+K1BXCc50DYaNN0nUYD2uCfi9LA6NtnmCkkhiDQqb2rlsYLTCRvGnjzVN2bOQYgnIOC830C1PqJVlPiT2pWy58FSnnvEETpk54AzoiXsGxFOl/RlMKY/ChL61oM4wZAuIJawZNvXL//gVas7g2F3/xlykal9TeWZPjX/r4VTz6mONg8/Jr1SJLPiJAUZ1A/dNnKY/HaIeBjZJJ4CEyJmY4iyCmw9d7j2HqHvo2iA6QE2HUHUcSdVjtMZOzTCz1j2CgDjAtQ56i8nQOi7lFTuPV61FMiVi2tUpxnmTwW+sfVf1ofJVUwiJDyLCzg5CZU41gF59y6eK8p2FM1nn7g2LmGXWEJtVoCEJ/aeqSGMBW5+36ZtJdUN70yVbvNV5Q28R+2nuqx8SrjpyIMod6MbfcXZpWwPgt03Z0cbKjTu0ITUdNmJ+U16RX0UpoUHPA== X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB323; 31:1yAGzyPvObAM+Zs3vmKXTteMuQtLI9pqPaVln7JT+kswKpbsrk/ZKo5lJ8O4dtj46TX/4zdN7BY4ozeyojihIopLLMdmITNzhbVWV6bER/THYB6KffwFqQ6+reHLmOgc6KgqJhisaLTGgymVYwjPtuhj25EHtDDa0jKnn5rv1+UdrCwP2fd4qEbZEiNZaj0bE5JFQLqHUOXL68N5uDW1KAbK+UNKa4YhdT75L2HDnbwbDmI1nWHqxySdb26XHzdywW9DaLPUJveuq02mbETg+QvC5EDEzL8+3vzVG6X6PThUG3tu9GxMuraiA3cFA0yT; 4:tXo/UjoaL+zx05nDBPhuTyILlLQePqcamwooIwWa5RUDlSKEd+4i7CBtHxZSw6jmaGt7lgW2VYbXG4ibusG6bH/C2MdiAYdfgycTExuhDeDyiV/8r23iy8f4SBEcCcqKoH3Ih5AxuJUlT5i3DbMByX95/Gn912zjKCFeXOy3YJVR72azoA33Lat+yn4cZdkSjK5F8c4WAh+Khho4F3wdxkosyP+kGQeYS5HJUx6VH8weaJ+YshLaxGRg/WyqScueP442PcMqoI42IowLIhwU3oqDUMsL6fDkquysthjjY8pKuiegquw2hEa47stybjIQ6vVc5FDvRDWsvq69oC7Ep2M8q4+xiItPzqTaAzGRZgIu4M5Rd0QYhXyB43dzTVHVV2xcBNp/6hn9UXqTvv92ZEAqSiKfqbisLGAaqFNWrBmly2uIhlWwKrIwNsFUa/9J0Arf5XBWP+ANPXh0aZBrcfczlMYYZl6IjwWqFBknlteVIV6Rlxw4T6PdBJ/DFdPhyeXA8LOpzjEbQEr5q2/5cMXKEdYVqVF8fm4fcU0+MwvqhWSY9LXb++TYcbSCLEXJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13024025)(13015025)(13018025)(13023025)(8121501046)(13017025)(5005006)(10201501046)(3002001)(6055026); SRVR:BL2PR03MB323; BCL:0; PCL:0; RULEID:(400006); SRVR:BL2PR03MB323; X-Forefront-PRVS: 0095BCF226 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL2PR03MB323; 23:5KrZbKSRgyZlcqQa3M73D02xLHKG5aKtnu6kX8bICy?= =?us-ascii?Q?BRWZWHlc/Z4oLfMV8lRpk72LF1MGOIxNSxoYV3770B1KSEtssNmexqAXhZ7z?= =?us-ascii?Q?hRJsJ9/cxu2H9Y5l1AmZcSOdcXzmMl6smDxmpkIwlmiMWb3ogqlvVKD5X86o?= =?us-ascii?Q?Qt0aiSV0DL9J0BFxSTNMdp34aUloNZ40UyMn2DpZ9a5rcnf2R4upYRlupgsR?= =?us-ascii?Q?LkXKvIcKgd5IAaq0DhPVJltyYxq62KvBC6xqnpFmDYvP8rnkfdk/QuqEEOm6?= =?us-ascii?Q?DOgbsowO1MXE29ryWtIk0IjG0qLAhCKTBAD32Oz3kDN356PeLnaZ9J5fLYmP?= =?us-ascii?Q?/485zD+9xPeI9W1vcvE5buvGrmadFyFlsKeLFht7a7K8qzorV34kFMOAZ7wF?= =?us-ascii?Q?v5dE26qEnXo42eKGpBNcM1moxJaMBTKVlOPSxABp2WSm99jnEhj70nCcPrS8?= =?us-ascii?Q?VugnJjKRDVB2skNEch8o7fgSk5wc7IPyoj7Cee9WpCUDcFMhS7q4dGFybmbg?= =?us-ascii?Q?H2nyzgzEF9v1YKXl1vlZ8F7OHPuf2+CBr2Z3TY9xJxMuAZ9TUNKXn5X/okwS?= =?us-ascii?Q?9Usqmgm1amNmoGAnxtGefOQS0x3QmtDEDSGsYlQkGIhrcIUOupPqQXg7x7UE?= =?us-ascii?Q?i4qPlJJ/pRG5PqW0vFwEc5sDrWglOZbFSxM6T5KH0PF8u5bpapjeRaXsixEM?= =?us-ascii?Q?azbY25nXQVGZvbVXh4e/d/8byK7KTMDn46BpHJGgMWznlB3NPVKKdvLMnVD1?= =?us-ascii?Q?WfYbyhXoRgJ83xjg7UdJEfBWto3TRF0JyyoeelwWT7KCzDBi1H+ehnHb87/I?= =?us-ascii?Q?30OaYxdPIb6OVXjWbI2T8i0yBt4yyNaFVY+KGOKlmG1kh51rKtYQbu8uj0T/?= =?us-ascii?Q?JFt3J/BvsT1UHJq7mCGA3tts0xFfLxOgDq1uMiiLlIS17eZwgXz3CaV1ojGR?= =?us-ascii?Q?NvaVZVaItYaIjQ2eONxpzx2auHXdzT77UT7mUy6TP228nTppIwzS277/ecVm?= =?us-ascii?Q?83+xh3WSTvn+fUFbdu1toxiLcOg8Wb0fZYQa1+CJCVShP1z+lrKk62+9YiRP?= =?us-ascii?Q?M/+ZSfB4rcb69IGdyD146AAa/ie55LC8sBq4ESBLYllPCTw3//8EyQgkx7NU?= =?us-ascii?Q?NP78SoR+XM4uODloM90JTLfdpBb+PhJHLrgT1mt8qKmIqwiVjZLjgL3iGMkA?= =?us-ascii?Q?SGJExTCt/rqStWnd8ba/KJl0gdpU0riEpiiIJQuEGIEfYNTvnM9GOwdg=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB323; 6:5MtnpBINtNgpfbysFQ3RIClQ7c94Qo57SDKCCf7C2nrdAf0pjDeQWpT+pNnkj/ATRxqOO+gLf/YOKk3AXBHqgtoGAaMl6WVDJIl1ZHiXpoWlEO22PIf3nVAeJzjZPICqgOO5SW8wPYqy8VtEW3eqrL8MKvSst2QJJdbn5N1n1kjvfiKF8ttDwyj998kG1JeRsFvzRyzf/KFo6TDJEqyBxEDucqE8QzBgb/S2gGQSYo/SidFabL28KBLFAKGsv9PQpAStgFPBQyBSvClqOrpkia41lPVIErFzzwWLqfgH7q+baQjHhI7KagGNo/v0rYtv; 5:1gLTpXF+IcoilCAB0d4kuEFssxqdT+ySErMqeRVj1NZCulrmSmO7ivPaJpXMuhF4XmP7gk8pnvVniSyV8rBfcatiOszV6bxmkuL8403H1VWbDECZ1lN/Q+RmowhDedUdlSyun+Not4a/WZXcXTA/iSZlp4QGcyUX5lnlO1GjKzRMgaln3bufJbYfnEn/Nzit; 24:jVCvK8A+b+uVxk5b0DC/PXhchmHbXFK7nVPk5m+pPxDRcP2+zjWzbr31X6sdJ44fbWuJdiIdI+2HwnAT/goLQsiCJhEJeMDb5sw2j9MO6Fc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB323; 7:dNing8OQqkX7YOz2rCtLcI3+IQI+x9ZAxFT7B7cEOCJ16Ovz+vwtGeXPSmELaqJ5PT18rvhLQ6q6OXKstdvs4gdGjBNnPrig3AdaylW54zlQrbWRbQTMHXtXtAHzDi3O7KOrpUbd4Fovztuh7vsJmfBvAlNguzmV4Df1QPAJfwSBWiW5ABMe/3lwt3L99liZ25PVSnhcy/ZfBoRRWGvrloWnBSzZ5aH8376qVwRbgzQ7LtEN4HvMPh1RfuPsb53b7KKD9COAM6lu7G3e74xcsWYNXCm+SInvrYpygHpQY+mU1BAKeuxxtkbgXs0zjqrwwuagCy5fICOQLK7np1EJRYPNXYv/e2TP02dECVa8R14= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2016 20:18:22.4139 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB323 Cc: Albert Aribaud , David Feng , Stephen Warren , Thierry Reding Subject: [U-Boot] [Resend RFC PATCH 1/2] armv8: Fix dcache disable function X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Current code turns off d-cache first, then flush all levels of cache. This results data loss. As soon as d-cache is off, the dirty cache is discarded according to the test on LS2080A. This issue was not seen as long as external L3 cache was flushed to push the data to main memory. However, external L3 cache is not guaranteed to have the data. To fix this, flush the d-cache by way/set first to make sure cache is clean before turning it off. Signed-off-by: York Sun CC: David Feng Tested-by: Stephen Warren --- arch/arm/cpu/armv8/cache_v8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv8/cache_v8.c b/arch/arm/cpu/armv8/cache_v8.c index cd3f6c1..92d6277 100644 --- a/arch/arm/cpu/armv8/cache_v8.c +++ b/arch/arm/cpu/armv8/cache_v8.c @@ -478,9 +478,9 @@ void dcache_disable(void) if (!(sctlr & CR_C)) return; + flush_dcache_all(); set_sctlr(sctlr & ~(CR_C|CR_M)); - flush_dcache_all(); __asm_invalidate_tlb_all(); }