From patchwork Fri Oct 14 20:01:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: York Sun X-Patchwork-Id: 682435 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3swf6r3CzSz9s9N for ; Sat, 15 Oct 2016 07:18:12 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6E84B4B9AD; Fri, 14 Oct 2016 22:18:09 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id umN_9nRZjdQ8; Fri, 14 Oct 2016 22:18:09 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A97DE4B951; Fri, 14 Oct 2016 22:18:08 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id ECA314B951 for ; Fri, 14 Oct 2016 22:18:05 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id luTquuEhMVhO for ; Fri, 14 Oct 2016 22:18:05 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0066.outbound.protection.outlook.com [104.47.42.66]) by theia.denx.de (Postfix) with ESMTPS id 172634B811 for ; Fri, 14 Oct 2016 22:18:02 +0200 (CEST) Received: from CY1PR03CA0028.namprd03.prod.outlook.com (10.174.128.38) by BLUPR03MB1410.namprd03.prod.outlook.com (10.163.81.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Fri, 14 Oct 2016 20:01:46 +0000 Received: from BY2FFO11FD049.protection.gbl (2a01:111:f400:7c0c::192) by CY1PR03CA0028.outlook.office365.com (2603:10b6:600::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.16 via Frontend Transport; Fri, 14 Oct 2016 20:01:45 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD049.mail.protection.outlook.com (10.1.15.186) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.669.7 via Frontend Transport; Fri, 14 Oct 2016 20:01:45 +0000 Received: from oslab-l16.am.freescale.net ([10.213.174.90]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u9EK1gMm030542; Fri, 14 Oct 2016 13:01:44 -0700 From: York Sun To: U-Boot Mailing List Date: Fri, 14 Oct 2016 13:01:22 -0700 Message-ID: <1476475283-10111-2-git-send-email-york.sun@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1476475283-10111-1-git-send-email-york.sun@nxp.com> References: <1476475283-10111-1-git-send-email-york.sun@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131209489055837562; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(6666003)(6916009)(81156014)(36756003)(229853001)(86362001)(81166006)(11100500001)(586003)(105606002)(104016004)(50466002)(50986999)(106466001)(48376002)(76176999)(305945005)(97736004)(626004)(2906002)(47776003)(356003)(33646002)(8936002)(110136003)(4001430100002)(5660300001)(7846002)(68736007)(50226002)(4326007)(107886002)(69596002)(85426001)(77096005)(19580395003)(5003940100001)(87936001)(92566002)(8666005)(2950100002)(189998001)(8676002)(19580405001)(7059030)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR03MB1410; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD049; 1:QdYtAczmJIpvPhb4YTFem6CR4uQeMCWIAyg8W7VfCueecioXj+tELhexINkHRKdFJ2SjKHzhMUhKpx5iTjfe42dzgA+++xkw/I5TTv7ZQmSDPpO7MEku7pgaqcUSKzGpkdBYpk9PEQsMLCFxz0ZHHqogrFCqKgz6Sbhp72VU0db0gYtwTc1mZlchdeCP8/iysbeAgAjPXEOANJ8uL9Ti28BoSg2TRQn7DG7fxOGgeYrRrQykBMP8tBfW9x70eyty0CdRtfVgQHxODgkHsVt+o3R+WOOP3SFmJ23RLE4cTu6r+aNxD18k8yc/YE0agYEGvS1K9a/ryyG8NWnUuXzUDwOEM4urZIvFRDaGPPUnn+n6167VvjjG6cGVERvdIFdUC/nimPTWQmUt8K1CGM8S9xRPoBSz6Ck5CuWd17H+gsGmD96paWlqFNDKrPbaT333KLEUXlIj1aZTI2b70A9M21Cc6HDIiI0eU8iot2V+tg69lCrdKP1P7kF12Fd8ngAtVQyHnDWyzNfRNygD/ZxGOg+1gRxEWtTZKPnEo748K/c1CDTMn9ezEygNUWAPafD8n3o1uvlxUhrZFNVMiQK1P4JNaXtZ8yobhr052NranxLMFnkfnTxStDzZwWa2/QmogQbbtvekltOQPfWFlo6ZAxHl4nnjKEZYRrCWxUpvftsOkgQqYnGOZwRy5GSM/3NTIS0SPfZAJilyAgnpcXWDDcHDNcvUj3RngNwTgCs52P4= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 569a884b-7933-46f5-6292-08d3f46cecb9 X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1410; 2:wAyfiwKi+a6Irj/faIxbLuKRD2fOCYhVfSL0gvaeDlD57SP5NTz2Kh6YtAx0q1I49z9zIh1FNsrdPKE47TooYr9+w+rXai1pJ2t1R9sn4pK2Lq/5nPDQsrZDjRXvBw+car9CdsukV+rshZrIZdaSzD5/YYYpMLDHJabQO+NFDOhHciydOw6M5n7TyVvoYkih7OyDCaOpfNfBv25f4Updkg==; 3:KOw82x8H93PALIL1JNWEUew1PIFVFI2FPTAeE1+F3kQ/HBc8ILa95+UGo9TDLww1lyN15SUF/PoYqcN5hwTXcFvByJJJwHeBcvuYCFKN7YDJE7+oEf7mKp81F9EGVS22HD4TUPK976kC5Z62CSghRV0GJ/BtCs9ItGt9OCg50J1I8uvcekxCIbpp8bd+xWZMkYSmBXVwgwaQ8LCVj/ztmi+0s6yeNIjL4R2j71DYj48UjQxpiT81Vafx9U/hfJVL X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1410; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1410; 25:gjP2C+je23PEmcwUffV/ga4HBXYmERkUbEh9vbMFXWmusHTmXN2yri13VCAmuyDFfN0kQK0Z5FYfDbF7tKZ1LqwYXXoYt+y4KpMzX+EBZ2FhyvnQXKYqgY/F1NqP/N0eTZlmwI96xGR43sZ8dDuuQKmWC9Voznwo4chDkZL5RS2d23sXmhI3nmRLa28/dJd4ow4AaoOFP976UhpW01/iYfHXht3/UKwlINReaEDhSuDxljRO0TtjpDIQqbkyuWndAqzxnP9PouC6xXnkNq4lDFjUSZEyrVdcr81aWTZeoJr3+g2s5ulhn0Xkr9fTx+Tx7HydoLrAfV89Q2xqKGzp6em9HakrlaXT5IpS01RKa044lccpKi7Ai8XB5+ZiptuWiE+BxR3DdXTH4EPDzk+C2ENOH1JgZThPSF9JrJb/YG95gPSiWna+sweQ8iUfxvGVkP84m0jdxBlmlNUZdTPNXRFUWzo+UNvh1kb9olNPStWDSChYM7+t3oviIA0csaxZFky63bmY4j4n+MLR7mIQCszumepdfXlSfMPtUsXkCq040Qhevjq+FWxy/tV5Tf+eeNN7WhTttAjymDOMJ2eoxTvDQAWVpmfFcXeRV+3lMF4Gm8DEJUpZu/dNNJTpos8Q2Eozj4oDDMqzArIyaHqDa+76yji0LmajiKNxQlDaEuZ+svUx5wNz5e1QXLrL5EklA1B0U9Bvs6vUb0ym8ciGnP44BC5XbPf+y+/P8bNtiV9Dpg9bNuQHuHd00szCRoidmmqP9xgAUv9G3Qu1al43Uw== X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1410; 31:fMCibM8MhxlmUGqUr4pjnuMFBBzoXOTe1vgmax2Cr0ltjA/AibKuf/yW5ORUoYGbHNqSGGL+neAY/MmTIvLjIOCjTqU81BeAWk+n+p5g0+u0wEWkqn0GNkfBZjYDSKRmjNw1mYYLlTMdtQGe3DFdgFoEEqS2VzbQilxuS0n0fmErqsucFJQBs/69l6SmdopfX2OSmQJ3XQ6cffyjcJnoCbFHK3wITCzuSmyqiJLjY+yJro2Oq8icB8aOZO4kdq0mksXeCRvhgb4To9jNO76ZPMe9zZERqnIu/0TAAnivcf4=; 4:KPgLHnNQoFr2/pAZYN24PW6YWfNDqiXMH9oKhv8T+HQl/p71RS9noq7v6IN4QZ4jkSgMBbj056b9ogufxW8d1slaAiDQPOOY89LW7u6kaCmFZPeS/Byymr3rRkhlZT6+M7mLwyfDdr1p66C+fsjZGatv9jYmlz+QIYf+TVRO4QcQC46Nta17RwOGg5E+3N1ThZnKNLIoGk1qksxbInEDbehC9vGR47VF7IwhH3V1t3DD0OhKtHkxH2bbS4wJOAI4imTdqsNfPE56BN/bv1WJg/3BMZIQBwKerL1jKV8G3q64JjxNrlvSYMgM110gVJF10OsblYdLvNjo3CjLDOvGAB0XGM+3yrTSRJ/VOTwBgfjMrpNRyV0PZqUw3fQAo1H0H/gKnbnaGgmr+rhMcyWKpnjAlM3m6PryeDXPxbhNXucANC7w6wNfSMV5pywB+nc6ML+++saO1H9GvO4qH71L3EvrUVAjTXj6vCleTqvIm5JZv6mRlFI6zikuaxPHkB33qlQKrX4BmtVD2DJ6Fc74cA1uLYs53UhWonTM6xpBxDjVchQuKWDwUaO8+hFg2AU/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13015025)(5005006)(8121501046)(13018025)(13023025)(13017025)(13024025)(10201501046)(3002001)(6055026); SRVR:BLUPR03MB1410; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR03MB1410; X-Forefront-PRVS: 0095BCF226 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR03MB1410; 23:l1iHKI0kVEBb6ywo04De8MVFASgpzFWaVbR1uiS9i?= =?us-ascii?Q?rXhOfr6vwXYJm4CBWiYKzZ0zm5Z2ABxj0f+Zz0VMmUCdxGln0QR6Bqdnoogg?= =?us-ascii?Q?/T/VFG1YYPPbb/sckxuNJS7fAHThga0tZMdHlK839ukF1DcgccCaVwzobpzF?= =?us-ascii?Q?aJcR7+qzAOkdBLnAeimSpuGgwdNNhW5Tu7BoUiEkcIbmpSF/eehVh4oEywbV?= =?us-ascii?Q?4rF5Q/u2oqa1+mdqE6qC3NwLg6LFlk1lO8fJxmc82028KAqv5jEvEL//vPuV?= =?us-ascii?Q?ipH3emJZDYFFj10yvISN0+ZYPYWhIHmYj1a9BHa8gzNdSXbx29ToI6oTigCJ?= =?us-ascii?Q?Mf69LUKZLP2ZzdVdiC8LDgT5Ql9dCSWzOqpUCtXK6866Zt4zsdcuWvWJLYkU?= =?us-ascii?Q?0CJ3wQOKv+Apz1Hn77fFChY8XW0Ut4SsEsiTV8RszHQMLHNunbwQjwaaX3Ve?= =?us-ascii?Q?7Nf00wR+C9Tb7l7CyXCRWRiybjY34Q0m3Zi1QeNpJ26GPyQbnmyUQqAIpJD0?= =?us-ascii?Q?cqnBn6rWjv2p5GrCXWOVr+9//Z7+5r5DChgHGfrBxYU3XN86stFW1Wv2L5pT?= =?us-ascii?Q?v05TwSUQj308H8jPwoKxF7HRC3TT2KtWSN1qrY8R51nWFiUyhgerp9p1c1b9?= =?us-ascii?Q?jPuL+Cmoc1a2nd6kDyVYr6iyIDwkaeIwQK1Ngf5YqAv1IV+0kZUWbe5N/1P9?= =?us-ascii?Q?Zw6pY8lkmXnsDxSFQQw0xvyciv5Qd0VMVAhKbzcNXAp1jZmbVe4jdgocS4Ta?= =?us-ascii?Q?IhiqJ+w+T4UcmfoAh50WS/VwXtwt/Ev1hKgdJDU8CeVtkVeDJ1obpKRARqGa?= =?us-ascii?Q?c9HJJ8MO3fH2Z/bmcyNrRuUVMKBZDcudGu1miwIeY9SgH5sbz/CeN1LtfIjy?= =?us-ascii?Q?I9GYb1g9Yjkivby/SSZHw4bxxNSYDMuU+z03IskhllRMUlzHKd0SbhFoPJtG?= =?us-ascii?Q?gZ/jpkV+1pxIgUYOMBE4ukyWUNxSaBfAXz+smARXftbpKiIgMhhiJMpBo034?= =?us-ascii?Q?ZVh038A28tqtmBjt3QWB89fRFQYcYD0RgH6BCfNRXoSMx43DgzK5BXD2z+Gd?= =?us-ascii?Q?pYkMesdbBKwMwG/FkF71N8Mmf7zhWQalQ4Wuq+A7SY4vSsHZ8WSXxIImcTl8?= =?us-ascii?Q?9ilERAlAbD19FrKcJ4xs8a+JGqtI0pD7WuXIoBGa8cgFK/A7Wukr9k7idy/n?= =?us-ascii?Q?dVGbl+LC+0s6E59YFfUbgRJu5m0dkcMr6VoDmgTwsvM+J+n0Eh1UY8Ccxb22?= =?us-ascii?Q?SvigHmApnf+5zKniXuqAuNEwOBRytKynq796RKKQPKoWX51BezEr2cBp08T7?= =?us-ascii?B?Zz09?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1410; 6:gdT/q3DPFJKY0eS2NSBZ+/FsupBvbhPoOG/JsSzWOiulgwbeuKq5sNvyE+yzjKuYvlmaIutlRLSO988CgpWP5+DEMR0yT8NsNsZ+OM4eT8ivIe9uwUtSYpRTd0Yx5/imdjfFTUhL1ibUHsDlozKNdBiKu/r0VWtgUcmix1cJ5M1EJ0191BFMAK8BHi68TRSy9AlRvL7qmYH/nM5DlGMBm8eOVEJLxT4pGpSLlp/P3DfqZbPyuewZbJ/8d1zYEAegg3fi4EQUd7cHCtngkoVygMbuNuTLi3hlYrdE6KtexXe9eBEtztPQxpZOLkWP004U; 5:aZqGUGTUlbNWfPFSHtyDR5VSBuMC0VBOzDCyn1mvP9MaXr7Obw090DT4OlX+1rWWsT9J3j5NnzhoMH6FatKhZoekAKiO1zQMTI0HgpBwO9ilrN/4QUfOMb2II9TI+/B0Ih4k8uthwwQxRrNMYoe5wRM5D51t0mun6RH4R3+SHSTZj+wf2OW02eDm0MgkNaFq; 24:LQsamJoJ1n7o7H2TjWEkaIER7AQ4maGxu16oRPDhx3Ngx8rpVAddMfplwFGD0MN4a0M9dbTquclrJhQhaXHm9uh+8Lnk0CQyD1N0ektCrIQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1410; 7:hj6XFpOpMActQQNJkKorzp6rYQWc0u52dygBMZp4upTiWdGrRODluED0jvBY8Mbdhk48Je7C4sL0eSyYEmaIdFVlk0sDznuUu6KqoNwETBwA6HPpMX76l1UGbOX9avv51ijcxuMC6EW2ZV9BN2mhQq0dAeiq9Aon2Ehs/+Mv25Jd/Ds4yGKBRuRIyEktfjch2zXq+9GWuTx1znVfETQcPgtTuCjvdMi+QdxKKJKYePixXbXd3SQdF3PlI7b5cIPz272yndWVtHo+/JHRZG+J1PpRWh4Gsp1ein4UJhyvK0Mt8mCVpIaytZgUHDAruClL0L2zpnsVnSAarPXmZCJmSi/nJB7GfT1AunpEn0uA2NI= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2016 20:01:45.3497 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1410 Cc: Albert Aribaud , David Feng , Stephen Warren , Thierry Reding Subject: [U-Boot] [RFC PATCH 1/2] armv8: Fix dcache disable function X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Current code turns off d-cache first, then flush all levels of cache. This results data loss. As soon as d-cache is off, the dirty cache is discarded according to the test on LS2080A. This issue was not seen as long as external L3 cache was flushed to push the data to main memory. However, external L3 cache is not guaranteed to have the data. To fix this, flush the d-cache by way/set first to make sure cache is clean before turning it off. Signed-off-by: York Sun CC: David Feng --- arch/arm/cpu/armv8/cache_v8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv8/cache_v8.c b/arch/arm/cpu/armv8/cache_v8.c index cd3f6c1..92d6277 100644 --- a/arch/arm/cpu/armv8/cache_v8.c +++ b/arch/arm/cpu/armv8/cache_v8.c @@ -478,9 +478,9 @@ void dcache_disable(void) if (!(sctlr & CR_C)) return; + flush_dcache_all(); set_sctlr(sctlr & ~(CR_C|CR_M)); - flush_dcache_all(); __asm_invalidate_tlb_all(); }