diff mbox

[U-Boot,2/2] tools/env: soften warning about erase block alignment

Message ID 1471470114-27721-3-git-send-email-andreas.fenkart@digitalstrom.com
State Accepted
Commit 4ed6f4318be9fff2df344ba7ac678736c4b6f3d6
Delegated to: Tom Rini
Headers show

Commit Message

Andreas Fenkart Aug. 17, 2016, 9:41 p.m. UTC 
addon 183923d3e
MMC/SATA have no erase blocks, only blocks. Hence the warning
about erase block alignment might be confusing in such environment.

Signed-off-by: Andreas Fenkart <andreas.fenkart@digitalstrom.com>
---
 tools/env/fw_env.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Aug. 19, 2016, 7:55 p.m. UTC | #1 
On Wed, Aug 17, 2016 at 11:41:54PM +0200, Andreas Fenkart wrote:

> addon 183923d3e
> MMC/SATA have no erase blocks, only blocks. Hence the warning
> about erase block alignment might be confusing in such environment.
> 
> Signed-off-by: Andreas Fenkart <andreas.fenkart@digitalstrom.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Tom Rini Aug. 21, 2016, 3:09 p.m. UTC | #2 
On Wed, Aug 17, 2016 at 11:41:54PM +0200, Andreas Fenkart wrote:

> addon 183923d3e
> MMC/SATA have no erase blocks, only blocks. Hence the warning
> about erase block alignment might be confusing in such environment.
> 
> Signed-off-by: Andreas Fenkart <andreas.fenkart@digitalstrom.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
index 7cc7488..d27f57e 100644
--- a/tools/env/fw_env.c
+++ b/tools/env/fw_env.c
@@ -1295,7 +1295,7 @@  static int check_device_config(int dev)
 	int fd, rc = 0;
 
 	if (DEVOFFSET(dev) % DEVESIZE(dev) != 0) {
-		fprintf(stderr, "Environment does not start on erase block boundary\n");
+		fprintf(stderr, "Environment does not start on (erase) block boundary\n");
 		errno = EINVAL;
 		return -1;
 	}