diff mbox

[U-Boot,1/3] pico-imx6ul: Directly write to register LDOGCTL

Message ID 1471437984-5281-1-git-send-email-fabio.estevam@nxp.com
State Accepted
Commit 938076efa99be181eb3e8e64eee5c298d24663c5
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam Aug. 17, 2016, 12:46 p.m. UTC 
Register LDOGCTL contains only bit 0 as a valid bit, so there is no need
to do a read-modify-write operation.

Simplify the code by writing directly to this register.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 board/technexion/pico-imx6ul/pico-imx6ul.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Stefano Babic Sept. 6, 2016, 8:19 a.m. UTC | #1 
On 17/08/2016 14:46, Fabio Estevam wrote:
> Register LDOGCTL contains only bit 0 as a valid bit, so there is no need
> to do a read-modify-write operation.
> 
> Simplify the code by writing directly to this register.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---


Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/board/technexion/pico-imx6ul/pico-imx6ul.c b/board/technexion/pico-imx6ul/pico-imx6ul.c
index 5cbf803..49aeb80 100644
--- a/board/technexion/pico-imx6ul/pico-imx6ul.c
+++ b/board/technexion/pico-imx6ul/pico-imx6ul.c
@@ -231,9 +231,7 @@  int power_init_board(void)
 	printf("PMIC: PFUZE3000 DEV_ID=0x%x REV_ID=0x%x\n", reg, rev_id);
 
 	/* disable Low Power Mode during standby mode */
-	pmic_reg_read(pfuze, PFUZE3000_LDOGCTL, &reg);
-	reg |= 0x1;
-	pmic_reg_write(pfuze, PFUZE3000_LDOGCTL, reg);
+	pmic_reg_write(pfuze, PFUZE3000_LDOGCTL, 0x1);
 
 	/* SW1B step ramp up time from 2us to 4us/25mV */
 	pmic_reg_write(pfuze, PFUZE3000_SW1BCONF, 0x40);