From patchwork Sat May 28 08:06:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Chauvet X-Patchwork-Id: 627656 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3rJ9xW1Xzyz9t4b for ; Mon, 30 May 2016 19:17:19 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=t8tWtDMH; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 8A76EA75F8; Mon, 30 May 2016 11:16:54 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0e1YP8SfL1jf; Mon, 30 May 2016 11:16:54 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2E3ABA7580; Mon, 30 May 2016 11:16:25 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7C178A74BA for ; Sat, 28 May 2016 10:07:04 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OpL1cSdBz9nw for ; Sat, 28 May 2016 10:07:04 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by theia.denx.de (Postfix) with ESMTPS id 372BAA7498 for ; Sat, 28 May 2016 10:07:00 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id e3so5755409wme.2 for ; Sat, 28 May 2016 01:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8bLt43mZUZtFjm2bY94j1Z3MpnQkdoc5YJWvH2n55U4=; b=t8tWtDMH7wGcFQTDY7bjPj5O56vQ4w8PKcjs6wkEHmC63XpXzihwQd9M6R7jF3I9OR CHlfCC/vOIbwueCkdfIrzHM2iJuDRMd7HMIZwbRRdCDEECrp7fiab5Z3lvzSU4lppPed r66uSOU2Pg2/7fcsmG8hc6JpxFTXJ4aW4sIzNuTwIYBzmR0rGkwcB3hfY1qPimRzttge VVQnIOKWQmtLqfPlrVMwaAJKAlkQrcuJKKmTLMSC2Xfup5DQXPO8Q2q6894wPfITJNy+ f4iFbHOKgHveeB7NFXMjEJyd29zW4bXj1SKgRZKzXyHaZScYCWk7yOxBUagduptpf+1w HIMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8bLt43mZUZtFjm2bY94j1Z3MpnQkdoc5YJWvH2n55U4=; b=hmQkpqfh2HiK1UvsaVSxI+Fic+Xjq5HNuuArU1DGbkxGg/6MlUhnhhgTZO8Tjz4X3s z0DnsS4SQAGJaHSVgjiGRcSp59in5j2JfgEJlhQbrEuAJBZhxylh4L0p2RzHC2wHN4Ao 9xXaLFCJ6NfnFzzGoxV6nr7mJa3PCLdCDDgoKoFSecnuNtrXMG90adG0YW/iIgDis/Os cKg2CJ79GNJ/tTXYh5kYWo91GQs3Mf5Nw4s2OEmC4usRMgsRyq08iPP5wzCwZeMPhBJf mdvDVsjl6bQfZekLWf5Ka1bMOtQ/mgiaaxl4rJXUwkmJAs1WRr55uoaLu/EKWPYsto4k J2qg== X-Gm-Message-State: ALyK8tJsgz12jafj8vfrcCqoaDdYohNMz4oG8VzmGA23qrmirZe/aMhKvYro/9Mzk/ekYQ== X-Received: by 10.194.108.197 with SMTP id hm5mr18641654wjb.167.1464422819975; Sat, 28 May 2016 01:06:59 -0700 (PDT) Received: from arrakis.kwizart.net.numericable.fr (ip-119.net-82-216-114.rev.numericable.fr. [82.216.114.119]) by smtp.gmail.com with ESMTPSA id f12sm12394954wme.13.2016.05.28.01.06.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 May 2016 01:06:58 -0700 (PDT) From: Nicolas Chauvet To: Marek Vasut , Stephen Warren Date: Sat, 28 May 2016 10:06:38 +0200 Message-Id: <1464422798-6930-1-git-send-email-kwizart@gmail.com> X-Mailer: git-send-email 2.4.11 In-Reply-To: <1464296140-22085-1-git-send-email-kwizart@gmail.com> References: <1464296140-22085-1-git-send-email-kwizart@gmail.com> Cc: U-Boot Mailing List Subject: [U-Boot] [PATCH] Lower USB_MAX_XFER_BLK to 32767 for trimslice X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" I'm experiencing an issue when loading a generic distro initramfs on trimslice-pro (with ssd using usb-ehci) with the default value of 65535 for USB_MAX_XFER_BLK EHCI timed out on TD - token=0x80008d80 As adviced by Marek on IRC, using a lower value for USB_MAX_XFER_BLK allows to load the file Tested values on tegra20-trimslice: 4095 ok 32767 ok 32768 timeout 36864 timeout 40960 timeout 49150 timeout v2: - Allow to override if undefined when using CONFIG_USB_EHCI - Only change the value for trimslice - Update description Signed-off-by: Nicolas Chauvet --- common/usb_storage.c | 2 ++ include/configs/trimslice.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/common/usb_storage.c b/common/usb_storage.c index 7e6e52d..aea0477 100644 --- a/common/usb_storage.c +++ b/common/usb_storage.c @@ -106,7 +106,9 @@ struct us_data { * enough free heap space left, but the SCSI READ(10) and WRITE(10) commands are * limited to 65535 blocks. */ +#ifndef USB_MAX_XFER_BLK /* Allows a quirk for broken devices */ #define USB_MAX_XFER_BLK 65535 +#endif #else #define USB_MAX_XFER_BLK 20 #endif diff --git a/include/configs/trimslice.h b/include/configs/trimslice.h index b761640..3a2fe87 100644 --- a/include/configs/trimslice.h +++ b/include/configs/trimslice.h @@ -43,6 +43,8 @@ #define CONFIG_USB_EHCI #define CONFIG_USB_EHCI_TEGRA #define CONFIG_USB_STORAGE +/* Quirk for broken usb-ehci on trimslice */ +#define USB_MAX_XFER_BLK 32767 /* USB networking support */ #define CONFIG_USB_HOST_ETHER