Message ID | 1462632397-11224-4-git-send-email-bmeng.cn@gmail.com |
---|---|
State | Accepted |
Delegated to: | Bin Meng |
Headers | show |
On 7 May 2016 at 08:46, Bin Meng <bmeng.cn@gmail.com> wrote: > Fix the following two build warnings in function 'write_acpi_tables': > > warning: format '%lx' expects argument of type 'long unsigned int', > but argument 2 has type 'u32' [-Wformat=] > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > Reviewed-by: Stefan Roese <sr@denx.de> > Tested-by: Stefan Roese <sr@denx.de> > --- > > Changes in v2: None > > arch/x86/lib/acpi_table.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org> (nit - you could remove the period in 'Writing ACPI tables')
On Sun, May 8, 2016 at 2:46 AM, Simon Glass <sjg@chromium.org> wrote: > On 7 May 2016 at 08:46, Bin Meng <bmeng.cn@gmail.com> wrote: >> Fix the following two build warnings in function 'write_acpi_tables': >> >> warning: format '%lx' expects argument of type 'long unsigned int', >> but argument 2 has type 'u32' [-Wformat=] >> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >> Reviewed-by: Stefan Roese <sr@denx.de> >> Tested-by: Stefan Roese <sr@denx.de> >> --- >> >> Changes in v2: None >> >> arch/x86/lib/acpi_table.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> > > (nit - you could remove the period in 'Writing ACPI tables') Fixed nits and applied to u-boot-x86/next, thanks!
diff --git a/arch/x86/lib/acpi_table.c b/arch/x86/lib/acpi_table.c index 790f6fb..0b1775c 100644 --- a/arch/x86/lib/acpi_table.c +++ b/arch/x86/lib/acpi_table.c @@ -353,7 +353,7 @@ u32 write_acpi_tables(u32 start) /* Align ACPI tables to 16byte */ current = ALIGN(current, 16); - debug("ACPI: Writing ACPI tables at %lx.\n", start); + debug("ACPI: Writing ACPI tables at %x.\n", start); /* We need at least an RSDP and an RSDT Table */ rsdp = (struct acpi_rsdp *)current; @@ -432,7 +432,7 @@ u32 write_acpi_tables(u32 start) current = ALIGN(current, 16); } - debug("current = %lx\n", current); + debug("current = %x\n", current); debug("ACPI: done.\n");