diff mbox

[U-Boot,2/2] board/t4240rdb: some ethernet ports shouldn't be detected

Message ID 1460701149-36278-2-git-send-email-ying.zhang@freescale.com
State Accepted
Commit 8ef548d5f13e68e1b3975d9b68920bfa8bf09891
Delegated to: York Sun
Headers show

Commit Message

ying.zhang@freescale.com April 15, 2016, 6:19 a.m. UTC 
From: Ying Zhang <b40530@freescale.com>

FM1_DTSEC9 & FM1_DTSEC10 should not be detected.

Signed-off-by: Ying Zhang <b40530@freescale.com>
---
 drivers/net/fm/t4240.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shengzhou Liu April 15, 2016, 7:45 a.m. UTC | #1 
> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of
> ying.zhang@freescale.com
> Sent: Friday, April 15, 2016 2:19 PM
> To: u-boot@lists.denx.de
> Cc: yorksun@freescale.com; Ying Zhang <b40530@freescale.com>
> Subject: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports
> shouldn't be detected
> 
> From: Ying Zhang <b40530@freescale.com>
> 
> FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
> 
> Signed-off-by: Ying Zhang <b40530@freescale.com>
> ---
>  drivers/net/fm/t4240.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c index
> ae5aca4..70887fa 100644
> --- a/drivers/net/fm/t4240.c
> +++ b/drivers/net/fm/t4240.c
> @@ -74,7 +74,7 @@ phy_interface_t fman_port_enet_if(enum fm_port port)
>  	if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) &&
>  	    ((is_serdes_configured(XFI_FM1_MAC9)) ||
>  	     (is_serdes_configured(XFI_FM1_MAC10))))
> -		return PHY_INTERFACE_MODE_XGMII;
> +		return PHY_INTERFACE_MODE_NONE;

This patch is making things wrongly, FM1_DTSEC9 & FM1_DTSEC10 should be configured when RCW uses the these MACs.
-Shengzhou
Wolfgang Denk April 15, 2016, 7:52 a.m. UTC | #2 
Dear ying.zhang@freescale.com,

In message <1460701149-36278-2-git-send-email-ying.zhang@freescale.com> you wrote:
> From: Ying Zhang <b40530@freescale.com>
> 
> FM1_DTSEC9 & FM1_DTSEC10 should not be detected.

Can you please explain (and add the explanation to the commit message)
what this means?

Are this ports detected, but not predent on this board?  Or should
they be hidden for some purpose? Why?  Or what else?

Best regards,

Wolfgang Denk
Shengzhou Liu April 15, 2016, 7:58 a.m. UTC | #3 
> -----Original Message-----
> From: Shengzhou Liu
> Sent: Friday, April 15, 2016 3:45 PM
> To: 'ying.zhang@freescale.com' <ying.zhang@freescale.com>; u-
> boot@lists.denx.de
> Cc: yorksun@freescale.com; Ying Zhang <b40530@freescale.com>
> Subject: RE: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports
> shouldn't be detected
> 
> 
> > -----Original Message-----
> > From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of
> > ying.zhang@freescale.com
> > Sent: Friday, April 15, 2016 2:19 PM
> > To: u-boot@lists.denx.de
> > Cc: yorksun@freescale.com; Ying Zhang <b40530@freescale.com>
> > Subject: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports
> > shouldn't be detected
> >
> > From: Ying Zhang <b40530@freescale.com>
> >
> > FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
> >
> > Signed-off-by: Ying Zhang <b40530@freescale.com>
> > ---
> >  drivers/net/fm/t4240.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c index
> > ae5aca4..70887fa 100644
> > --- a/drivers/net/fm/t4240.c
> > +++ b/drivers/net/fm/t4240.c
> > @@ -74,7 +74,7 @@ phy_interface_t fman_port_enet_if(enum fm_port
> port)
> >  	if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) &&
> >  	    ((is_serdes_configured(XFI_FM1_MAC9)) ||
> >  	     (is_serdes_configured(XFI_FM1_MAC10))))
> > -		return PHY_INTERFACE_MODE_XGMII;
> > +		return PHY_INTERFACE_MODE_NONE;
> 
> This patch is making things wrongly, FM1_DTSEC9 & FM1_DTSEC10 should
> be configured when RCW uses the these MACs.
> -Shengzhou
Sorry, I missed the condition, the change is right.
Shengzhou
shaohui xie April 15, 2016, 8:17 a.m. UTC | #4 
Hi Ying,

The commit message should be more clear about what is wrong.
Like when using protocols to support 10G on MAC9 and MAC10, these
MACs should not be identified as 1G interface, otherwise, one MAC will be
Listed as two Ethernet ports, for ex. MAC9 will be listed as FM1@TGEC1
And FM1@DTSEC9.

Thanks,
Shaohui

> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Shengzhou Liu
> Sent: Friday, April 15, 2016 3:58 PM
> To: ying.zhang@freescale.com; u-boot@lists.denx.de
> Cc: yorksun@freescale.com; Ying Zhang <b40530@freescale.com>
> Subject: Re: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't
> be detected
> 
> 
> 
> > -----Original Message-----
> > From: Shengzhou Liu
> > Sent: Friday, April 15, 2016 3:45 PM
> > To: 'ying.zhang@freescale.com' <ying.zhang@freescale.com>; u-
> > boot@lists.denx.de
> > Cc: yorksun@freescale.com; Ying Zhang <b40530@freescale.com>
> > Subject: RE: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports
> > shouldn't be detected
> >
> >
> > > -----Original Message-----
> > > From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of
> > > ying.zhang@freescale.com
> > > Sent: Friday, April 15, 2016 2:19 PM
> > > To: u-boot@lists.denx.de
> > > Cc: yorksun@freescale.com; Ying Zhang <b40530@freescale.com>
> > > Subject: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports
> > > shouldn't be detected
> > >
> > > From: Ying Zhang <b40530@freescale.com>
> > >
> > > FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
> > >
> > > Signed-off-by: Ying Zhang <b40530@freescale.com>
> > > ---
> > >  drivers/net/fm/t4240.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c index
> > > ae5aca4..70887fa 100644
> > > --- a/drivers/net/fm/t4240.c
> > > +++ b/drivers/net/fm/t4240.c
> > > @@ -74,7 +74,7 @@ phy_interface_t fman_port_enet_if(enum fm_port
> > port)
> > >  	if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) &&
> > >  	    ((is_serdes_configured(XFI_FM1_MAC9)) ||
> > >  	     (is_serdes_configured(XFI_FM1_MAC10))))
> > > -		return PHY_INTERFACE_MODE_XGMII;
> > > +		return PHY_INTERFACE_MODE_NONE;
> >
> > This patch is making things wrongly, FM1_DTSEC9 & FM1_DTSEC10 should
> > be configured when RCW uses the these MACs.
> > -Shengzhou
> Sorry, I missed the condition, the change is right.
> Shengzhou
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
diff mbox

Patch

diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c
index ae5aca4..70887fa 100644
--- a/drivers/net/fm/t4240.c
+++ b/drivers/net/fm/t4240.c
@@ -74,7 +74,7 @@  phy_interface_t fman_port_enet_if(enum fm_port port)
 	if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) &&
 	    ((is_serdes_configured(XFI_FM1_MAC9)) ||
 	     (is_serdes_configured(XFI_FM1_MAC10))))
-		return PHY_INTERFACE_MODE_XGMII;
+		return PHY_INTERFACE_MODE_NONE;
 
 	if ((port == FM2_10GEC1 || port == FM2_10GEC2) &&
 	    ((is_serdes_configured(XAUI_FM2_MAC9))	||