diff mbox

[U-Boot,05/10] ddr: altera: Remove unnecessary update of the SCC

Message ID 1459994646-11013-5-git-send-email-marex@denx.de
State Accepted
Commit f5f8c411de0c1971475069ac011c858ca914eae7
Delegated to: Marek Vasut
Headers show

Commit Message

Marek Vasut April 7, 2016, 2:04 a.m. UTC 
Every invocation of the scc_mgr_set_dqs_en_delay_all_ranks() is
followed by SCC manager update. Moreover, only this function
triggers the SCC manager update internally. Thus, remove the
internal invocation to avoid triggering the update twice.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: Chin Liang See <clsee@altera.com>
---
 drivers/ddr/altera/sequencer.c | 1 -
 1 file changed, 1 deletion(-)

Comments

George Broz April 8, 2016, 10:14 p.m. UTC | #1 
On 6 April 2016 at 19:04, Marek Vasut <marex@denx.de> wrote:
> Every invocation of the scc_mgr_set_dqs_en_delay_all_ranks() is
> followed by SCC manager update. Moreover, only this function
> triggers the SCC manager update internally. Thus, remove the
> internal invocation to avoid triggering the update twice.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Chin Liang See <clsee@altera.com>
> ---
>  drivers/ddr/altera/sequencer.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ddr/altera/sequencer.c b/drivers/ddr/altera/sequencer.c
> index 3859e66..6bf75ba 100644
> --- a/drivers/ddr/altera/sequencer.c
> +++ b/drivers/ddr/altera/sequencer.c
> @@ -424,7 +424,6 @@ static void scc_mgr_set_dqs_en_delay_all_ranks(u32 read_group,
>          */
>         scc_mgr_set_all_ranks(SCC_MGR_DQS_EN_DELAY_OFFSET,
>                               read_group, delay, 1);
> -       writel(0, &sdr_scc_mgr->update);
>  }
>
>  /**
> --
> 2.7.0
>

Tested on: SoCKit, DE0_Nano_SoC
Tested-by: George Broz <brozgeo at gmail.com>
diff mbox

Patch

diff --git a/drivers/ddr/altera/sequencer.c b/drivers/ddr/altera/sequencer.c
index 3859e66..6bf75ba 100644
--- a/drivers/ddr/altera/sequencer.c
+++ b/drivers/ddr/altera/sequencer.c
@@ -424,7 +424,6 @@  static void scc_mgr_set_dqs_en_delay_all_ranks(u32 read_group,
 	 */
 	scc_mgr_set_all_ranks(SCC_MGR_DQS_EN_DELAY_OFFSET,
 			      read_group, delay, 1);
-	writel(0, &sdr_scc_mgr->update);
 }
 
 /**