diff mbox

[U-Boot] cmd: spi: check return value of strdup

Message ID 1458480096-387-1-git-send-email-van.freenix@gmail.com
State Accepted
Commit 9caeb26c5446fbf835c88c0bfc470d66aaad82c6
Delegated to: Tom Rini
Headers show

Commit Message

Peng Fan March 20, 2016, 1:21 p.m. UTC 
Check return value of strdup.

Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Przemyslaw Marczak <p.marczak@samsung.com>
Cc: Bin Meng <bmeng.cn@gmail.com>
Cc: Heiko Schocher <hs@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Stefan Roese <sr@denx.de>
Cc: Tom Rini <trini@konsulko.com>
---
 cmd/spi.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Tom Rini March 27, 2016, 10:28 p.m. UTC | #1 
On Sun, Mar 20, 2016 at 09:21:36PM +0800, Peng Fan wrote:

> Check return value of strdup.
> 
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/cmd/spi.c b/cmd/spi.c
index 64c3ffc..f16ef9a 100644
--- a/cmd/spi.c
+++ b/cmd/spi.c
@@ -51,6 +51,8 @@  static int do_spi_xfer(int bus, int cs)
 
 	snprintf(name, sizeof(name), "generic_%d:%d", bus, cs);
 	str = strdup(name);
+	if (!str)
+		return -ENOMEM;
 	ret = spi_get_bus_and_cs(bus, cs, 1000000, mode, "spi_generic_drv",
 				 str, &dev, &slave);
 	if (ret)