From patchwork Sun Mar 13 14:22:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 596758 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3qNNRY0pdcz9s6n for ; Mon, 14 Mar 2016 01:24:09 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b=IJbzy0GH; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 98551A771A; Sun, 13 Mar 2016 15:23:17 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BEo_zj9hS2wN; Sun, 13 Mar 2016 15:23:17 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 8A777A7701; Sun, 13 Mar 2016 15:23:16 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 325CEA76DB for ; Sun, 13 Mar 2016 15:22:50 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LGcw7AseWmsU for ; Sun, 13 Mar 2016 15:22:50 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-ig0-f174.google.com (mail-ig0-f174.google.com [209.85.213.174]) by theia.denx.de (Postfix) with ESMTPS id 62EFCA76E7 for ; Sun, 13 Mar 2016 15:22:42 +0100 (CET) Received: by mail-ig0-f174.google.com with SMTP id ig19so44306392igb.1 for ; Sun, 13 Mar 2016 07:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=eOsUkmcdcYQZqHuIkgU6ZzpYb2sHJkAh7XiC1506+zk=; b=IJbzy0GHS8TjB5c8WONHe42/qgujPNuaVbNhnsTykG/HqmuMG13WXNhhVeUEzE9Too NS9hYQXTncI2McZCe58nzMoOCACcVAoWTXVkmn2+2/v43/1Es13y8BtT5FeJ8jyMrLj7 Na4kHNIqaJmuQuJjVtDyZM/GGsHWiUmiMJUWy7NBEvy5siubFn35nuiNUIDDllUGEe/3 mHFc6x4SPvbwP7CfsQw97Pwzlhi0I2miPSKoBBoivVqQnywKEvPE71Ev8m4LWpXLC5J5 sTPtXxWqVxNB2duNaGp/+eXQQLnUe83eRXmaIk/4cD+mng5WEblj8o8sjaaXqxyumRsh 6Arg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=eOsUkmcdcYQZqHuIkgU6ZzpYb2sHJkAh7XiC1506+zk=; b=eLIlWrJbwHImw6QQ53+SeuenKsO+m7Xzv2HYZkjfVpmUpJiNz/RFSZzhCmkaeYL5xA hCm2YHUbuiu6gI+y7IhqGA861MjClwwGs254r9q38FyDkf4b+dQYbs9ubF07ka3E1J0i dFOOWMldhif2c25rIMw2mdbR6j9enCVrIIDKjAoyD/54jDcPmNBJoaI5JUklC6rlgfc/ z42GB2hVhyW1JkAFYetNi9NYp8+tltQNp1ll7PiRVKhDhyemOn9flIb5YBtyr7CU6zOv eQGSjnAiQAC1Ad3oFGTI88Q97jPIPiSBP0JBFOVv19pAVNe8CbQv8MBzrtChePk0O2IP Tq+g== X-Gm-Message-State: AD7BkJLfRsS0F/99/ZHMpojaesTmgCLs1unkJi62zHw4ITbxr4RO3YVYd2mZF+vOJPDgaF4W X-Received: by 10.50.92.5 with SMTP id ci5mr12610428igb.70.1457878960681; Sun, 13 Mar 2016 07:22:40 -0700 (PDT) Received: from kaki.bld.corp.google.com ([172.29.216.32]) by smtp.gmail.com with ESMTPSA id j7sm4745926ige.5.2016.03.13.07.22.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Mar 2016 07:22:39 -0700 (PDT) Received: by kaki.bld.corp.google.com (Postfix, from userid 121222) id 6A7E8220F4F; Sun, 13 Mar 2016 08:22:38 -0600 (MDT) From: Simon Glass To: U-Boot Mailing List Date: Sun, 13 Mar 2016 08:22:33 -0600 Message-Id: <1457878957-22697-2-git-send-email-sjg@chromium.org> X-Mailer: git-send-email 2.7.0.rc3.207.g0ac5344 In-Reply-To: <1457878957-22697-1-git-send-email-sjg@chromium.org> References: <1457878957-22697-1-git-send-email-sjg@chromium.org> Cc: Marek Vasut , Tom Rini , Stephen Warren Subject: [U-Boot] [PATCH v3 1/4] dm: usb: Unbind old block devices when shutting down USB X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" When 'usb start' is used, block devices are created for any USB flash sticks and disks, etc. When 'usb stop' is used, these block devices are currently not removed. We don't want old block devices hanging around since they can still be visible to U-Boot. Therefore, when USB is shut down, remove and unbind all the block devices created by the USB subsystem. Possibly we should unbind all devices which don't cause problems by being unbound. Most likely we can remove everything except USB controllers, hubs and emulators. We can consider that later. Signed-off-by: Simon Glass Tested-by: Stephen Warren --- Changes in v3: - Expand the commit message Changes in v2: None drivers/usb/host/usb-uclass.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host/usb-uclass.c index 50538e0..69c9a50 100644 --- a/drivers/usb/host/usb-uclass.c +++ b/drivers/usb/host/usb-uclass.c @@ -159,7 +159,11 @@ int usb_stop(void) if (ret && !err) err = ret; } - +#ifdef CONFIG_BLK + ret = blk_unbind_all(IF_TYPE_USB); + if (ret && !err) + err = ret; +#endif #ifdef CONFIG_SANDBOX struct udevice *dev;