From patchwork Wed Mar 2 10:32:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Yuan X-Patchwork-Id: 590944 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 21602140326 for ; Wed, 2 Mar 2016 22:14:27 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 949BDA7620; Wed, 2 Mar 2016 12:14:25 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vYttv3Okg94g; Wed, 2 Mar 2016 12:14:24 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C2D85A7610; Wed, 2 Mar 2016 12:14:23 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E8CE0A7610 for ; Wed, 2 Mar 2016 12:14:14 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I5vqxUNHt0Kw for ; Wed, 2 Mar 2016 12:14:14 +0100 (CET) X-Greylist: delayed 1121 seconds by postgrey-1.34 at theia; Wed, 02 Mar 2016 12:14:11 CET X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0111.outbound.protection.outlook.com [157.56.110.111]) by theia.denx.de (Postfix) with ESMTPS id 2E920A74E4 for ; Wed, 2 Mar 2016 12:14:11 +0100 (CET) Received: from DM2PR03CA0002.namprd03.prod.outlook.com (10.141.96.12) by DM2PR0301MB1215.namprd03.prod.outlook.com (10.160.219.16) with Microsoft SMTP Server (TLS) id 15.1.409.15; Wed, 2 Mar 2016 10:41:31 +0000 Received: from BY2FFO11FD050.protection.gbl (2a01:111:f400:7c0c::183) by DM2PR03CA0002.outlook.office365.com (2a01:111:e400:2428::12) with Microsoft SMTP Server (TLS) id 15.1.427.16 via Frontend Transport; Wed, 2 Mar 2016 10:41:31 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=none action=none header.from=freescale.com; Received-SPF: Fail (protection.outlook.com: domain of freescale.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD050.mail.protection.outlook.com (10.1.15.187) with Microsoft SMTP Server (TLS) id 15.1.422.5 via Frontend Transport; Wed, 2 Mar 2016 10:41:31 +0000 Received: from titan.ap.freescale.net ([10.192.208.233]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u22Aepsi009828; Wed, 2 Mar 2016 03:41:28 -0700 From: Yuan Yao To: Date: Wed, 2 Mar 2016 18:32:02 +0800 Message-ID: <1456914723-33160-12-git-send-email-yao.yuan@freescale.com> X-Mailer: git-send-email 2.1.0.27.g96db324 In-Reply-To: <1456914723-33160-1-git-send-email-yao.yuan@freescale.com> References: <1456914723-33160-1-git-send-email-yao.yuan@freescale.com> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CPI:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(1110001)(339900001)(199003)(189002)(189998001)(76176999)(50986999)(33646002)(47776003)(110136002)(105606002)(586003)(81156009)(85426001)(5001960100004)(87936001)(50226001)(106466001)(2351001)(5003940100001)(11100500001)(77096005)(2906002)(48376002)(1220700001)(104016004)(6806005)(5008740100001)(19580405001)(2950100001)(1096002)(86362001)(50466002)(229853001)(36756003)(19580395003)(92566002)(7059030); DIR:OUT; SFP:1102; SCL:1; SRVR:DM2PR0301MB1215; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD050; 1:ScUWEDjxU6kkI/pagUUdwJJytScC3XEsIed/6b+1hisFhGwDZoTkjq5Y8aMCf3tz4kMAubkUUw4XVIcQR8v9WnJkCnqNjLICyueFUY0F3oAeoqvXxEUmVDOj2dNUuy4Tb9znTn9vDh80EyDOSXohW1OLzUc5nf+odke8I2vTcwm9NLxjzflCjlZpQmfSvNO0qgUxqhYePEzt62phL4qrPvicM+UPgYhP0tauAhIOz3MXi4XymSXAyM7WGig+RZ97t0RYFZZw391B7JpP/LSrtAkdkWr52FSiMM4CdayB0j2t7K71cXBp1VOIn8IMfcMC7ZDSPHpZRJFGNYr/FCEbl6BLwOSxACTcCzrKtvZq32Xw6dx1ykyg+Dg9GM8u9jyK4fXt6XnrKFwzFb1cpp9v3m7DhudfvmYOtuoTZWx9z5xwZDHtoU3wCTALW1JNJrt0Eja63nZc6hQ6p6zditbjsg== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8dd20a8d-be0a-4444-9867-08d3428737f0 X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB1215; 2:uegGXO5DgEiQHf5exHD1xsXOmOFr4lj0r/o3U9P/zR94Vcxr1s8VyWLJrRFF/PFaOroZpoPJ0Zv0dVBK0xE4hl0Hx0NbF9V8UzUObktJxpIWtLZ7/sN+BAe+rfy2/XBC5jfSZeL45fWr/2fjcSnnLMn8DP1oGIGVapdkbv/OEY1svdc1cXgjZflAJmGn3GW7; 3:YdIEFyNCq8insO/3NpbBIfGY5Mq57aR7hYmzpwoq1kzlvujZcE1IIhFVcAQt926nMHOSA8oY2GrHe3s771TpkyV9zm0Npr85+OD1ZOpIojpPX1rDx78QavpeV9jo9ujmwr9hqdZdSpJa4rxIzY1OCvfJrFbMu+kKrDgJ/ci0oAqAqUXmN4UPMjwB5SQ+8gN4; 25:KxuIo6xLGXIcRgrM0dhTqus2kkgFHwtRMAjcETvMSMgdYk5bnNVYaxEJiYp/ldOlE0jZOwpSkS0si+uYJCODmqFElZtRipr7R4mfSdH7OuQVH7F/0aia5NkgDT00CYyuCyLTxdrVlgJsJ7dLTIRydPdq0iU8VWJn3xsjLqzpYtw/4E2azaFg9yCCbi8I1f6X9KqA9gNxA1MC1roSVwK4/c7/oK+lZ8paE1KrqfvKxXmqJ0TKE8XCtfdA8/aH7MErCvkJY4/x9FjuudTF5tgbP/m7DVrW6vtjrhEISft+Url3tki9lce6C4PM0rsV9yqhE0LOt0t5Sf9JBS9AF3KKVA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB1215; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB1215; 20:RI+lYr+YFLDkcwV7H+Uy69DTKaFSXkHaUfGPq2fLG8Op/hIFxR/JZFw61DQSV54gJxsGh6ieNhG9W1G6g8pkLCfTEcQZeKD2vrOEm0AJxiZx6nEYlYSQ1361FLy9nqAOeNpXYeH6XtNjiPauifci/UI9jGHscbjkeyISuPzLT1+hlzXv0/ilvaalZMnXyqhtfvKUTraK2Xu1EjbB2zhIY1Z9Grl7VTTfogU8YX2JcJNa9KEnuJj/qAz8KnnfJQjZ2BykSmFe9O96ZPSTr2SYWvntVK4P/WpyfSAYVz2QLDM6STnrjLVpzTPPu96LJWtR9BAYkqpofUs37mNLphARvzVv6lhv/q9I70ozzpHoqRyXirByr+0Fvt8KuIDs58OSS7SmgKUPiVA+TRzYajQSRva30fzwKxoOG/BW5pCzSiM3GmPiwlch6Y3xGLrn6xEP; 4:xrddukbScfx9XeYOwLZi0oM9ojZgJpPztgzZyt/OyvIZuR98meYFKmvEV3em7wkavBpmXAYL1h+gbZeel8wIQTHUgz4V6i+iW9kxCaNjDfiu1tUu1r1fyLi/oSjhfeD4fjOde/UJICs1YopdJN8srrFLGp8BaWFOpLUX80zurKaTRPeBLh8ASBliuhRfy+NSo8PxLsOrFRsDMfQgefnT1kbkg96NRiXwYG+ddNkQHVrod55Bw70/c4da2x7YMlY+6678la0stC2UVMnjgvT+vzHOquyNKIPuoFNtk/2hBe47Blx3h/8XBWxQtoXD9xIYgTsQXbl8tHrNtw2vP907Df4fHpFIwFE9i1PUcUfX84YP/xqKMg8aL64VzT2TF0LVdPHbdZzMErsmBE64dReW5W0wAMmCfjGBwCeOYxO5lUPy0hK/7rW8CKsQoMuwjRJMoQuIfT4Jc1ydXKuMHP+eQg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13015025)(13023025)(13018025)(5005006)(13017025)(8121501046)(13024025)(3002001)(10201501046); SRVR:DM2PR0301MB1215; BCL:0; PCL:0; RULEID:; SRVR:DM2PR0301MB1215; X-Forefront-PRVS: 086943A159 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR0301MB1215; 23:ijYtjzfUP3wo3E/aiEy2QRmivJe3qhKHPNJdKTM?= =?us-ascii?Q?S8loCJhwXHDvfy8jiitqq0auKfvWLvLK6PGDyyeziE9L2YrLVAL4KLhA0bHW?= =?us-ascii?Q?F+oG8HWSYHKoH3Y/rmd3X5yOZ4XDU7xhh2ciT08yPzTEzJevmV80XB/ndw9/?= =?us-ascii?Q?7wGBk67HWIm1gAPG8/I75Uz5WOtNyFP6FeN7zPn7r8HC94Pw0ZAaZL990YE5?= =?us-ascii?Q?teCvHima12mSsql4BabSHqcNz7B9E6FtcVZ/FjHyVO7QcUf8h0HfR64ELZnx?= =?us-ascii?Q?lnwsUA+69SHA/SnJSJwtW5LXMV955kB/PJAR9RxL/UBQ/lt5k34wSMHyD5wH?= =?us-ascii?Q?hb2+cUfDdjEtnV66EBtkX/qOKvicqA1nnFyUOVc1ILdPy8pgwnAbLfFbxwwn?= =?us-ascii?Q?dfd/erful3yOj38Y8us4iTkuMrnWmxV6tjVJuj8BBi6GKVY+3ZXm5Z3Ci5CI?= =?us-ascii?Q?4U2KJzKbWGsg/h4o2Oj1oqzrglF52oxbYoSdWMqVOy2Bza75+eUOQ8WJl8+c?= =?us-ascii?Q?RO8O1stdAxFA7cNYx92Dr7a7F90EXjH1gj+f2o4fNbtk6CoQgePxLL7F/Qmh?= =?us-ascii?Q?o0oJzK8ipL3Mdqtrc+Yq2a13AoWaHzqPaHKD3K7+/foHTA1QuOUzv2UkMpQE?= =?us-ascii?Q?gAbeXPTgzl1MZpGpB0HHL5qMh6vj1LQ5KMFBygJBMonA3qaeYP8bnRAQBBWh?= =?us-ascii?Q?nU8G/cSqQROnmL0Dw2FwJgur387DKbw+XELiyXUi+VhFcd0/Wj5PUjVLXCSs?= =?us-ascii?Q?UCyvWeAA6FDbtIoL8EEK4qVLdrhIq7jXsfxCCAj4WUDX3yu7tmEkHwsUQoOC?= =?us-ascii?Q?XWf2seQ4f/Ogw7bS4PdEjBFh/BMib9S/030jQ2VPC2uQajqHIlp8phTvxG09?= =?us-ascii?Q?FkL6xxzX4Se2wqZqpA6sNnKNYS2hG2mAjKgXtFcaHhpDNHOklKkZ2sbsCvtl?= =?us-ascii?Q?HXus4p8jjLmqjqz3Qn0G8ys7mI/bHSqVjAmaowl4yUkF2SNK78RCyUf0ybaj?= =?us-ascii?Q?ra4CQJigDQ/E8iMWsK+7Ql8mEHcX5ah0aYlb0SNucg1FB2cPeTDQwXFMjCkg?= =?us-ascii?Q?xspXhA1Q=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB1215; 5:Ljq81Qm7Z169cJN826nTryPCTVTIg+IbNsKjGf2M1TI56s3wjvscqQIQuzBUQAXAYb2CpFTWRvs89sW7EdGLMN0TaMo4QMvvj6vSuvptvXDLVamWQsHDvrbrAUA6Dg9F5UMFzQpuKJ7s8wx/T+dDvQ==; 24:7GChapwBdSIK18/ltHIKYRBZMJQ7Zq2xOIK1VInw/UlfsXNI2azlrcO6IWwmDegzOjgxz8/+tQZSzTAEypxCnprzO4JiB8OfEAo+ziYXL5E= X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2016 10:41:31.4032 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB1215 Cc: yunhui.cui@nxp.com, u-boot@lists.denx.de Subject: [U-Boot] [PATCH 11/12] freescale: cmd: qixis: tidy up the duplicated code X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Yuan Yao Signed-off-by: Yuan Yao --- board/freescale/common/qixis.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/board/freescale/common/qixis.c b/board/freescale/common/qixis.c index 113295f..de9daeb 100644 --- a/board/freescale/common/qixis.c +++ b/board/freescale/common/qixis.c @@ -211,8 +211,7 @@ int qixis_reset_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) QIXIS_WRITE(rcfg_ctl, 0); set_lbmap(QIXIS_LBMAP_NAND); set_rcw_src(QIXIS_RCW_SRC_NAND); - QIXIS_WRITE(rcfg_ctl, 0x20); - QIXIS_WRITE(rcfg_ctl, 0x21); + qixis_bank_reset(); #else printf("Not implemented\n"); #endif @@ -222,8 +221,7 @@ int qixis_reset_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) QIXIS_WRITE(rcfg_ctl, 0); set_lbmap(QIXIS_LBMAP_SD); set_rcw_src(QIXIS_RCW_SRC_SD); - QIXIS_WRITE(rcfg_ctl, 0x20); - QIXIS_WRITE(rcfg_ctl, 0x21); + qixis_bank_reset(); #else printf("Not implemented\n"); #endif @@ -233,8 +231,7 @@ int qixis_reset_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) QIXIS_WRITE(rcfg_ctl, 0); set_lbmap(QIXIS_LBMAP_SD_QSPI); set_rcw_src(QIXIS_RCW_SRC_SD); - qixis_write_i2c(offsetof(struct qixis, rcfg_ctl), 0x20); - qixis_write_i2c(offsetof(struct qixis, rcfg_ctl), 0x21); + qixis_bank_reset(); #else printf("Not implemented\n"); #endif @@ -244,8 +241,7 @@ int qixis_reset_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) QIXIS_WRITE(rcfg_ctl, 0); set_lbmap(QIXIS_LBMAP_QSPI); set_rcw_src(QIXIS_RCW_SRC_QSPI); - qixis_write_i2c(offsetof(struct qixis, rcfg_ctl), 0x20); - qixis_write_i2c(offsetof(struct qixis, rcfg_ctl), 0x21); + qixis_bank_reset(); #else printf("Not implemented\n"); #endif