From patchwork Tue Feb 16 06:54:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Chou X-Patchwork-Id: 583191 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 390AD1402CD for ; Tue, 16 Feb 2016 17:54:24 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 642FEA7530; Tue, 16 Feb 2016 07:54:20 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h-eGdFUzAU2Y; Tue, 16 Feb 2016 07:54:19 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9AB4AA7526; Tue, 16 Feb 2016 07:54:19 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B6231A7526 for ; Tue, 16 Feb 2016 07:54:16 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WQuCm0WXIVIv for ; Tue, 16 Feb 2016 07:54:16 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from www.wytron.com.tw (220-134-43-68.HINET-IP.hinet.net [220.134.43.68]) by theia.denx.de (Postfix) with ESMTP id 36C8BA74C3 for ; Tue, 16 Feb 2016 07:54:13 +0100 (CET) Received: from localhost.localdomain (unknown [192.168.1.250]) by www.wytron.com.tw (Postfix) with ESMTP id E724ED0029D; Tue, 16 Feb 2016 14:54:10 +0800 (CST) From: Thomas Chou To: Joe Hershberger Date: Tue, 16 Feb 2016 14:54:07 +0800 Message-Id: <1455605647-3849-1-git-send-email-thomas@wytron.com.tw> X-Mailer: git-send-email 2.5.0 Cc: Marek Vasut , clsee@altera.com, u-boot@lists.denx.de, lftan@altera.com Subject: [U-Boot] [PATCH] net: fix m88e1111s PHY auto negotiation timeout X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" After commit a058052c358c ("net: phy: do not read configuration register on reset") both 3c120 and 10m50 devboard which use Marvel m88e1111s PHY got this error message, Net: eth0: ethernet@400 => ping 192.168.1.5 ethernet@400 Waiting for PHY auto negotiation to complete.... TIMEOUT ! Using ethernet@400 device host 192.168.1.5 is alive This is because the auto negotiation control bit was cleared by the new phy_reset(). But the m88e1111s_config() does the soft-reset already, there is no need to reset twice. The extra phy_reset() should be removed. Signed-off-by: Thomas Chou --- drivers/net/phy/marvell.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index eab1558..5badfac 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -271,8 +271,6 @@ static int m88e1111s_config(struct phy_device *phydev) genphy_config_aneg(phydev); - phy_reset(phydev); - return 0; }