| Message ID | 1453938669-7273-2-git-send-email-marex@denx.de |
|---|---|
| State | RFC |
| Delegated to: | Daniel Schwierzeck |
| Headers | show |
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote: > Drop SYS_MIPS_CACHE_INIT_RAM_LOAD from the Kconfig, since this option > is bogus. The DRAM is not active when this option comes into play, so > any attempt to restore valid cache state from invalid DRAM must fail. > Disable this option to prevent such failure and potential undefined > behavior. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> > Cc: Wills Wang <wills.wang@live.com> > --- > arch/mips/mach-ath79/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig > index f61efd2..95f7de9 100644 > --- a/arch/mips/mach-ath79/Kconfig > +++ b/arch/mips/mach-ath79/Kconfig > @@ -12,7 +12,6 @@ config SOC_AR933X > select SUPPORTS_BIG_ENDIAN > select SUPPORTS_CPU_MIPS32_R1 > select SUPPORTS_CPU_MIPS32_R2 > - select SYS_MIPS_CACHE_INIT_RAM_LOAD > select MIPS_TUNE_24KC > help > This supports QCA/Atheros ar933x family SOCs. > @@ -22,7 +21,6 @@ config SOC_QCA953X > select SUPPORTS_BIG_ENDIAN > select SUPPORTS_CPU_MIPS32_R1 > select SUPPORTS_CPU_MIPS32_R2 > - select SYS_MIPS_CACHE_INIT_RAM_LOAD > select MIPS_TUNE_24KC > help > This supports QCA/Atheros qca953x family SOCs. I will remove this option in the coming v8.
On Thursday, January 28, 2016 at 02:25:08 PM, Wills Wang wrote: > On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote: > > Drop SYS_MIPS_CACHE_INIT_RAM_LOAD from the Kconfig, since this option > > is bogus. The DRAM is not active when this option comes into play, so > > any attempt to restore valid cache state from invalid DRAM must fail. > > Disable this option to prevent such failure and potential undefined > > behavior. > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> > > Cc: Wills Wang <wills.wang@live.com> > > --- > > > > arch/mips/mach-ath79/Kconfig | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig > > index f61efd2..95f7de9 100644 > > --- a/arch/mips/mach-ath79/Kconfig > > +++ b/arch/mips/mach-ath79/Kconfig > > @@ -12,7 +12,6 @@ config SOC_AR933X > > > > select SUPPORTS_BIG_ENDIAN > > select SUPPORTS_CPU_MIPS32_R1 > > select SUPPORTS_CPU_MIPS32_R2 > > > > - select SYS_MIPS_CACHE_INIT_RAM_LOAD > > > > select MIPS_TUNE_24KC > > help > > > > This supports QCA/Atheros ar933x family SOCs. > > > > @@ -22,7 +21,6 @@ config SOC_QCA953X > > > > select SUPPORTS_BIG_ENDIAN > > select SUPPORTS_CPU_MIPS32_R1 > > select SUPPORTS_CPU_MIPS32_R2 > > > > - select SYS_MIPS_CACHE_INIT_RAM_LOAD > > > > select MIPS_TUNE_24KC > > help > > > > This supports QCA/Atheros qca953x family SOCs. > > I will remove this option in the coming v8. Fine Best regards, Marek Vasut
diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index f61efd2..95f7de9 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -12,7 +12,6 @@ config SOC_AR933X select SUPPORTS_BIG_ENDIAN select SUPPORTS_CPU_MIPS32_R1 select SUPPORTS_CPU_MIPS32_R2 - select SYS_MIPS_CACHE_INIT_RAM_LOAD select MIPS_TUNE_24KC help This supports QCA/Atheros ar933x family SOCs. @@ -22,7 +21,6 @@ config SOC_QCA953X select SUPPORTS_BIG_ENDIAN select SUPPORTS_CPU_MIPS32_R1 select SUPPORTS_CPU_MIPS32_R2 - select SYS_MIPS_CACHE_INIT_RAM_LOAD select MIPS_TUNE_24KC help This supports QCA/Atheros qca953x family SOCs.
Drop SYS_MIPS_CACHE_INIT_RAM_LOAD from the Kconfig, since this option is bogus. The DRAM is not active when this option comes into play, so any attempt to restore valid cache state from invalid DRAM must fail. Disable this option to prevent such failure and potential undefined behavior. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> Cc: Wills Wang <wills.wang@live.com> --- arch/mips/mach-ath79/Kconfig | 2 -- 1 file changed, 2 deletions(-)