From patchwork Tue Jan 19 03:39:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 569777 X-Patchwork-Delegate: bmeng.cn@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 74C4B1402EC for ; Tue, 19 Jan 2016 14:40:31 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b=CJLqPJSO; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6C8FE4BE98; Tue, 19 Jan 2016 04:39:59 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IQ2fsnWZMMCh; Tue, 19 Jan 2016 04:39:59 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 401194BE9B; Tue, 19 Jan 2016 04:39:36 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 636504BDC7 for ; Tue, 19 Jan 2016 04:39:23 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ix4oGmeRw0oj for ; Tue, 19 Jan 2016 04:39:23 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-oi0-f54.google.com (mail-oi0-f54.google.com [209.85.218.54]) by theia.denx.de (Postfix) with ESMTPS id 0AB1A4BDC4 for ; Tue, 19 Jan 2016 04:39:18 +0100 (CET) Received: by mail-oi0-f54.google.com with SMTP id w75so154504539oie.0 for ; Mon, 18 Jan 2016 19:39:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=lZ/O84Sf9PS2Y1cDiKM0Z/BxfcPjZp2Y4v7FI9Rt51k=; b=CJLqPJSOj8HT3ZAgyBVVvMK6ZaZgpvdBN+90URUSYkLGh51BIfpL+xpcIIAzKUnQb0 qhaRmwVnnfbxTWbfkJwBn5eTiyGoWOjwGaGmjsXj3kDUTpcMARmjn4spsotMzl68NM04 vITRTlEs72kKV2IbU7Csx/4qX54+mxOYKZ7lEwhTiQH8qmpqKJlhzMK0fLs3NxWshp32 CDh9/VRgRTLkyqxGlhmsRSQwqmXbQMQxMdEWH5S/mbZ8/iHa9LwWhrFEV5tvyoVrILQh QM9Hs5+zsV5/vHnfj1USffyj1kKTuBD+voV1IPoUhrZ0FSsJ6cW97baqOrKSyjkqd/5y gJ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=lZ/O84Sf9PS2Y1cDiKM0Z/BxfcPjZp2Y4v7FI9Rt51k=; b=CIxabKLKkAL7S+ZYfYPy2Tsd1vaC/zBSsw1WUH/0Nb9NrFqNzwTI1ztcFIbG5Iq2Gj 379UfvXHT4edTEvK6PRyP7/oNyb1/lwceEmeo4Bg7F00c46Zgu/djwluLrIaqBmcPBtl exoqMzp5esQs8OW/9qJLxRzy94+OyvWUHm25dKbbg/tdCKAX6mX3uls4O0l/Xo16kVq8 uAZ0GZMSWykeWrWAE1YAnPMUzDEK+Os5rKyyuHNhmlpR/+w8skY/K4GC5IRhZ6Wxmvni YNJrUzzQCeDPvIz8zlpxOblmOMHJ2gqgRuUvHsF8JYBHbDsqnDZX49LcBWiA9gGJJhgK 2Oaw== X-Gm-Message-State: ALoCoQnXr+YAFiGOMkx8d1XGs2Bsk6YJosRD0QxMMLGyIVFfIXI0GrDIfLF9b0zJmVuUINo5V7kjmrPoC0EitWPdxWAg6UtJCg== X-Received: by 10.202.204.136 with SMTP id c130mr21291742oig.93.1453174757664; Mon, 18 Jan 2016 19:39:17 -0800 (PST) Received: from kaki.bld.corp.google.com ([172.29.216.32]) by smtp.gmail.com with ESMTPSA id l134sm14604527oib.22.2016.01.18.19.39.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jan 2016 19:39:16 -0800 (PST) Received: by kaki.bld.corp.google.com (Postfix, from userid 121222) id B709B22247C; Mon, 18 Jan 2016 20:39:13 -0700 (MST) From: Simon Glass To: U-Boot Mailing List Date: Mon, 18 Jan 2016 20:39:12 -0700 Message-Id: <1453174752-26448-7-git-send-email-sjg@chromium.org> X-Mailer: git-send-email 2.6.0.rc2.230.g3dd15c0 In-Reply-To: <1453174752-26448-1-git-send-email-sjg@chromium.org> References: <1453174752-26448-1-git-send-email-sjg@chromium.org> Subject: [U-Boot] [PATCH v2 6/6] dm: x86: Drop the weak cpu_irq_init() function X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" There are no callers now. Platforms which need to set up interrupts their own way can implement an interrupt driver. Drop this function. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: - Rebase on top of updated SPI flash series arch/x86/cpu/irq.c | 7 ------- arch/x86/include/asm/irq.h | 10 ---------- 2 files changed, 17 deletions(-) diff --git a/arch/x86/cpu/irq.c b/arch/x86/cpu/irq.c index e2feba7..324866c 100644 --- a/arch/x86/cpu/irq.c +++ b/arch/x86/cpu/irq.c @@ -83,11 +83,6 @@ static inline void fill_irq_info(struct irq_info *slot, int bus, int device, slot->irq[pin - 1].bitmap = irq_router.irq_mask; } -__weak void cpu_irq_init(void) -{ - return; -} - static int create_pirq_routing_table(void) { const void *blob = gd->fdt_blob; @@ -235,8 +230,6 @@ int irq_router_common_init(struct udevice *dev) { int ret; - cpu_irq_init(); - ret = create_pirq_routing_table(); if (ret) { debug("Failed to create pirq routing table\n"); diff --git a/arch/x86/include/asm/irq.h b/arch/x86/include/asm/irq.h index 46e1c31..5b9e673 100644 --- a/arch/x86/include/asm/irq.h +++ b/arch/x86/include/asm/irq.h @@ -56,16 +56,6 @@ struct pirq_routing { #define PIRQ_BITMAP 0xdef8 /** - * cpu_irq_init() - Initialize CPU IRQ routing - * - * This initializes some platform-specific registers related to IRQ routing, - * like configuring internal PCI devices to use which PCI interrupt pin, - * and which PCI interrupt pin is mapped to which PIRQ line. Note on some - * platforms, such IRQ routing might be hard-coded thus cannot configure. - */ -void cpu_irq_init(void); - -/** * irq_router_common_init() - Perform common x86 interrupt init * * This creates the PIRQ routing table and routes the IRQs