From patchwork Thu Jan 14 03:39:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 567248 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id A4F1A1402A1 for ; Thu, 14 Jan 2016 14:42:32 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=AfYiVWtE; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 048EA622E8; Thu, 14 Jan 2016 04:42:31 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HXYf8FChVKnx; Thu, 14 Jan 2016 04:42:30 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 53E60622EE; Thu, 14 Jan 2016 04:40:48 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1780C621FB for ; Thu, 14 Jan 2016 04:36:33 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9EMJexrWkDPX for ; Thu, 14 Jan 2016 04:36:33 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by theia.denx.de (Postfix) with ESMTPS id 67A0162250 for ; Thu, 14 Jan 2016 04:36:22 +0100 (CET) Received: by mail-pa0-f42.google.com with SMTP id ho8so108458833pac.2 for ; Wed, 13 Jan 2016 19:36:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=+rAWMyDAj9veuTBtCRpKWz50j9cyXSIXdoY0IbothKU=; b=AfYiVWtEW8gzLKEAr84rFM1gAo+gwcDzH2CtxGV3Bvkt5HkGRbNOzpO0f4GFRDpykf FTxdvwEENQPlX1ZdJ3yh5/iU4qWwmUwDkroKv24gdgrxs9/obemK8FAexsFVfK+eTL65 3lUtTWzmRjHpZBkC1whoRK14n/hNRb43Yrjv0/p2UP6RpT9LZNXdoqWKiBkDj0o/xnJN vwjLaOe1SrqD6JYRVThje3JhCcdRPYY2PU+Wt/ClgCQX4jUjsIg0B1qpMPT6mUm47gSG l5cfuAv8wmWykZ7J75ikDwJ9272/rgzJmFbOsQIIDyEWeEWW9JprmFw70artTnrqZTMv /aGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=+rAWMyDAj9veuTBtCRpKWz50j9cyXSIXdoY0IbothKU=; b=NWeE2zBV6ScjHctcr5/uGRBi/smCJPE25V6ewzUbvgFuKtfqVesn7JrKIitSC4k2jA /ObAoeOXsO63tq6Dm8FIHjBrhHiY9fwxbveruotQor4YgIIREnWvHTjkQ+DlRSHs24Er AO96nfON4Ogx4AnAakgM3VAzK3/jc/ka1kD5UnZgaqkzgD2okLfY8Fr6FpLh+ydrOQqa 9Ks1X6hqPySsgVzhcwYDKkMO62ZzBy/919nALcKW7aZiY6KAmWai8qX3ag8XaDYHazi+ mi1C8MztKuud8C3kgVUIXxw9vyWg9wfXrBgU/VuLRbBYph39xMTTz3jt37z3+FpYfaii UcGA== X-Gm-Message-State: ALoCoQkjHxv7tmey3UmNTqoYLLDbaP95Nq9050mzzCx8Ws1mPpD3Y4wJQR10HJiyyC1xzLiCd4Qx5rbzkTfWFq4Nwbw9GoDX2g== X-Received: by 10.66.97.5 with SMTP id dw5mr2607990pab.27.1452742580544; Wed, 13 Jan 2016 19:36:20 -0800 (PST) Received: from ala-d2121-lx1.wrs.com (unknown-157-139.windriver.com. [147.11.157.139]) by smtp.gmail.com with ESMTPSA id xv2sm5636171pab.10.2016.01.13.19.36.19 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 Jan 2016 19:36:20 -0800 (PST) From: Bin Meng To: Simon Glass , Stefan Agner , Bhuvanchandra DV , "Albert ARIBAUD (3ADEV)" , York Sun , Alison Wang , U-Boot Mailing List Date: Wed, 13 Jan 2016 19:39:02 -0800 Message-Id: <1452742746-31746-6-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1452742746-31746-1-git-send-email-bmeng.cn@gmail.com> References: <1452742746-31746-1-git-send-email-bmeng.cn@gmail.com> Subject: [U-Boot] [PATCH v2 5/9] serial: lpuart: Call local version of setbrg and putc directly X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" There is no need to go through serial driver subsystem, instead call the driver's setbrg and putc routines directly. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Acked-by: Simon Glass --- Changes in v2: None drivers/serial/serial_lpuart.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/serial/serial_lpuart.c b/drivers/serial/serial_lpuart.c index ae47183..0c0ab87 100644 --- a/drivers/serial/serial_lpuart.c +++ b/drivers/serial/serial_lpuart.c @@ -78,7 +78,7 @@ static int lpuart_serial_getc(void) static void lpuart_serial_putc(const char c) { if (c == '\n') - serial_putc('\r'); + lpuart_serial_putc('\r'); while (!(__raw_readb(&base->us1) & US1_TDRE)) WATCHDOG_RESET(); @@ -118,7 +118,7 @@ static int lpuart_serial_init(void) __raw_writeb(CFIFO_TXFLUSH | CFIFO_RXFLUSH, &base->ucfifo); /* provide data bits, parity, stop bit, etc */ - serial_setbrg(); + lpuart_serial_setbrg(); __raw_writeb(UC2_RE | UC2_TE, &base->uc2); @@ -165,7 +165,7 @@ static int lpuart32_serial_getc(void) static void lpuart32_serial_putc(const char c) { if (c == '\n') - serial_putc('\r'); + lpuart32_serial_putc('\r'); while (!(in_be32(&base->stat) & STAT_TDRE)) WATCHDOG_RESET(); @@ -201,7 +201,7 @@ static int lpuart32_serial_init(void) out_be32(&base->match, 0); /* provide data bits, parity, stop bit, etc */ - serial_setbrg(); + lpuart32_serial_setbrg(); out_be32(&base->ctrl, CTRL_RE | CTRL_TE);