From patchwork Wed Jan 13 23:25:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 567181 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 8FE431402C4 for ; Thu, 14 Jan 2016 10:37:52 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b=P8W9r9j1; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 888D562212; Thu, 14 Jan 2016 00:37:49 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VVDWMRhQUfO9; Thu, 14 Jan 2016 00:37:42 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 785B96220F; Thu, 14 Jan 2016 00:36:55 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id ABC3362203 for ; Thu, 14 Jan 2016 00:36:19 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tm-D65Ta-OZG for ; Thu, 14 Jan 2016 00:36:19 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-oi0-f51.google.com (mail-oi0-f51.google.com [209.85.218.51]) by theia.denx.de (Postfix) with ESMTPS id 14A1E62202 for ; Thu, 14 Jan 2016 00:33:21 +0100 (CET) Received: by mail-oi0-f51.google.com with SMTP id w75so73248284oie.0 for ; Wed, 13 Jan 2016 15:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=NXf4susvip3j0cdDu7bDAS+IEQ0rZNy0L/6242S0vCo=; b=P8W9r9j1DiCPXh51LPZaChoSh8Y8RT+NuZ9dn4OU/+rS74aJb7uM1lCgr58zIuRtYv dVhrGDRgO9pmeVPLxujdKHEPydCq/RFs6RMiq8qcs0Cp6nQYW2X63ffeaVKMVd/FLBFl EjDWa+fC0IZ7+KSqZefsVx5TPILV87PCpF/LLsKbRT4esIa1Pn7geW/Ju6gm4/eKMW2E HJh+eDYC/KPVk6vxdVs1aP6mW9c8eM/CkOeiMmoTWqivsAZyt/eCQ6MGp3Ws3FvBBP96 pDfdOTvQpaIDPyKmrZ4xqpiQ+93XwkTOybjTHwUcUmLFwzSb4aTP0hXOiAO4ll2aDZV8 THYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=NXf4susvip3j0cdDu7bDAS+IEQ0rZNy0L/6242S0vCo=; b=MULVhPOVDCgzSCpxA3lMSRGF75qcDSVp1TJ7QC6KBXGbK5AJu9C4jb+H3GOgm60OHk hpGEi+WNP66/dUJX25XgTT1Xqb0WjjROlZCrpMNkB0S93U1yqkC82GCTDoArjqljYSEU o8KjS61hZPQhB6PBF5PuSfmeU2I0eIPwB0V2YFTJNgXK5L/GeCnb3CyPD9bu9VI3jmPt P4RcqyRliuYR5JvQwXr2ICw2YWvZbWe7buQelUUcHnWEx5e/XPSfnzeYU0gMxOs1ooIs 78iUW3j/Uyg87cEdRThuA07Zm3F2LlbtadEgHFBfRdMS+oF55HjdlZFIsWPMOoxkkz1q U3JA== X-Gm-Message-State: ALoCoQnjyPXf6tPPvEbTDjrGVwg7CZEsQ2WOVdSN0TQaWZsEtXGj/s/syBtqU9lp6NioI3UT4Qk1f7J2Fr9pI8jYxvv6CFjOgg== X-Received: by 10.202.94.67 with SMTP id s64mr687505oib.65.1452728000455; Wed, 13 Jan 2016 15:33:20 -0800 (PST) Received: from kaki.bld.corp.google.com ([172.29.216.32]) by smtp.gmail.com with ESMTPSA id i8sm1898317obt.3.2016.01.13.15.33.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jan 2016 15:33:19 -0800 (PST) Received: by kaki.bld.corp.google.com (Postfix, from userid 121222) id CDDA2222403; Wed, 13 Jan 2016 16:26:26 -0700 (MST) From: Simon Glass To: U-Boot Mailing List Date: Wed, 13 Jan 2016 16:25:38 -0700 Message-Id: <1452727540-3249-49-git-send-email-sjg@chromium.org> X-Mailer: git-send-email 2.6.0.rc2.230.g3dd15c0 In-Reply-To: <1452727540-3249-1-git-send-email-sjg@chromium.org> References: <1452727540-3249-1-git-send-email-sjg@chromium.org> Cc: Jeffy Chen , Jagan Teki Subject: [U-Boot] [PATCH 48/50] rockchip: spi: Correct chip-enable code X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" At present there is an incorrect call to rkspi_enable_chip(). It should be disabling the chip, not enabling it. Correct this and ensure that the chip is disabled when releasing the bus. Signed-off-by: Simon Glass --- drivers/spi/rk_spi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/spi/rk_spi.c b/drivers/spi/rk_spi.c index 91538b4..ecda833 100644 --- a/drivers/spi/rk_spi.c +++ b/drivers/spi/rk_spi.c @@ -285,6 +285,11 @@ static int rockchip_spi_claim_bus(struct udevice *dev) static int rockchip_spi_release_bus(struct udevice *dev) { + struct udevice *bus = dev->parent; + struct rockchip_spi_priv *priv = dev_get_priv(bus); + + rkspi_enable_chip(priv->regs, false); + return 0; } @@ -313,7 +318,7 @@ static int rockchip_spi_xfer(struct udevice *dev, unsigned int bitlen, while (len > 0) { int todo = min(len, 0xffff); - rkspi_enable_chip(regs, true); + rkspi_enable_chip(regs, false); writel(todo - 1, ®s->ctrlr1); rkspi_enable_chip(regs, true);