From patchwork Mon Dec 21 09:04:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miao Yan X-Patchwork-Id: 559462 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 338CA1409C3 for ; Mon, 21 Dec 2015 20:04:30 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=OaPcvPtN; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A6EED4B71E; Mon, 21 Dec 2015 10:04:26 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PWWe9oixROnO; Mon, 21 Dec 2015 10:04:26 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2FAF24B67F; Mon, 21 Dec 2015 10:04:25 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 8C9D94B67F for ; Mon, 21 Dec 2015 10:04:22 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id joq1jmPkxlix for ; Mon, 21 Dec 2015 10:04:22 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by theia.denx.de (Postfix) with ESMTPS id 10F854B67D for ; Mon, 21 Dec 2015 10:04:18 +0100 (CET) Received: by mail-pa0-f54.google.com with SMTP id wq6so96617299pac.1 for ; Mon, 21 Dec 2015 01:04:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=YHNU8qBp7RCCUus0tOX8j/l+juTSfk3Ely1kk7JBKqs=; b=OaPcvPtNTsbC1HgEDzraf7F4q8sjO9QWJHU/O7DoiiSya6v6BKPIPTwA4vzKH52blH 2vNIb94P4JaxXMsx/gqA3fliygj7QJLaGKOEP7jC37jxn3wwUFNVgq8W32lxb+uaEciZ 934cPZJ5Nqn2UJ0tJjM0SNFzuP74Me81wzogVY5fOCr+RR7OwNIch1/d7pQ9vomwI7cw L7rkQ0tgftylqDsgkAQ0glfAfJdimVIHTXEsVO8r/xDH+wJ8AuIqJ2RRWq0B4IBgLblV QgBWDtdZajVB92WRY05a6a0T9rbF9bneMDcxiycMt5P7zFaG8BmMbeGKHAf5r0PqRwyf ZCYA== X-Received: by 10.66.254.100 with SMTP id ah4mr13039770pad.121.1450688656586; Mon, 21 Dec 2015 01:04:16 -0800 (PST) Received: from pa-dbc1131.eng.vmware.com ([208.91.1.34]) by smtp.gmail.com with ESMTPSA id d86sm33115227pfj.85.2015.12.21.01.04.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Dec 2015 01:04:15 -0800 (PST) From: Miao Yan To: u-boot@lists.denx.de, trini@konsulko.com Date: Mon, 21 Dec 2015 01:04:08 -0800 Message-Id: <1450688648-52033-1-git-send-email-yanmiaobest@gmail.com> X-Mailer: git-send-email 2.6.3.444.gfd13a2e Subject: [U-Boot] [PATCH] net: e1000: use correct hepler to do endianess conversion X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" In struct e1000_rx_desc, field 'length' is declared as uint16_t, so use le16_to_cpu() to do endianess conversion. Also drop conversion on 'status' which is declared as uint8_t. Signed-off-by: Miao Yan Reviewed-by: Bin Meng --- drivers/net/e1000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c index 2ba03ed..6124bf0 100644 --- a/drivers/net/e1000.c +++ b/drivers/net/e1000.c @@ -5165,11 +5165,11 @@ _e1000_poll(struct e1000_hw *hw) inval_end = inval_start + roundup(sizeof(*rd), ARCH_DMA_MINALIGN); invalidate_dcache_range(inval_start, inval_end); - if (!(le32_to_cpu(rd->status)) & E1000_RXD_STAT_DD) + if (!(rd->status & E1000_RXD_STAT_DD)) return 0; /* DEBUGOUT("recv: packet len=%d\n", rd->length); */ /* Packet received, make sure the data are re-loaded from RAM. */ - len = le32_to_cpu(rd->length); + len = le16_to_cpu(rd->length); invalidate_dcache_range((unsigned long)packet, (unsigned long)packet + roundup(len, ARCH_DMA_MINALIGN));