diff mbox

[U-Boot,v2,7/9] x86: queensbay: Remove invalid comments in update_fsp_configs()

Message ID 1449813784-23365-8-git-send-email-bmeng.cn@gmail.com
State Accepted
Commit e293502280b772c0ba29f1ca2d504680b4220d83
Delegated to: Bin Meng
Headers show

Commit Message

Bin Meng Dec. 11, 2015, 6:03 a.m. UTC 
Those comments in update_fsp_configs() are not correct. Remove them.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Simon Glass <sjg@chromium.org>

---

Changes in v2: None

 arch/x86/cpu/queensbay/fsp_configs.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Simon Glass Dec. 19, 2015, 2:51 a.m. UTC | #1 
On 10 December 2015 at 23:03, Bin Meng <bmeng.cn@gmail.com> wrote:
> Those comments in update_fsp_configs() are not correct. Remove them.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> ---
>
> Changes in v2: None
>
>  arch/x86/cpu/queensbay/fsp_configs.c | 6 ------
>  1 file changed, 6 deletions(-)

Tested on Minnowmax:
Tested-by: Simon Glass <sjg@chromium.org>
Bin Meng Dec. 21, 2015, 7:44 a.m. UTC | #2 
On Sat, Dec 19, 2015 at 10:51 AM, Simon Glass <sjg@chromium.org> wrote:
> On 10 December 2015 at 23:03, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Those comments in update_fsp_configs() are not correct. Remove them.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> Acked-by: Simon Glass <sjg@chromium.org>
>>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/x86/cpu/queensbay/fsp_configs.c | 6 ------
>>  1 file changed, 6 deletions(-)
>
> Tested on Minnowmax:
> Tested-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86/next, thanks!
diff mbox

Patch

diff --git a/arch/x86/cpu/queensbay/fsp_configs.c b/arch/x86/cpu/queensbay/fsp_configs.c
index f84ae30..25a92f7 100644
--- a/arch/x86/cpu/queensbay/fsp_configs.c
+++ b/arch/x86/cpu/queensbay/fsp_configs.c
@@ -11,10 +11,4 @@ 
 void update_fsp_configs(struct fsp_config_data *config)
 {
 	/* Override any UPD setting if required */
-
-	/* Uncomment the line below to enable DEBUG message */
-	/* fsp_upd->serial_dbgport_type = 1; */
-
-	/* Examples on how to initialize the pointers in UPD region */
-	/* fsp_upd->pcd_example = (EXAMPLE_DATA *)&example; */
 }