From patchwork Tue Dec 8 08:24:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aneesh Bansal X-Patchwork-Id: 553822 X-Patchwork-Delegate: yorksun@freescale.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id CEDF11402A9 for ; Tue, 8 Dec 2015 19:26:40 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 44FB84B712; Tue, 8 Dec 2015 09:26:28 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ERNjXLoNJ3Pq; Tue, 8 Dec 2015 09:26:28 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0509D4B800; Tue, 8 Dec 2015 09:26:18 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 384B74B7BA for ; Tue, 8 Dec 2015 09:26:11 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yN5_IEGpZ-Ge for ; Tue, 8 Dec 2015 09:26:11 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0118.outbound.protection.outlook.com [207.46.100.118]) by theia.denx.de (Postfix) with ESMTPS id 8CEEF4B7E7 for ; Tue, 8 Dec 2015 09:26:02 +0100 (CET) Received: from BY2PR03CA074.namprd03.prod.outlook.com (10.141.249.47) by BN1PR0301MB0660.namprd03.prod.outlook.com (10.160.171.21) with Microsoft SMTP Server (TLS) id 15.1.337.19; Tue, 8 Dec 2015 08:25:59 +0000 Received: from BY2FFO11OLC005.protection.gbl (2a01:111:f400:7c0c::104) by BY2PR03CA074.outlook.office365.com (2a01:111:e400:2c5d::47) with Microsoft SMTP Server (TLS) id 15.1.337.19 via Frontend Transport; Tue, 8 Dec 2015 08:25:58 +0000 Authentication-Results: spf=permerror (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; Received-SPF: PermError (protection.outlook.com: domain of freescale.com used an invalid SPF mechanism) Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11OLC005.mail.protection.outlook.com (10.1.14.145) with Microsoft SMTP Server (TLS) id 15.1.337.8 via Frontend Transport; Tue, 8 Dec 2015 08:25:57 +0000 Received: from perf-idc04.ap.freescale.net (perf-idc04.ap.freescale.net [10.232.14.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id tB88PdZG010760; Tue, 8 Dec 2015 01:25:54 -0700 From: Aneesh Bansal To: Date: Tue, 8 Dec 2015 13:54:30 +0530 Message-ID: <1449563070-5761-5-git-send-email-aneesh.bansal@freescale.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1449563070-5761-1-git-send-email-aneesh.bansal@freescale.com> References: <1449563070-5761-1-git-send-email-aneesh.bansal@freescale.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC005; 1:PT6eR57RD8xIDW4BTFPW/hgESl7pTfrLCsmq2l0s0BTReNw4zRr5JqIDvqVk26anGE3BBHuR70xB1LiHByLjTiBZr80qKl08A7xBQhjIpM24VFGRhC1gQXHo2PjmMuCDS6oFUDjoWafOCtWnTMMxbvMXOJMEBCJk2ll2JxID5aneNI49xuEdgm33M9Z9tV4MsOxsMUDZDKSIMOf6cH7g6eemAu1VKvjfagz7sJyzxwc3z0KYzfJyZQQbk3H8Fxu2LEer1BotBnY6H570jLlgqI42fIXqSnni+T1us2XB6l7f5BEH5pWNwL1+Kz768kzgJOvYADovZ6nZJOx1PILtjI0/Aki+jf13T+WOrvhKkvOYd9ec472ISgKvbgn8oPMy5H2SZDmXnoGivLkgEIMutBJggW/r1hkgm1sEJNZhXn8= X-Forefront-Antispam-Report: CIP:192.88.168.50; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(448002)(189002)(199003)(5003940100001)(19580405001)(6806005)(5008740100001)(106466001)(50226001)(189998001)(19580395003)(48376002)(50466002)(4001430100002)(586003)(1220700001)(104016004)(1096002)(110136002)(50986999)(107886002)(92566002)(450100001)(2950100001)(229853001)(5001960100002)(97736004)(86362001)(76176999)(2351001)(36756003)(85326001)(87936001)(81156007)(47776003)(33646002)(77096005); DIR:OUT; SFP:1102; SCL:1; SRVR:BN1PR0301MB0660; H:tx30smr01.am.freescale.net; FPR:; SPF:PermError; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; MIME-Version: 1.0 X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0660; 2:fbPgz1uP57NH9Qj4VSjG0zMWF97SupPF3HPi+YEWvrSHHRKsTqqWgq0/v6kR825BZczacap+dufAHEpk5i9v86jxC3z39Kdz1z0YMmUctCaBD4NWfhCD7ujBHfkO+cuh7C6FVi8+rhMc1lHpZFzzDg==; 3:INPYPd47eij+Vq3ThX17kMkQQXsXuRSMwNJY4WKWwvv5EQHRXOnAglW5y3S+TeBiD+rFOFv+BgvsRmBgVPO/U5Qn79JpEqL8gCY2VTuPxHjoua0XmjC28V+E5miwa0i7JOtmgY+3VvtTKSwRkYzBwxNNhnw2P6Z9zmnpz1Me3NyWl3roWMB+lyEpmMcuDNYSCkXEGtWQqv7NLWmdStwEIGDpEUur//7Beb3d6CvIiUs=; 25:pJ3rOvmwYzR4mzbvE/8SLbpV8rGs+66U2Kah35np84w7nfmOeedBkZF6GA4eaFORQYNyAx22qBkhOrAiUjUrE1T6d+TxxRF2+Bt81gRUkmE2i/0r6Xqv1pBM1OoIwv2vJVfJMC8cmW+OUiCnEtPilXrP0jANTqQx2/lLFBx4/MxwlbevE5jAj2Al37Ek+8j69hYitvGTeXZNWbxqAOsLS7j7n69EZclWScHmeIiEyOKzC+iT3qvtphz3XR2pKuZSBQxDnzdxJthwTnF8HO1z9A== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR0301MB0660; X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0660; 20:dEVkF3B9W+g/aNbKpcsE8X4LyvPCD111z2aP2WNjmXd+VXII50LCpdcsBuA4cwwx4UlvF1bf5jn8V9h750AgGc77PxF53ajPrg3UzG9acMNMP1FsSRL+XIulUHBMoGjUoWZhpvcn/TJ5L2j6bJKBsTq3pDbtUED67KTbyWBuMBE7BpU2n2gjZ7nJEzrx7KM5F++ESpkEsNsDGSMN+xVA0zjbCnlolkAiC8t5AXzihN3qm0DJ1ZGyrC9M4Jy/Ki7Kocey6ZLays7WYhFhAZ6L+YZtAYceRB9uHSrLtakxsx2hpMtfgom9PTcJiDZFmcuem64gUwDsJPE8+UxUnyMfdEic/zgaA2j+ttQk9QFePKA=; 4:Y0aFYdAtyWC9pDagMmVVydHbt62a4pKUhSCK4KQo681ZmnLaxmH71xkjHpEkqMJ0Sh14tFPo1ib+5UDfFTLTFPAbiIuWbZaQ7HVdRlTaO/EtfhHXc2dBMhsSSnL9dDo6LC5MSoW+3Kf9SpeIDO/3BRFE6aTNwehcmDaMzGXDnRyTyNB+aQYwJwMYKPAH3/Z4mcI6FfntJABFuqahFiU0BEcgQcLNiFmHOtRGGFHHvMwIU/zm8yjaCW7cTaU45A87r+GcQakjE71ymEyg5uXdly1vtgiUX+z+HtS3Jb+/ijYoT+q9fMXiwVzRRK1eOxmGCI3TD82E27GwKrM8nu5S1qHdPkzQ0eSUIdQexj13/8TllhyU3JTi4KsFdH5XobVO/nUPAQbmt2D+299xTWbWPRnrmWAx2mQN9mQJlf5SLkvVB7qeVZpQ7XfJI4ccPSNJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046); SRVR:BN1PR0301MB0660; BCL:0; PCL:0; RULEID:; SRVR:BN1PR0301MB0660; X-Forefront-PRVS: 0784C803FD X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1PR0301MB0660; 23:o0w+TWA/sMM9EZYq70d4EG0YTbiF+Dfi+vlunxi?= =?us-ascii?Q?5UCPbiBj53Rl8oi/SQuUNvZ7C0hcFy9yPQktJ2V+9Ps3+5U47OwxXeaHa+m4?= =?us-ascii?Q?/e1UpOtiKoBHn+YrBZd0KZzFP1pWAY+INx8u7JwEJM5PcglBN7BmQaGDttKw?= =?us-ascii?Q?YlTps9QIQySLBr3QsTUx9b9VLx6Y0bb1nMKHAyZM8cqg338dowtr/zaXNr0j?= =?us-ascii?Q?hSd/EOPWVg74DuCBjdJJKAO+/2Y3cRjTRdv+jKcbOJwV7KRfXYX6KBrtMhav?= =?us-ascii?Q?EvLTUQ+1a1WWn2r4X4VwUgxYszZohmADf7MZxZUYHkfP1/5k+OFCkVTy4Wap?= =?us-ascii?Q?6YYoITL77f2A/0eijwnkBlngQmgGrI+i7w1ASZFPbGxZFfvIXNJ1Ja7QSBhI?= =?us-ascii?Q?ZznTw8Z8UmoQbx0tiv5d8CkryW4q0ycrLnldeQ2SDGMeeTotQiLKo0BXBFso?= =?us-ascii?Q?oISgqjjN8CT9pAVwQBKGr0WuiZ0ZmGWXfqa/anbso2uao13Hv8XgG49VieC9?= =?us-ascii?Q?PrK4cubygspuvDIx1lnDf+ouRU/O/ef61nf7g4SHrwseM3gQFDOB5GnPOooh?= =?us-ascii?Q?yWbSSpHbzXnAGdNqHbI8V17tT+vNXBszKZxB5I4AYwXkgL+ca9AXmljGW1rG?= =?us-ascii?Q?95ccazMckHcyRm3wPBzF3tEk1Q6OGVY5ZW1t9BnnJ9DXzQDB80+F3K8gg9qt?= =?us-ascii?Q?uMoKnkmReoxjtcPD25l2uwiI0XImUfkzw4mMIglwBEP8qpym/n6wdbshsBio?= =?us-ascii?Q?zU+4/5G8BDfNZyg9dUuPlp+V0rAHrrIHMVjx9obW2lcipbU3+NwlfkP3e9W9?= =?us-ascii?Q?pT8UqfllXLaRkjK5y6bt1CYAyA1RcvQ9BlO8cqfkQeKE7NxP8w1Rj3AX+SD/?= =?us-ascii?Q?3UaEkupxpjaKMsvFL1aaP5ngSXONvEuEItJq/akiJW60zzYdrESHpN4tg+uP?= =?us-ascii?Q?2mGYTnMLy/zE5rPSze+eFlTKPmnz14/7G9YmUkkiKAAtNBbgX+kITK044Oz3?= =?us-ascii?Q?SGcxyiO18BnzALPq7D/7ykuHs+tLJA34Da2a/pu8mmEcS1Nho+mnX2SqwriD?= =?us-ascii?Q?HeKzrwOw=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0660; 5:vMgilxcDLl+EAngD8flpc8GfsFAiWQEsngNheQY1DT3EjI2me4OyeE8d2YJkwyujozOSsLJgr8AjiQfv3Ll2Y6o4JvVCU0FO1qVnwMX6aZPFO2h6mhz+eyzeRLf+fFbeyY4UtmYKZsCD9mCBumRrtw==; 24:7210UnhBnlMJvu9B7VTSbvFtHO/dQXBGp5mQvXYl7HRjkBd68k3JahwzYuT4ZuvWzeBef2nJ6W6jOFehFvMXp2gDNwmRVfIoigrI7cbSOKw= X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2015 08:25:57.6146 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0660 Cc: yorksun@freescale.com, ruchika.gupta@freescale.com Subject: [U-Boot] [PATCH 5/5][v5] drivers/crypto/fsl: fix endianness issue in RNG X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" For Setting and clearing the bits in SEC Block registers sec_clrbits32() and sec_setbits32() are used which work as per endianness of CAAM block. So these must be used with SEC register address as argument. If the value is read in a local variable, then the functions will not behave correctly where endianness of CAAM and core is different. Signed-off-by: Aneesh Bansal CC: Alex Porosanu --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None (New Patch set created with an additional patch) drivers/crypto/fsl/jr.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/fsl/jr.c b/drivers/crypto/fsl/jr.c index f63eacb..b553e3c 100644 --- a/drivers/crypto/fsl/jr.c +++ b/drivers/crypto/fsl/jr.c @@ -470,17 +470,13 @@ static void kick_trng(int ent_delay) sec_out32(&rng->rtfreqmin, ent_delay >> 2); /* disable maximum frequency count */ sec_out32(&rng->rtfreqmax, RTFRQMAX_DISABLE); - /* read the control register */ - val = sec_in32(&rng->rtmctl); /* * select raw sampling in both entropy shifter * and statistical checker */ - sec_setbits32(&val, RTMCTL_SAMP_MODE_RAW_ES_SC); + sec_setbits32(&rng->rtmctl, RTMCTL_SAMP_MODE_RAW_ES_SC); /* put RNG4 into run mode */ - sec_clrbits32(&val, RTMCTL_PRGM); - /* write back the control register */ - sec_out32(&rng->rtmctl, val); + sec_clrbits32(&rng->rtmctl, RTMCTL_PRGM); } static int rng_init(void)