From patchwork Fri Sep 25 16:25:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?=C5=81ukasz_Majewski?= X-Patchwork-Id: 522931 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 070CA140281 for ; Sat, 26 Sep 2015 02:25:54 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B7C1D4B778; Fri, 25 Sep 2015 18:25:51 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hvAu6wYHjiWt; Fri, 25 Sep 2015 18:25:51 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 410CA4B768; Fri, 25 Sep 2015 18:25:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A31DB4B768 for ; Fri, 25 Sep 2015 18:25:44 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KDlBWOapwXhK for ; Fri, 25 Sep 2015 18:25:44 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by theia.denx.de (Postfix) with ESMTPS id 14E674B764 for ; Fri, 25 Sep 2015 18:25:39 +0200 (CEST) Received: from epcpsbgm1new.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NV800Z4ZQYLXY20@mailout4.samsung.com> for u-boot@lists.denx.de; Sat, 26 Sep 2015 01:25:35 +0900 (KST) X-AuditID: cbfee61a-f79a06d000005c6f-ef-5605757f29bc Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id 23.72.23663.F7575065; Sat, 26 Sep 2015 01:25:35 +0900 (KST) Received: from mcdsrvbld02.digital.local ([106.116.37.23]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NV800CHVQYFAL30@mmp2.samsung.com>; Sat, 26 Sep 2015 01:25:35 +0900 (KST) From: Lukasz Majewski To: u-boot@lists.denx.de Date: Fri, 25 Sep 2015 18:25:25 +0200 Message-id: <1443198325-22460-1-git-send-email-l.majewski@samsung.com> X-Mailer: git-send-email 1.7.10.4 In-reply-to: <1440769821-24005-1-git-send-email-l.majewski@samsung.com> References: <1440769821-24005-1-git-send-email-l.majewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPLMWRmVeSWpSXmKPExsVy+t9jQd36UtYwg2831S3Wfb3NZPHmEbfF m4ebGS3etDUyWuy4fIPFYtftySwW37ZsY7SYOmkzu8XbvZ3sDpwe835OZPKY3XCRxWPerBMs Hq8OrGL3OHtnB6PHumlvmT36tqxi9Niy/zNjAEcUl01Kak5mWWqRvl0CV8ba7h+MBQs5K66v O8/SwLifvYuRk0NCwERi/u/LULaYxIV769m6GLk4hARmMUr0PlzHDuH8YZQ49WwCWBWbgJ7E 57tPmUBsEQEJiV/9VxlBipgFTjJJdE2YxAiSEBYIkNh9fxvQKA4OFgFVict7c0DCvAJuEo9P PWeC2KYo0f1sAhuIzSngLrH08T9WkHIhoJrvF/knMPIuYGRYxSiRWpBcUJyUnmuYl1quV5yY W1yal66XnJ+7iREcjM+kdjAe3OV+iFGAg1GJh1ehlSVMiDWxrLgy9xCjBAezkgjvRwvWMCHe lMTKqtSi/Pii0pzU4kOM0hwsSuK8Nw4xhAkJpCeWpGanphakFsFkmTg4pRoYOxILfkxpOzr3 kYbwOxGGYxqiCysWG+13/7ye+e7a+baRq7rKqt2PcMeKLrwpt8s9jzXjzCQ2r5PmTXxLBQum bhB+4PK6c9Jpva3TPv3Ks8iRVftW7DTF7VLK1YZcecVD3KLf9019vDKzI21V1wND+czdN860 sV99evIsx9S44Gf2BjtYn+1fr8RSnJFoqMVcVJwIADOrs59CAgAA Cc: "marex@denx.de" , Tom Rini , Alexey Brodkin , Pantelis Antoniou , Przemyslaw Marczak Subject: [U-Boot] [PATCH] mmc: dw_mmc: Increase timeout to 4 minutes (as in Linux kernel) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The commit: d9dbb97be0e4a550457aec5f11afefb446169c90 "mmc: dw_mmc: Zap endless timeout" removed endless loop waiting for end of dw mmc transfer. For some workloads - dfu test @ Odroid XU3 (sending 8MiB file) - and SD cards (e.g. MicroSD Kingston 4GiB, Adata 4GiB) the default timeout is to short. The new value - 4 minutes (240 seconds) - is the same as the one used in Linux kernel driver. Such fix should be good enough until we come up with better fix for this issue. Signed-off-by: Lukasz Majewski Cc: Marek Vasut Cc: Pantelis Antoniou Cc: Tom Rini Tested-by: Przemyslaw Marczak --- drivers/mmc/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index a84c1e1..26d34ae 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -214,7 +214,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, if (data) { start = get_timer(0); - timeout = 1000; + timeout = 240000; for (;;) { mask = dwmci_readl(host, DWMCI_RINTSTS); /* Error during data transfer. */