diff mbox

[U-Boot,3/4] exynos: be more verbose in process_nodes()

Message ID 1442793252-2935-1-git-send-email-tjakobi@math.uni-bielefeld.de
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Commit Message

Tobias Jakobi Sept. 20, 2015, 11:54 p.m. UTC 
In case sdhci_get_config() or do_sdhci_init() fail, show
the error code that was returned.

Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
---
 drivers/mmc/s5p_sdhci.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

Comments

Łukasz Majewski Sept. 23, 2015, 9:41 a.m. UTC | #1 
Hi Tobias,

> +		ret = sdhci_get_config(blob, node, host);
> +		if (ret) {
> +			printf("%s: failed to decode dev %d (%d)\n",
> __func__, i, ret); return -1;

My only commit here is regarding leaving return -1 as it is now. I
think, that it would be better to return ret.
diff mbox

Patch

diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c
index bc2102a..6be3609 100644
--- a/drivers/mmc/s5p_sdhci.c
+++ b/drivers/mmc/s5p_sdhci.c
@@ -171,7 +171,7 @@  static int sdhci_get_config(const void *blob, int node, struct sdhci_host *host)
 static int process_nodes(const void *blob, int node_list[], int count)
 {
 	struct sdhci_host *host;
-	int i, node;
+	int i, node, ret;
 
 	debug("%s: count = %d\n", __func__, count);
 
@@ -183,13 +183,15 @@  static int process_nodes(const void *blob, int node_list[], int count)
 
 		host = &sdhci_host[i];
 
-		if (sdhci_get_config(blob, node, host)) {
-			printf("%s: failed to decode dev %d\n",	__func__, i);
+		ret = sdhci_get_config(blob, node, host);
+		if (ret) {
+			printf("%s: failed to decode dev %d (%d)\n", __func__, i, ret);
 			return -1;
 		}
 
-		if (do_sdhci_init(host)) {
-			printf("%s: failed to initialize dev %d\n", __func__, i);
+		ret = do_sdhci_init(host);
+		if (ret) {
+			printf("%s: failed to initialize dev %d (%d)\n", __func__, i, ret);
 			return -2;
 		}
 	}