From patchwork Tue Sep 8 14:49:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siarhei Siamashka X-Patchwork-Id: 515426 X-Patchwork-Delegate: hdegoede@redhat.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 04C461400CB for ; Wed, 9 Sep 2015 00:49:22 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=vpc/J8BG; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 401A04B779; Tue, 8 Sep 2015 16:49:19 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sZBk8MqAU1HW; Tue, 8 Sep 2015 16:49:18 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 887414B6AD; Tue, 8 Sep 2015 16:49:18 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 4409D4B65F for ; Tue, 8 Sep 2015 16:49:16 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CQEDEFuiWUmj for ; Tue, 8 Sep 2015 16:49:16 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com [209.85.215.53]) by theia.denx.de (Postfix) with ESMTPS id 0CDB44B622 for ; Tue, 8 Sep 2015 16:49:12 +0200 (CEST) Received: by lamp12 with SMTP id p12so68999081lam.0 for ; Tue, 08 Sep 2015 07:49:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=HAug7cSf4uLmJZGbUdR/XxvIzLzYFwTLSTwMgTIzTk0=; b=vpc/J8BGtGi6d4Vg6vnGMfFPbTCamv8A1OrZ27N+i0hrlHF0JITubimi1eufzmGIqI GS9C+R9HTkUsIiXNGmGt64GXB6+HThed7+6Y1z+fyy3R2DLM/tobwlPjgECSuEyq642X tsDetMZLdoQqwsTm7kCx5GvjW/abMXRXUXPnpU14QAd7A9HhEas3f2aQmevHii9YTXOJ mmZqDwKybObCeKEKELUDNj8lpVhnz1iesU0nXSZsh0gIUUZ/TNyF42NEBGhLLOjkAaBF hOUJtkAgZ9ZO1ZYx1eLQsyFtDSEns/IXNvRMksVLNO8d+Z+ga3+pcG0eZ+C8XPNnws7W hklQ== X-Received: by 10.152.36.7 with SMTP id m7mr22354344laj.87.1441723751772; Tue, 08 Sep 2015 07:49:11 -0700 (PDT) Received: from localhost.localdomain (85-76-71-228-nat.elisa-mobile.fi. [85.76.71.228]) by smtp.gmail.com with ESMTPSA id bx5sm977693lbc.36.2015.09.08.07.49.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 Sep 2015 07:49:11 -0700 (PDT) From: Siarhei Siamashka To: u-boot@lists.denx.de Date: Tue, 8 Sep 2015 17:49:08 +0300 Message-Id: <1441723748-26540-1-git-send-email-siarhei.siamashka@gmail.com> X-Mailer: git-send-email 2.4.6 Cc: Ian Campbell Subject: [U-Boot] [PATCH] sunxi: Fix wrong serial console setup in Forfun Q88DB tablet X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The Forfun Q88DB tablet was unbootable since commit b6006baf9c2553543e3384983d23d95efbf24fa6 ("sunxi: Move all boards to the driver-model"). Appears that this is caused by the wrong serial console setup in the SPL. The serial console should use PG3/PG4 pins according to the FEX file. Signed-off-by: Siarhei Siamashka --- configs/forfun_q88db_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) While this should be a correct fix, the reason why the tablet failed to boot is a bit unclear. Without the correct CONS_INDEX setup, we should just get the serial console routed to the nonexisting pins B19/B20, and this is expected to be harmless. Maybe the DM code in the main U-Boot binary can't initialize serial console properly if we have a mismatch between the settings in the dts file and the CONS_INDEX settings in the SPL? diff --git a/configs/forfun_q88db_defconfig b/configs/forfun_q88db_defconfig index 30cead7..30e0937 100644 --- a/configs/forfun_q88db_defconfig +++ b/configs/forfun_q88db_defconfig @@ -13,7 +13,7 @@ CONFIG_VIDEO_LCD_BL_PWM="PB2" CONFIG_DEFAULT_DEVICE_TREE="sun5i-a13-forfun-q88db" # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL=y -CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER" +CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=2,AXP209_POWER" # CONFIG_CMD_IMLS is not set # CONFIG_CMD_FLASH is not set # CONFIG_CMD_FPGA is not set