From patchwork Mon Sep 7 20:13:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 515242 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 2C0311400B7 for ; Tue, 8 Sep 2015 06:13:36 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id AA4254B764; Mon, 7 Sep 2015 22:13:33 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bxTAwY701FNI; Mon, 7 Sep 2015 22:13:33 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E55E24B74D; Mon, 7 Sep 2015 22:13:32 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9523A4B74D for ; Mon, 7 Sep 2015 22:13:29 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nPuebITlc1z0 for ; Mon, 7 Sep 2015 22:13:29 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by theia.denx.de (Postfix) with ESMTPS id 106254B746 for ; Mon, 7 Sep 2015 22:13:25 +0200 (CEST) Received: by padhy16 with SMTP id hy16so101621807pad.1 for ; Mon, 07 Sep 2015 13:13:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id; bh=aBv1YNAnsdliLWrbua560mkh1VswXWPFwC99OBLrGtI=; b=JTXalypHlX5XlaPtbuejiFYMRUrpz+2U7pS0RilW+uWLJtbH8rlu27ch0l9UDB8TBl ctTDddXagpLDOvVrcikk62WiMEKdHlizggWyDd5pg1mjsq85STbyHFIe0un6dD5Kzjoc IdYtKWT9ZAOsr2dz/TLmtuSYnqRgDPp5FAtTIIZUk6JAOLaWwLnRUkhwTNuYFBv8T8ne t9KQaM0zlO/guDRp1a3FFB/njJaXexgwdajZQx945d/jKS8kHTh3v+BiMAwmAaiQwl5m xAFVvr/kLUq0g7SoWI/EnsZqB/zJy9dy83GlC3pIH15fd17MdYqyls9mui9VnWKwtdLz gAWw== X-Received: by 10.68.239.202 with SMTP id vu10mr49555357pbc.135.1441656803445; Mon, 07 Sep 2015 13:13:23 -0700 (PDT) Received: from localhost.localdomain ([1.39.96.138]) by smtp.gmail.com with ESMTPSA id zf5sm725695pbc.36.2015.09.07.13.13.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 Sep 2015 13:13:22 -0700 (PDT) From: Jagan Teki To: u-boot@lists.denx.de Date: Tue, 8 Sep 2015 01:43:01 +0530 Message-Id: <1441656783-8658-1-git-send-email-jteki@openedev.com> X-Mailer: git-send-email 1.9.1 Cc: Jagan Teki Subject: [U-Boot] [PATCH 1/3] spi: xilinx_spi: Fix to configure CPOL, CPHA mask X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" priv->mode is initialized when .set_speed triggers with mode value, so checking mode for configuring CPOL, CPHA using priv->mode is invalid hence use mode from .set_speed argument, and at the end priv->mode will initialized with mode. This patch also replaces formatting string to use speed instead of mode in .set_speed ops. Signed-off-by: Jagan Teki --- drivers/spi/xilinx_spi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi/xilinx_spi.c index 6c21acd..8ccc578 100644 --- a/drivers/spi/xilinx_spi.c +++ b/drivers/spi/xilinx_spi.c @@ -247,7 +247,7 @@ static int xilinx_spi_set_speed(struct udevice *bus, uint speed) priv->freq = speed; - debug("xilinx_spi_set_speed: regs=%p, mode=%d\n", priv->regs, + debug("xilinx_spi_set_speed: regs=%p, speed=%d\n", priv->regs, priv->freq); return 0; @@ -260,13 +260,13 @@ static int xilinx_spi_set_mode(struct udevice *bus, uint mode) uint32_t spicr; spicr = readl(®s->spicr); - if (priv->mode & SPI_LSB_FIRST) + if (mode & SPI_LSB_FIRST) spicr |= SPICR_LSB_FIRST; - if (priv->mode & SPI_CPHA) + if (mode & SPI_CPHA) spicr |= SPICR_CPHA; - if (priv->mode & SPI_CPOL) + if (mode & SPI_CPOL) spicr |= SPICR_CPOL; - if (priv->mode & SPI_LOOP) + if (mode & SPI_LOOP) spicr |= SPICR_LOOP; writel(spicr, ®s->spicr);