diff mbox

[U-Boot,3/3] net: phy: Test previous phydev->dev against new mac dev

Message ID 1441367812-26899-3-git-send-email-bmeng.cn@gmail.com
State Superseded
Delegated to: Joe Hershberger
Headers show

Commit Message

Bin Meng Sept. 4, 2015, 11:56 a.m. UTC
In phy_connect_dev(), if the phy device has an accociated mac device
before, a warning message will be printed. But we should test the
old device against the new one, if they are actually the same one,
don't print the warning message.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 drivers/net/phy/phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joe Hershberger Sept. 23, 2015, 5:04 p.m. UTC | #1
Hi Bin,

On Fri, Sep 4, 2015 at 6:56 AM, Bin Meng <bmeng.cn@gmail.com> wrote:
> In phy_connect_dev(), if the phy device has an accociated mac device
> before, a warning message will be printed. But we should test the
> old device against the new one, if they are actually the same one,
> don't print the warning message.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
diff mbox

Patch

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 651e456..35dfcc1 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -789,7 +789,7 @@  void phy_connect_dev(struct phy_device *phydev, struct eth_device *dev)
 {
 	/* Soft Reset the PHY */
 	phy_reset(phydev);
-	if (phydev->dev) {
+	if (phydev->dev && phydev->dev != dev) {
 		printf("%s:%d is connected to %s.  Reconnecting to %s\n",
 				phydev->bus->name, phydev->addr,
 				phydev->dev->name, dev->name);