diff mbox

[U-Boot] serial: drop redundant depends on

Message ID 1440760461-14285-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Masahiro Yamada Aug. 28, 2015, 11:14 a.m. UTC
SANDBOX_SERIAL depends on SANDBOX, and SANDBOX selects DM.
So, "SANDBOX_SERIAL depends on DM" is redundant.

Likewise, UNIPHIER_SERIAL depends on ARCH_UNIPHIER, and
ARCH_UNIPHIER selects DM_SERIAL.
So, "UNIPHIER_SERIAL depends on DM_SERIAL" is redundant.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/serial/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Glass Aug. 28, 2015, 11:21 p.m. UTC | #1
On 28 August 2015 at 05:14, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> SANDBOX_SERIAL depends on SANDBOX, and SANDBOX selects DM.
> So, "SANDBOX_SERIAL depends on DM" is redundant.
>
> Likewise, UNIPHIER_SERIAL depends on ARCH_UNIPHIER, and
> ARCH_UNIPHIER selects DM_SERIAL.
> So, "UNIPHIER_SERIAL depends on DM_SERIAL" is redundant.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  drivers/serial/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Simon Glass <sjg@chromium.org>
Tom Rini Sept. 2, 2015, 9:58 p.m. UTC | #2
On Fri, Aug 28, 2015 at 08:14:21PM +0900, Masahiro Yamada wrote:

> SANDBOX_SERIAL depends on SANDBOX, and SANDBOX selects DM.
> So, "SANDBOX_SERIAL depends on DM" is redundant.
> 
> Likewise, UNIPHIER_SERIAL depends on ARCH_UNIPHIER, and
> ARCH_UNIPHIER selects DM_SERIAL.
> So, "UNIPHIER_SERIAL depends on DM_SERIAL" is redundant.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 4f6a3b8..002f1da 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -111,7 +111,7 @@  config DEBUG_UART_SHIFT
 
 config SANDBOX_SERIAL
 	bool "Sandbox UART support"
-	depends on SANDBOX && DM
+	depends on SANDBOX
 	help
 	  Select this to enable a seral UART for sandbox. This is required to
 	  operate correctly, otherwise you will see no serial output from
@@ -131,7 +131,7 @@  config SANDBOX_SERIAL
 
 config UNIPHIER_SERIAL
 	bool "Support for UniPhier on-chip UART"
-	depends on ARCH_UNIPHIER && DM_SERIAL
+	depends on ARCH_UNIPHIER
 	help
 	  If you have a UniPhier based board and want to use the on-chip
 	  serial ports, say Y to this option. If unsure, say N.