| Message ID | 1439247577-8926-2-git-send-email-marex@denx.de |
|---|---|
| State | Accepted |
| Delegated to: | Marek Vasut |
| Headers | show |
On 8/10/15 5:59 PM, Marek Vasut wrote: > Fix the following problem: > drivers/ddr/altera/sequencer.c: In function 'sdram_calibration_full': > drivers/ddr/altera/sequencer.c:1943:25: warning: 'found_failing_read' may be used uninitialized in this function [-Wmaybe-uninitialized] > if (found_passing_read && found_failing_read) > ^ > drivers/ddr/altera/sequencer.c:1803:26: note: 'found_failing_read' was declared here > u32 found_passing_read, found_failing_read, initial_failing_dtap; > ^ > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > drivers/ddr/altera/sequencer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com> Thanks, Dinh
On Tuesday, August 18, 2015 at 10:14:17 PM, Dinh Nguyen wrote: > On 8/10/15 5:59 PM, Marek Vasut wrote: > > Fix the following problem: > > drivers/ddr/altera/sequencer.c: In function 'sdram_calibration_full': > > drivers/ddr/altera/sequencer.c:1943:25: warning: 'found_failing_read' may > > be used uninitialized in this function [-Wmaybe-uninitialized] > > > > if (found_passing_read && found_failing_read) > > > > ^ > > > > drivers/ddr/altera/sequencer.c:1803:26: note: 'found_failing_read' was > > declared here > > > > u32 found_passing_read, found_failing_read, initial_failing_dtap; > > > > ^ > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > --- > > > > drivers/ddr/altera/sequencer.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com> Applied to u-boot-socfpga/master, thanks! Best regards, Marek Vasut
diff --git a/drivers/ddr/altera/sequencer.c b/drivers/ddr/altera/sequencer.c index f3621cf..79c265f 100644 --- a/drivers/ddr/altera/sequencer.c +++ b/drivers/ddr/altera/sequencer.c @@ -1800,7 +1800,7 @@ static int rw_mgr_mem_calibrate_vfifo_find_dqs_en_phase(const u32 grp) u32 d, p, i; u32 dtaps_per_ptap; u32 work_bgn, work_end; - u32 found_passing_read, found_failing_read, initial_failing_dtap; + u32 found_passing_read, found_failing_read = 0, initial_failing_dtap; int ret; debug("%s:%d %u\n", __func__, __LINE__, grp);
Fix the following problem: drivers/ddr/altera/sequencer.c: In function 'sdram_calibration_full': drivers/ddr/altera/sequencer.c:1943:25: warning: 'found_failing_read' may be used uninitialized in this function [-Wmaybe-uninitialized] if (found_passing_read && found_failing_read) ^ drivers/ddr/altera/sequencer.c:1803:26: note: 'found_failing_read' was declared here u32 found_passing_read, found_failing_read, initial_failing_dtap; ^ Signed-off-by: Marek Vasut <marex@denx.de> --- drivers/ddr/altera/sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)