diff mbox

[U-Boot,v2] mpc85xx/T104xRDB: Remove vbank check redundant code

Message ID 1438231818-11413-1-git-send-email-Priyanka.Jain@freescale.com
State Accepted
Delegated to: York Sun
Headers show

Commit Message

Priyanka Jain July 30, 2015, 4:50 a.m. UTC 
sw variable in checkboard function is storing vbank value
which can only take 3-bit value.
So check of sw value for if greater than 7 is redundant.

Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
---
Changes for v2:
 Corrected description to check is for 3-bit value

 board/freescale/t104xrdb/t104xrdb.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

Comments

York Sun July 31, 2015, 3:56 p.m. UTC | #1 
On 07/29/2015 09:50 PM, Priyanka Jain wrote:
> sw variable in checkboard function is storing vbank value
> which can only take 3-bit value.
> So check of sw value for if greater than 7 is redundant.
> 
> Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
> ---
> Changes for v2:
>  Corrected description to check is for 3-bit value

Applied to u-boot-mpc85xx master after fixing subject.

Thanks.

York
diff mbox

Patch

diff --git a/board/freescale/t104xrdb/t104xrdb.c b/board/freescale/t104xrdb/t104xrdb.c
index 9cd5e15..c34eea6 100644
--- a/board/freescale/t104xrdb/t104xrdb.c
+++ b/board/freescale/t104xrdb/t104xrdb.c
@@ -35,10 +35,7 @@  int checkboard(void)
 	sw = CPLD_READ(flash_ctl_status);
 	sw = ((sw & CPLD_LBMAP_MASK) >> CPLD_LBMAP_SHIFT);
 
-	if (sw <= 7)
-		printf("vBank: %d\n", sw);
-	else
-		printf("Unsupported Bank=%x\n", sw);
+	printf("vBank: %d\n", sw);
 
 	return 0;
 }