From patchwork Mon Jul 20 21:00:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 497904 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 5B5DC140DDA for ; Tue, 21 Jul 2015 07:00:44 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1040A4B64D; Mon, 20 Jul 2015 23:00:39 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lClZggwoEpTC; Mon, 20 Jul 2015 23:00:38 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A306D4B660; Mon, 20 Jul 2015 23:00:29 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 367FB4B61D for ; Mon, 20 Jul 2015 23:00:22 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NKTrQTKF_K5p for ; Mon, 20 Jul 2015 23:00:22 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mout.web.de (mout.web.de [212.227.17.12]) by theia.denx.de (Postfix) with ESMTPS id 07CE64A039 for ; Mon, 20 Jul 2015 23:00:21 +0200 (CEST) Received: from kongar.lan.local ([185.44.151.6]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0LpwB1-1YlpVW3KtD-00fj5v; Mon, 20 Jul 2015 23:00:17 +0200 From: Alexander Stein To: Albert Aribaud , Stephen Warren Date: Mon, 20 Jul 2015 23:00:02 +0200 Message-Id: <1437426004-22549-5-git-send-email-alexanders83@web.de> X-Mailer: git-send-email 2.4.6 In-Reply-To: <1437426004-22549-1-git-send-email-alexanders83@web.de> References: <1437426004-22549-1-git-send-email-alexanders83@web.de> X-Provags-ID: V03:K0:zjv8wsygULKov9hCn8VO2w22aF9pndCdftqGpmuz6pV0C3q1Pl2 p2edngEVExPX6jQULS5q8bda/VgODldlSyqgfJHSFYDLlfrtiMC/0Uw1DJFrmJtiyzuMaFC ljLKg66iPT3X3NEsywtxFcFEQSqBxjsNfnFHEOrUq2UGAAmBys3jsWllTIQ9G0duB0J+Jao 6Ps+jGXRahmbS4S8nH/XQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:DqHJI05b0UU=:w21aSptpNRQ4WnEq3v0N7b i8Xs5xsFFlB8Kbxjxust0Wdjc/IGRO5RwEChksmF5PDyWHoiPxdTOsCp/SGTCYG7Un/QzTzPU iZmxZ2jdLlADodYbqkcsd8HWN+udkPF2ll/QT2zjX0T3i9HCSug7uYc9B3OyEGT4+UNql1+AD Oj9k7DRKIUem2gCqpwxe+MgWx+2erN8ZN1DePqhcsjd0htjNlxNlsDsr9FYmEH+a6l0RK1gQM bVOR6jJxWQPGpHc+P8rkjAoPX0x/nhxyznJDC5l46a8NGE6VWTqfR/7oUmBWLTm76Hs67gdlw xOnAjBmQokl8SgwfI8NdW/xouKnxT2atw5qVMDzFKmOzEsIi9PuqOUSUc3DlScoFfV+NljjfK EaA755Q6QyvjR32jgtALQqy1fuPlLyiFRmPtwt0ApUyxFqraBtdMIleg0WQuxvcTjamsgppD4 aWklTkU1pA+Qqi+c4HnJ0bEkGYaHvXzE4PX+W1IrycfHj7v7fFxcp0wWQT5//vtcGFOatvWTO CnpsNQ7MiGh7PmQe4ZtG2A8bUgSHB2u6e7Mr5SgNQZJCF3iJXs/UHm1qmN6v41UV/2pVpF+Go TWOSS3Eu8f6b3Rf6K0S/fwV+bHs7HpsNoPodbxoqj3qqrYvqYYfF3woEkY82cCiiAvM2Yv6W7 EhTC0ql+pQQM9UDTDs5X61zxcNHuUiy+GlIOjLCWiwKCEVTaztcArPx80owfLvXDjJso= Cc: Alexander Stein , u-boot@lists.denx.de Subject: [U-Boot] [PATCH v2 4/6] ARM: bcm283x: Allocate all mailbox buffers cacheline aligned X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The mailbox buffer is required to be at least 16 bytes aligned, but for cache invalidation and/or flush it needs to be cacheline aligned. Use CONFIG_SYS_CACHELINE_SIZE alignment for all mailbox buffer allocations. Signed-off-by: Alexander Stein --- board/raspberrypi/rpi/rpi.c | 10 +++++----- drivers/video/bcm2835.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c index 96fe870..d5d3fec 100644 --- a/board/raspberrypi/rpi/rpi.c +++ b/board/raspberrypi/rpi/rpi.c @@ -182,7 +182,7 @@ u32 rpi_board_rev = 0; int dram_init(void) { - ALLOC_ALIGN_BUFFER(struct msg_get_arm_mem, msg, 1, 16); + ALLOC_ALIGN_BUFFER(struct msg_get_arm_mem, msg, 1, CONFIG_SYS_CACHELINE_SIZE); int ret; BCM2835_MBOX_INIT_HDR(msg); @@ -212,7 +212,7 @@ static void set_fdtfile(void) static void set_usbethaddr(void) { - ALLOC_ALIGN_BUFFER(struct msg_get_mac_address, msg, 1, 16); + ALLOC_ALIGN_BUFFER(struct msg_get_mac_address, msg, 1, CONFIG_SYS_CACHELINE_SIZE); int ret; if (!models[rpi_board_rev].has_onboard_eth) @@ -245,7 +245,7 @@ int misc_init_r(void) static int power_on_module(u32 module) { - ALLOC_ALIGN_BUFFER(struct msg_set_power_state, msg_pwr, 1, 16); + ALLOC_ALIGN_BUFFER(struct msg_set_power_state, msg_pwr, 1, CONFIG_SYS_CACHELINE_SIZE); int ret; BCM2835_MBOX_INIT_HDR(msg_pwr); @@ -269,7 +269,7 @@ static int power_on_module(u32 module) static void get_board_rev(void) { - ALLOC_ALIGN_BUFFER(struct msg_get_board_rev, msg, 1, 16); + ALLOC_ALIGN_BUFFER(struct msg_get_board_rev, msg, 1, CONFIG_SYS_CACHELINE_SIZE); int ret; const char *name; @@ -324,7 +324,7 @@ int board_init(void) int board_mmc_init(bd_t *bis) { - ALLOC_ALIGN_BUFFER(struct msg_get_clock_rate, msg_clk, 1, 16); + ALLOC_ALIGN_BUFFER(struct msg_get_clock_rate, msg_clk, 1, CONFIG_SYS_CACHELINE_SIZE); int ret; power_on_module(BCM2835_MBOX_POWER_DEVID_SDHCI); diff --git a/drivers/video/bcm2835.c b/drivers/video/bcm2835.c index 1f18231..30e22cc 100644 --- a/drivers/video/bcm2835.c +++ b/drivers/video/bcm2835.c @@ -38,8 +38,8 @@ struct msg_setup { void lcd_ctrl_init(void *lcdbase) { - ALLOC_ALIGN_BUFFER(struct msg_query, msg_query, 1, 16); - ALLOC_ALIGN_BUFFER(struct msg_setup, msg_setup, 1, 16); + ALLOC_ALIGN_BUFFER(struct msg_query, msg_query, 1, CONFIG_SYS_CACHELINE_SIZE); + ALLOC_ALIGN_BUFFER(struct msg_setup, msg_setup, 1, CONFIG_SYS_CACHELINE_SIZE); int ret; u32 w, h;