diff mbox

[U-Boot,1/2] net: phy: broadcom: Add BCM Cygnus PHY

Message ID 1437002894-27289-2-git-send-email-srae@broadcom.com
State Accepted
Delegated to: Joe Hershberger
Headers show

Commit Message

Steve Rae July 15, 2015, 11:28 p.m. UTC 
From: Jiandong Zheng <jdzheng@broadcom.com>

Add Ethernet PHY for BCM Cygnus SoC

Signed-off-by: Jiandong Zheng <jdzheng@broadcom.com>
Signed-off-by: Steve Rae <srae@broadcom.com>
---

 drivers/net/phy/broadcom.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

Comments

Albert ARIBAUD July 16, 2015, 2:29 p.m. UTC | #1 
Hello Steve,

On Wed, 15 Jul 2015 16:28:13 -0700, Steve Rae <srae@broadcom.com> wrote:
> From: Jiandong Zheng <jdzheng@broadcom.com>
> 
> Add Ethernet PHY for BCM Cygnus SoC
> 
> Signed-off-by: Jiandong Zheng <jdzheng@broadcom.com>
> Signed-off-by: Steve Rae <srae@broadcom.com>
> ---
> 
>  drivers/net/phy/broadcom.c | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)

This patch does not add the PHY in drivers/net/phy/Makefile.
How does the object file ever get built?

Amicalement,
Albert ARIBAUD July 16, 2015, 2:30 p.m. UTC | #2 
On Thu, 16 Jul 2015 16:29:45 +0200, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:
> Hello Steve,
> 
> On Wed, 15 Jul 2015 16:28:13 -0700, Steve Rae <srae@broadcom.com> wrote:
> > From: Jiandong Zheng <jdzheng@broadcom.com>
> > 
> > Add Ethernet PHY for BCM Cygnus SoC
> > 
> > Signed-off-by: Jiandong Zheng <jdzheng@broadcom.com>
> > Signed-off-by: Steve Rae <srae@broadcom.com>
> > ---
> > 
> >  drivers/net/phy/broadcom.c | 29 +++++++++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> 
> This patch does not add the PHY in drivers/net/phy/Makefile.
> How does the object file ever get built?

Scratch that, I misread this as an addition. Time for a coffee break.
 
Amicalement,
Joe Hershberger Aug. 11, 2015, 4:52 p.m. UTC | #3 
Hi Steve,

On Wed, Jul 15, 2015 at 6:28 PM, Steve Rae <srae@broadcom.com> wrote:
> From: Jiandong Zheng <jdzheng@broadcom.com>
>
> Add Ethernet PHY for BCM Cygnus SoC
>
> Signed-off-by: Jiandong Zheng <jdzheng@broadcom.com>
> Signed-off-by: Steve Rae <srae@broadcom.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Joe Hershberger Aug. 12, 2015, 7:26 p.m. UTC | #4 
Hi Steve,

On Wed, Jul 15, 2015 at 6:28 PM, Steve Rae <srae@broadcom.com> wrote:
> From: Jiandong Zheng <jdzheng@broadcom.com>
>
> Add Ethernet PHY for BCM Cygnus SoC
>
> Signed-off-by: Jiandong Zheng <jdzheng@broadcom.com>
> Signed-off-by: Steve Rae <srae@broadcom.com>

Applied to u-boot-net, thanks!
-Joe
diff mbox

Patch

diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index 4512763..4b2808e 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -137,6 +137,24 @@  static int bcm5482_config(struct phy_device *phydev)
 	return 0;
 }
 
+static int bcm_cygnus_startup(struct phy_device *phydev)
+{
+	/* Read the Status (2x to make sure link is right) */
+	genphy_update_link(phydev);
+	genphy_parse_link(phydev);
+
+	return 0;
+}
+
+static int bcm_cygnus_config(struct phy_device *phydev)
+{
+	genphy_config_aneg(phydev);
+
+	phy_reset(phydev);
+
+	return 0;
+}
+
 /*
  * Find out if PHY is in copper or serdes mode by looking at Expansion Reg
  * 0x42 - "Operating Mode Status Register"
@@ -264,11 +282,22 @@  static struct phy_driver BCM5482S_driver = {
 	.shutdown = &genphy_shutdown,
 };
 
+static struct phy_driver BCM_CYGNUS_driver = {
+	.name = "Broadcom CYGNUS GPHY",
+	.uid = 0xae025200,
+	.mask = 0xfffff0,
+	.features = PHY_GBIT_FEATURES,
+	.config = &bcm_cygnus_config,
+	.startup = &bcm_cygnus_startup,
+	.shutdown = &genphy_shutdown,
+};
+
 int phy_broadcom_init(void)
 {
 	phy_register(&BCM5482S_driver);
 	phy_register(&BCM5464S_driver);
 	phy_register(&BCM5461S_driver);
+	phy_register(&BCM_CYGNUS_driver);
 
 	return 0;
 }