| Message ID | 1436968946-16025-5-git-send-email-contact@paulk.fr |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Wed, Jul 15, 2015 at 04:02:22PM +0200, Paul Kocialkowski wrote: > The config file for the siemens-am33x-common was using OMAP_I2C_STANDARD, which > is defined in a header that is not included in the config header. In most cases, > it was being included by the code using CONFIG_SYS_OMAP24_I2C_SPEED, but it > might not always be the case. > > In particular, when introducing I2C SPL support in omap-common's boot-common.c, > the header is missing and including it breaks other devices. > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> Applied to u-boot/master, thanks!
diff --git a/include/configs/siemens-am33x-common.h b/include/configs/siemens-am33x-common.h index f33f9b4..f7bef70 100644 --- a/include/configs/siemens-am33x-common.h +++ b/include/configs/siemens-am33x-common.h @@ -133,7 +133,7 @@ #define CONFIG_I2C #define CONFIG_CMD_I2C #define CONFIG_SYS_I2C -#define CONFIG_SYS_OMAP24_I2C_SPEED OMAP_I2C_STANDARD +#define CONFIG_SYS_OMAP24_I2C_SPEED 100000 #define CONFIG_SYS_OMAP24_I2C_SLAVE 1 #define CONFIG_SYS_I2C_OMAP24XX
The config file for the siemens-am33x-common was using OMAP_I2C_STANDARD, which is defined in a header that is not included in the config header. In most cases, it was being included by the code using CONFIG_SYS_OMAP24_I2C_SPEED, but it might not always be the case. In particular, when introducing I2C SPL support in omap-common's boot-common.c, the header is missing and including it breaks other devices. Signed-off-by: Paul Kocialkowski <contact@paulk.fr> --- include/configs/siemens-am33x-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)