From patchwork Mon Jun 29 12:58:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Roese X-Patchwork-Id: 489304 X-Patchwork-Delegate: sr@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 9A3C514076D for ; Mon, 29 Jun 2015 22:59:49 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 208094B802; Mon, 29 Jun 2015 14:59:14 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8Gg2vir94f_e; Mon, 29 Jun 2015 14:59:14 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 51A1D4B830; Mon, 29 Jun 2015 14:59:00 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7EBC54B80E for ; Mon, 29 Jun 2015 14:58:46 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w2PIrP75i99i for ; Mon, 29 Jun 2015 14:58:46 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mo4-p04-ob.smtp.rzone.de (mo4-p04-ob.smtp.rzone.de [81.169.146.223]) by theia.denx.de (Postfix) with ESMTPS id 187864B768 for ; Mon, 29 Jun 2015 14:58:28 +0200 (CEST) X-RZG-CLASS-ID: mo04 X-RZG-AUTH: :IW0NeWC7b/q2i6W/qstXb1SBUuFnrGohfvxEndrDXKjzPMsB3oimjD61I4fPQhgcxmV3 Received: from stefan-work.domain_not_set.invalid (b9168f12.cgn.dg-w.de [185.22.143.18]) by post.strato.de (RZmta 37.8 SBL|AUTH) with ESMTPA id 600893r5TCwH0ve; Mon, 29 Jun 2015 14:58:17 +0200 (CEST) From: Stefan Roese To: u-boot@lists.denx.de Date: Mon, 29 Jun 2015 14:58:12 +0200 Message-Id: <1435582696-30068-6-git-send-email-sr@denx.de> X-Mailer: git-send-email 2.4.5 In-Reply-To: <1435582696-30068-1-git-send-email-sr@denx.de> References: <1435582696-30068-1-git-send-email-sr@denx.de> Cc: Tom Rini , Luka Perkov Subject: [U-Boot] [PATCH v1 5/9] block: ahci: Don't enable port interrupts X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" This patch changes the initialization of the AHCI controller to not enable the default interrupts (DEF_PORT_IRQ). As interrupts are not used in U-Boot in general, this should not break the common AHCI driver operation. This change is needed to support the Marvell Armada 38x AHCI controller. With interrupts enabled, this results in timeouts in ahci_device_data_io(). Not enabling these interrupts fixes this problem and the common AHCI driver works fine. Signed-off-by: Stefan Roese Cc: Tom Rini Cc: Hans de Goede Cc: Simon Glass Cc: Luka Perkov Reviewed-by: Simon Glass --- drivers/block/ahci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c index 4fb846a..9bab0fc 100644 --- a/drivers/block/ahci.c +++ b/drivers/block/ahci.c @@ -299,9 +299,6 @@ static int ahci_host_init(struct ahci_probe_ent *probe_ent) writel(1 << i, mmio + HOST_IRQ_STAT); - /* set irq mask (enables interrupts) */ - writel(DEF_PORT_IRQ, port_mmio + PORT_IRQ_MASK); - /* register linkup ports */ tmp = readl(port_mmio + PORT_SCR_STAT); debug("SATA port %d status: 0x%x\n", i, tmp);