diff mbox

[U-Boot,V2,09/11] colibri_vf: Add separate defconfig for device tree support

Message ID 1433148694-12898-10-git-send-email-bhuvanchandra.dv@toradex.com
State Superseded
Delegated to: Stefano Babic
Headers show

Commit Message

Bhuvanchandra DV June 1, 2015, 8:51 a.m. UTC
Most of the drivers available for Vybrid are not yet converted
to OF model to use device tree model, only few drivers
like SPI and GPIO drivers use device trees.
Add separate defconfig for who needs to use device tree model.
Later this can be integrated to single defconfig.

Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
---
 configs/colibri_vf_dtb_defconfig | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 configs/colibri_vf_dtb_defconfig

Comments

Stefan Agner June 1, 2015, 10:35 a.m. UTC | #1
On 2015-06-01 10:51, Bhuvanchandra DV wrote:
> Most of the drivers available for Vybrid are not yet converted
> to OF model to use device tree model, only few drivers
> like SPI and GPIO drivers use device trees.
> Add separate defconfig for who needs to use device tree model.
> Later this can be integrated to single defconfig.
> 
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> ---
>  configs/colibri_vf_dtb_defconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 configs/colibri_vf_dtb_defconfig
> 
> diff --git a/configs/colibri_vf_dtb_defconfig b/configs/colibri_vf_dtb_defconfig
> new file mode 100644
> index 0000000..d4c8c58
> --- /dev/null
> +++ b/configs/colibri_vf_dtb_defconfig
> @@ -0,0 +1,8 @@
> +CONFIG_ARM=y
> +CONFIG_TARGET_COLIBRI_VF=y
> +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri_vf/imximage.cfg,ENV_IS_IN_NAND,IMX_NAND"
> +CONFIG_NAND_VF610_NFC=y
> +CONFIG_SYS_NAND_VF610_NFC_60_ECC_BYTES=y
> +CONFIG_DM=y
> +CONFIG_OF_CONTROL=y
> +CONFIG_DEFAULT_DEVICE_TREE="vf610-colibri"

One minor nit: Can you add this new file to the list of files in our
boards maintainer file?

board/toradex/colibri_vf/MAINTAINERS

But otherwise:
Acked-by: Stefan Agner <stefan@agner.ch>

--
Stefan
Bhuvanchandra DV June 1, 2015, 12:28 p.m. UTC | #2
On 06/01/2015 04:05 PM, Stefan Agner wrote:
> On 2015-06-01 10:51, Bhuvanchandra DV wrote:
>> Most of the drivers available for Vybrid are not yet converted
>> to OF model to use device tree model, only few drivers
>> like SPI and GPIO drivers use device trees.
>> Add separate defconfig for who needs to use device tree model.
>> Later this can be integrated to single defconfig.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>> ---
>>   configs/colibri_vf_dtb_defconfig | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>   create mode 100644 configs/colibri_vf_dtb_defconfig
>>
>> diff --git a/configs/colibri_vf_dtb_defconfig b/configs/colibri_vf_dtb_defconfig
>> new file mode 100644
>> index 0000000..d4c8c58
>> --- /dev/null
>> +++ b/configs/colibri_vf_dtb_defconfig
>> @@ -0,0 +1,8 @@
>> +CONFIG_ARM=y
>> +CONFIG_TARGET_COLIBRI_VF=y
>> +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri_vf/imximage.cfg,ENV_IS_IN_NAND,IMX_NAND"
>> +CONFIG_NAND_VF610_NFC=y
>> +CONFIG_SYS_NAND_VF610_NFC_60_ECC_BYTES=y
>> +CONFIG_DM=y
>> +CONFIG_OF_CONTROL=y
>> +CONFIG_DEFAULT_DEVICE_TREE="vf610-colibri"
>
> One minor nit: Can you add this new file to the list of files in our
> boards maintainer file?
>
> board/toradex/colibri_vf/MAINTAINERS
Sure, will add it.
>
> But otherwise:
> Acked-by: Stefan Agner <stefan@agner.ch>
>
> --
> Stefan
>
Best regards,
Bhuvan
diff mbox

Patch

diff --git a/configs/colibri_vf_dtb_defconfig b/configs/colibri_vf_dtb_defconfig
new file mode 100644
index 0000000..d4c8c58
--- /dev/null
+++ b/configs/colibri_vf_dtb_defconfig
@@ -0,0 +1,8 @@ 
+CONFIG_ARM=y
+CONFIG_TARGET_COLIBRI_VF=y
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri_vf/imximage.cfg,ENV_IS_IN_NAND,IMX_NAND"
+CONFIG_NAND_VF610_NFC=y
+CONFIG_SYS_NAND_VF610_NFC_60_ECC_BYTES=y
+CONFIG_DM=y
+CONFIG_OF_CONTROL=y
+CONFIG_DEFAULT_DEVICE_TREE="vf610-colibri"