| Message ID | 1430273492-10784-3-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
On Wed, Apr 29, 2015 at 10:11 AM, Simon Glass <sjg@chromium.org> wrote: > Now that reset_cpu() functions correctly, use it instead of directly > accessing the port. > > Signed-off-by: Simon Glass <sjg@chromium.org> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > --- > > Changes in v2: None > > arch/x86/cpu/quark/quark.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/cpu/quark/quark.c b/arch/x86/cpu/quark/quark.c > index 4ffa437..e78a271 100644 > --- a/arch/x86/cpu/quark/quark.c > +++ b/arch/x86/cpu/quark/quark.c > @@ -122,7 +122,7 @@ int print_cpuinfo(void) > void reset_cpu(ulong addr) > { > /* cold reset */ > - outb(0x08, PORT_RESET); > + x86_full_reset(); > } > > int cpu_mmc_init(bd_t *bis) > -- Quark cf9 seems only support bit3, but testing shows that it works, so Tested-by: Bin Meng <bmeng.cn@gmail.com>
On 28 April 2015 at 22:08, Bin Meng <bmeng.cn@gmail.com> wrote: > On Wed, Apr 29, 2015 at 10:11 AM, Simon Glass <sjg@chromium.org> wrote: >> Now that reset_cpu() functions correctly, use it instead of directly >> accessing the port. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >> --- >> >> Changes in v2: None >> >> arch/x86/cpu/quark/quark.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/cpu/quark/quark.c b/arch/x86/cpu/quark/quark.c >> index 4ffa437..e78a271 100644 >> --- a/arch/x86/cpu/quark/quark.c >> +++ b/arch/x86/cpu/quark/quark.c >> @@ -122,7 +122,7 @@ int print_cpuinfo(void) >> void reset_cpu(ulong addr) >> { >> /* cold reset */ >> - outb(0x08, PORT_RESET); >> + x86_full_reset(); >> } >> >> int cpu_mmc_init(bd_t *bis) >> -- > > Quark cf9 seems only support bit3, but testing shows that it works, so > > Tested-by: Bin Meng <bmeng.cn@gmail.com> Applied to u-boot-x86.
diff --git a/arch/x86/cpu/quark/quark.c b/arch/x86/cpu/quark/quark.c index 4ffa437..e78a271 100644 --- a/arch/x86/cpu/quark/quark.c +++ b/arch/x86/cpu/quark/quark.c @@ -122,7 +122,7 @@ int print_cpuinfo(void) void reset_cpu(ulong addr) { /* cold reset */ - outb(0x08, PORT_RESET); + x86_full_reset(); } int cpu_mmc_init(bd_t *bis)