From patchwork Tue Apr 28 23:55:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun Bharadwaj X-Patchwork-Id: 465824 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 2C20C14007F for ; Wed, 29 Apr 2015 09:56:06 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gumstix.com header.i=@gumstix.com header.b=hcxGM9cc; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 015934BA0D; Wed, 29 Apr 2015 01:55:57 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a9gY1kNvtr-j; Wed, 29 Apr 2015 01:55:56 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id DE6644BA2B; Wed, 29 Apr 2015 01:55:50 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 806324B9FD for ; Wed, 29 Apr 2015 01:55:40 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kVwnfxHglrtq for ; Wed, 29 Apr 2015 01:55:40 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pd0-f176.google.com (mail-pd0-f176.google.com [209.85.192.176]) by theia.denx.de (Postfix) with ESMTPS id 1319A4B9FB for ; Wed, 29 Apr 2015 01:55:36 +0200 (CEST) Received: by pdea3 with SMTP id a3so10543470pde.3 for ; Tue, 28 Apr 2015 16:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gumstix.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=G6XX5K3Yuw8v7XXyO30QPBzC3g/b5TVTCu9GvuA7XPA=; b=hcxGM9cciYgyf+qAErs+aq2vXbs3h0bv5UkFJi2bWNtSl8Zxbsw6npXSgaVASmpuc6 4Z7iqVsC5jM/NQTxJQdlDcfpwTDWNn+pBSF34g68UTeOs+h82bS+sGbMTq672W+ntywn 8WihWr8l5B2SQzHx5u5BaykH019YelPximbUA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=G6XX5K3Yuw8v7XXyO30QPBzC3g/b5TVTCu9GvuA7XPA=; b=gyR4Zy2Xym0XbYqvlvqCddENryudOJo1PzgfjNKK6ZOOWBUlsiQc6ki6BBsxq50nrH oGhLOZGyx9UzqQo0JlEjfrxKPtgeNOTq7RuKZmV9pQ6h32Gu7HexnG0kyx4t6afoOZ19 kHcuEdPlYLVsAOjJEKUVM+4BONhE5G2kfvHcqoLTu9q2Xx7CqTFD58Zttx+X4iJKTm8Q i2ls5Unq2JaMzErSxx/5o8K4ydnVMWBjhmtc+DFCn83YxQ57hqQGLlacPcHfiQCG7WmF FllDgNy7LHASTFbPwnKEbMeeWj6jkUqo1ScO54CZf/acyQWHDASPSRGtkQLpbJLQXKpA tQnw== X-Gm-Message-State: ALoCoQmAIW6DCjbeC3CBa0FclXcNScRRF9EiIJuXtcWd5leoy7TDIlt+CJz9Me3qWVqDoXn1Kkia X-Received: by 10.68.232.194 with SMTP id tq2mr37026103pbc.90.1430265334906; Tue, 28 Apr 2015 16:55:34 -0700 (PDT) Received: from localhost.localdomain (s206-116-3-180.bc.hsia.telus.net. [206.116.3.180]) by mx.google.com with ESMTPSA id jc6sm23429768pbd.4.2015.04.28.16.55.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Apr 2015 16:55:34 -0700 (PDT) From: Arun Bharadwaj To: u-boot@lists.denx.de, Tom Rini , Steve Sakoman Date: Tue, 28 Apr 2015 16:55:30 -0700 Message-Id: <1430265330-12205-3-git-send-email-arun@gumstix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1430265330-12205-1-git-send-email-arun@gumstix.com> References: <1430265330-12205-1-git-send-email-arun@gumstix.com> Subject: [U-Boot] [PATCH 2/2] u-boot breaks for the Overo boards since the following commit: a6b541b09022acb6f7c2754100ae26bd44eed1d9 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" This is because the gd pointer is not set early enough anymore, such that the i2c_set_bus_num in get_board_revision can safely execute. This results in a console hang at SPL and the boot does not proceed. This piece of code is anyway necessary only for really old Overo boards with revision numbers <= 2410 and not required for the newer boards. For these older boards, u-boot v2014.10 still works fine. Signed-off-by: Arun Bharadwaj --- board/overo/common.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/board/overo/common.c b/board/overo/common.c index bdfa5ca..f6f6792 100644 --- a/board/overo/common.c +++ b/board/overo/common.c @@ -310,20 +310,6 @@ int get_board_revision(void) { int revision; -#ifdef CONFIG_SYS_I2C_OMAP34XX - unsigned char data; - - /* board revisions <= R2410 connect 4030 irq_1 to gpio112 */ - /* these boards should return a revision number of 0 */ - /* the code below forces a 4030 RTC irq to ensure that gpio112 is low */ - i2c_set_bus_num(TWL4030_I2C_BUS); - data = 0x01; - i2c_write(0x4B, 0x29, 1, &data, 1); - data = 0x0c; - i2c_write(0x4B, 0x2b, 1, &data, 1); - i2c_read(0x4B, 0x2a, 1, &data, 1); -#endif - if (!gpio_request(112, "") && !gpio_request(113, "") && !gpio_request(115, "")) {