| Message ID | 1425983444-18565-3-git-send-email-p.marczak@samsung.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Przemyslaw, > Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> > Cc: Masahiro Yamada <yamada.m@jp.panasonic.com> > Cc: Mike Frysinger <vapier@gentoo.org> > Cc: Simon Glass <sjg@chromium.org> > Cc: Heiko Schocher <hs@denx.de> > --- > drivers/i2c/Kconfig | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig > index 692810d..0a52ed9 100644 > --- a/drivers/i2c/Kconfig > +++ b/drivers/i2c/Kconfig > @@ -2,16 +2,7 @@ config DM_I2C > bool "Enable Driver Model for I2C drivers" > depends on DM > help > - Enable driver model for I2C. This SPI flash interface > - (spi_flash_probe(), spi_flash_write(), etc.) is then > - implemented by the SPI flash uclass. There is one standard > - SPI flash driver which knows how to probe most chips > - supported by U-Boot. The uclass interface is defined in > - include/spi_flash.h, but is currently fully compatible > - with the old interface to avoid confusion and duplication > - during the transition parent. SPI and SPI flash must be > - enabled together (it is not possible to use driver model > - for one and not the other). > + Enable driver model for I2C. > > config DM_I2C_COMPAT > bool "Enable I2C compatibility layer" Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
Hi, On 10 March 2015 at 04:30, Przemyslaw Marczak <p.marczak@samsung.com> wrote: > Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> > Cc: Masahiro Yamada <yamada.m@jp.panasonic.com> > Cc: Mike Frysinger <vapier@gentoo.org> > Cc: Simon Glass <sjg@chromium.org> > Cc: Heiko Schocher <hs@denx.de> > --- > drivers/i2c/Kconfig | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig > index 692810d..0a52ed9 100644 > --- a/drivers/i2c/Kconfig > +++ b/drivers/i2c/Kconfig > @@ -2,16 +2,7 @@ config DM_I2C > bool "Enable Driver Model for I2C drivers" > depends on DM > help > - Enable driver model for I2C. This SPI flash interface > - (spi_flash_probe(), spi_flash_write(), etc.) is then > - implemented by the SPI flash uclass. There is one standard > - SPI flash driver which knows how to probe most chips > - supported by U-Boot. The uclass interface is defined in > - include/spi_flash.h, but is currently fully compatible > - with the old interface to avoid confusion and duplication > - during the transition parent. SPI and SPI flash must be > - enabled together (it is not possible to use driver model > - for one and not the other). > + Enable driver model for I2C. That's too short IMO :-) Can you add a few more details along the lines of what is described for SPI, and also mention the COMPAT option? Thanks for fixing this. > > config DM_I2C_COMPAT > bool "Enable I2C compatibility layer" > -- > 1.9.1 > Regards, Simon
Hello Simon, On 03/24/2015 12:39 AM, Simon Glass wrote: > Hi, > > On 10 March 2015 at 04:30, Przemyslaw Marczak <p.marczak@samsung.com> wrote: >> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> >> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com> >> Cc: Mike Frysinger <vapier@gentoo.org> >> Cc: Simon Glass <sjg@chromium.org> >> Cc: Heiko Schocher <hs@denx.de> >> --- >> drivers/i2c/Kconfig | 11 +---------- >> 1 file changed, 1 insertion(+), 10 deletions(-) >> >> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig >> index 692810d..0a52ed9 100644 >> --- a/drivers/i2c/Kconfig >> +++ b/drivers/i2c/Kconfig >> @@ -2,16 +2,7 @@ config DM_I2C >> bool "Enable Driver Model for I2C drivers" >> depends on DM >> help >> - Enable driver model for I2C. This SPI flash interface >> - (spi_flash_probe(), spi_flash_write(), etc.) is then >> - implemented by the SPI flash uclass. There is one standard >> - SPI flash driver which knows how to probe most chips >> - supported by U-Boot. The uclass interface is defined in >> - include/spi_flash.h, but is currently fully compatible >> - with the old interface to avoid confusion and duplication >> - during the transition parent. SPI and SPI flash must be >> - enabled together (it is not possible to use driver model >> - for one and not the other). >> + Enable driver model for I2C. > > That's too short IMO :-) > > Can you add a few more details along the lines of what is described > for SPI, and also mention the COMPAT option? > > Thanks for fixing this. > Ok, will add more details :) >> >> config DM_I2C_COMPAT >> bool "Enable I2C compatibility layer" >> -- >> 1.9.1 >> > > Regards, > Simon > Best regards,
diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig index 692810d..0a52ed9 100644 --- a/drivers/i2c/Kconfig +++ b/drivers/i2c/Kconfig @@ -2,16 +2,7 @@ config DM_I2C bool "Enable Driver Model for I2C drivers" depends on DM help - Enable driver model for I2C. This SPI flash interface - (spi_flash_probe(), spi_flash_write(), etc.) is then - implemented by the SPI flash uclass. There is one standard - SPI flash driver which knows how to probe most chips - supported by U-Boot. The uclass interface is defined in - include/spi_flash.h, but is currently fully compatible - with the old interface to avoid confusion and duplication - during the transition parent. SPI and SPI flash must be - enabled together (it is not possible to use driver model - for one and not the other). + Enable driver model for I2C. config DM_I2C_COMPAT bool "Enable I2C compatibility layer"
Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com> Cc: Mike Frysinger <vapier@gentoo.org> Cc: Simon Glass <sjg@chromium.org> Cc: Heiko Schocher <hs@denx.de> --- drivers/i2c/Kconfig | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)