From patchwork Fri Dec 19 21:53:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rini X-Patchwork-Id: 422993 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 8A5781400A0 for ; Sat, 20 Dec 2014 08:53:44 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 450664B662; Fri, 19 Dec 2014 22:53:39 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pMCl-vbV0Y4b; Fri, 19 Dec 2014 22:53:39 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id CF01D4B66E; Fri, 19 Dec 2014 22:53:37 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A81184B61F for ; Fri, 19 Dec 2014 22:53:32 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QuExhqKj93ig for ; Fri, 19 Dec 2014 22:53:32 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-yh0-f45.google.com (mail-yh0-f45.google.com [209.85.213.45]) by theia.denx.de (Postfix) with ESMTPS id 569634B61D for ; Fri, 19 Dec 2014 22:53:28 +0100 (CET) Received: by mail-yh0-f45.google.com with SMTP id f10so803905yha.4 for ; Fri, 19 Dec 2014 13:53:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Mb6pYMBcicSrg8Lunxb00Z7TOZW+UkmozTr0RsXHaaU=; b=jw15VN/UFeUVAagqVR4aHsO8w6A8W7CNNk/tJToY/kgc54Kp2yoW1XEzNXSLqjsC9t 3JAlFxuH2EqwDAEygUrgaddXpxWhe9+XSFKc3As30bBdZtVKmniQJouOcrVXeDr1xdwX ny8IM4F59L4Mh+nzMWEQbxYIPXo98TVi5x8x3uYsZGTCZaujxplYYcibP0hBMVORPpJi Oxn8Ppkl1plmYzqq9boS0P3vIZ7KugIdQmjI+SR/Ve3BRQcgslzU0oLO/ZsQ01cYLeeJ SimLeBLmaRgB/HFQOc2oLj9Y7iMzVb3vKsPpOj41dW2IIwIn35UcZAe/u9gckL+Yg2CN X5lQ== X-Received: by 10.236.63.163 with SMTP id a23mr8088169yhd.41.1419026007200; Fri, 19 Dec 2014 13:53:27 -0800 (PST) Received: from localhost.localdomain (cpe-174-106-048-186.ec.res.rr.com. [174.106.48.186]) by mx.google.com with ESMTPSA id r16sm6526136yhr.47.2014.12.19.13.53.26 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 19 Dec 2014 13:53:26 -0800 (PST) From: Tom Rini To: u-boot@lists.denx.de Date: Fri, 19 Dec 2014 16:53:25 -0500 Message-Id: <1419026005-5549-2-git-send-email-trini@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1419026005-5549-1-git-send-email-trini@ti.com> References: <1419026005-5549-1-git-send-email-trini@ti.com> Subject: [U-Boot] [PATCH RFT 2/2] davinci: Do not duplicate setting of gd X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.13 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de In f0c3a6c we stopped setting gd in board_init_f, but later had to revert to due problems on certain platforms. As davinci does not look to have these problems, we can drop the setting here and rely upon crt0.S to do it. Cc: Peter Howard Signed-off-by: Tom Rini --- Peter, I don't have my davinci board hooked up but since you were doing some changes recently is there a chance you can test this easily? Thanks! --- arch/arm/cpu/arm926ejs/davinci/spl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/cpu/arm926ejs/davinci/spl.c b/arch/arm/cpu/arm926ejs/davinci/spl.c index 59b304e..7b14420 100644 --- a/arch/arm/cpu/arm926ejs/davinci/spl.c +++ b/arch/arm/cpu/arm926ejs/davinci/spl.c @@ -51,7 +51,6 @@ void board_init_f(ulong dummy) memset(__bss_start, 0, __bss_end - __bss_start); /* Finally, setup gd and move to the next step. */ - gd = &gdata; board_init_r(NULL, 0); }