| Message ID | 1418602541-25144-3-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
On Mon, Dec 15, 2014 at 8:15 AM, Simon Glass <sjg@chromium.org> wrote: > This is missing a parameter. Fix it to avoid a warning when debug is > enabled. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > tools/ifdtool.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/ifdtool.c b/tools/ifdtool.c > index 4a27b82..4cdfdcc 100644 > --- a/tools/ifdtool.c > +++ b/tools/ifdtool.c > @@ -54,7 +54,8 @@ static struct fdbar_t *find_fd(char *image, int size) > return NULL; > } > > - debug("Found Flash Descriptor signature at 0x%08x\n", i); > + debug("Found Flash Descriptor signature at 0x%08lx\n", > + (char *)ptr - image); > > return (struct fdbar_t *)ptr; > } > -- Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On 15 December 2014 at 02:22, Bin Meng <bmeng.cn@gmail.com> wrote: > On Mon, Dec 15, 2014 at 8:15 AM, Simon Glass <sjg@chromium.org> wrote: >> This is missing a parameter. Fix it to avoid a warning when debug is >> enabled. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> tools/ifdtool.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tools/ifdtool.c b/tools/ifdtool.c >> index 4a27b82..4cdfdcc 100644 >> --- a/tools/ifdtool.c >> +++ b/tools/ifdtool.c >> @@ -54,7 +54,8 @@ static struct fdbar_t *find_fd(char *image, int size) >> return NULL; >> } >> >> - debug("Found Flash Descriptor signature at 0x%08x\n", i); >> + debug("Found Flash Descriptor signature at 0x%08lx\n", >> + (char *)ptr - image); >> >> return (struct fdbar_t *)ptr; >> } >> -- > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Applied to u-boot-x86.
diff --git a/tools/ifdtool.c b/tools/ifdtool.c index 4a27b82..4cdfdcc 100644 --- a/tools/ifdtool.c +++ b/tools/ifdtool.c @@ -54,7 +54,8 @@ static struct fdbar_t *find_fd(char *image, int size) return NULL; } - debug("Found Flash Descriptor signature at 0x%08x\n", i); + debug("Found Flash Descriptor signature at 0x%08lx\n", + (char *)ptr - image); return (struct fdbar_t *)ptr; }
This is missing a parameter. Fix it to avoid a warning when debug is enabled. Signed-off-by: Simon Glass <sjg@chromium.org> --- tools/ifdtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)