From patchwork Wed Nov 19 16:21:30 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suriyan Ramasami X-Patchwork-Id: 412454 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id EA8BB14010B for ; Thu, 20 Nov 2014 03:22:06 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 03A254B65A; Wed, 19 Nov 2014 17:22:03 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HWYJz39gENIU; Wed, 19 Nov 2014 17:22:02 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 425234B65B; Wed, 19 Nov 2014 17:21:56 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0D0F44B60F for ; Wed, 19 Nov 2014 17:21:46 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nmkJIAEDshbz for ; Wed, 19 Nov 2014 17:21:45 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by theia.denx.de (Postfix) with ESMTPS id 613644B61F for ; Wed, 19 Nov 2014 17:21:41 +0100 (CET) Received: by mail-pa0-f42.google.com with SMTP id et14so553884pad.1 for ; Wed, 19 Nov 2014 08:21:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jxtI6910/HgnHk/pR6gZbP63AInkeDc8KKE+m3/IDFM=; b=oPJC8vJ4eD+o4f6h492r48Dn/NlhpCVFBv2+BMA+G6R3zrXZ2SxLB5bFxLhJUwjN9t 8T2BJCqHiAhXWFhpu46XcPXOJpqlfNP2Zk8cuESPbP8CZo6QKZSsIJdmBUbRlLzX/F1G 73Tyu7mB92JDp4QjYJVDwrlD6Om8T9pOgzPaqwrEILStT86ZGKZ/RPEoBPpsgZf4vR4W rq8e3oHGFWOPw+Ee2MsmnteIaJ9kAEuXUBYVnHjv3PncM+NvvUAWSCzeRHXDxsmGZesX VZyIGqz/co7t3iyKb7VEyCYS8DJ+Rw5WmgvTsM8fDu6V0DjNbEfTZjXvCZA1wbTtJyMD AZKA== X-Received: by 10.70.38.232 with SMTP id j8mr31203894pdk.44.1416414100488; Wed, 19 Nov 2014 08:21:40 -0800 (PST) Received: from Stealth.localdomain ([73.170.223.86]) by mx.google.com with ESMTPSA id m5sm2221823pdi.24.2014.11.19.08.21.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Nov 2014 08:21:39 -0800 (PST) From: Suriyan Ramasami To: Przemyslaw Marczak Date: Wed, 19 Nov 2014 08:21:30 -0800 Message-Id: <1416414090-4058-2-git-send-email-suriyan.r@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1416414090-4058-1-git-send-email-suriyan.r@gmail.com> References: <1416414090-4058-1-git-send-email-suriyan.r@gmail.com> Cc: Suriyan Ramasami , u-boot@lists.denx.de Subject: [U-Boot] [PATCH v1 2/2] odroid: usbhost - Add missing gpio_request call X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.13 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de The USB host code was missing gpio_request() calls before using the gpio functions, causing errors to be printed out. Signed-off-by: Suriyan Ramasami Acked-by: Przemyslaw Marczak --- Changes in v1: - Added gpio_request() call in board_gpio_init() board/samsung/odroid/odroid.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c index f7396ab..a2c008e 100644 --- a/board/samsung/odroid/odroid.c +++ b/board/samsung/odroid/odroid.c @@ -382,6 +382,17 @@ static void board_gpio_init(void) gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP); gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X); gpio_direction_input(EXYNOS4X12_GPIO_X31); + +#ifdef CONFIG_CMD_USB + /* USB3503A Reference frequency */ + gpio_request(EXYNOS4X12_GPIO_X30, "USB3503A RefFreq"); + + /* USB3503A Connect */ + gpio_request(EXYNOS4X12_GPIO_X34, "USB3503A Connect"); + + /* USB3503A Reset */ + gpio_request(EXYNOS4X12_GPIO_X35, "USB3503A Reset"); +#endif } static int pmic_init_max77686(void) @@ -489,10 +500,8 @@ int board_usb_init(int index, enum usb_init_type init) p_pmic = pmic_get("MAX77686_PMIC"); if (p_pmic && !pmic_probe(p_pmic)) { - max77686_set_buck_mode(p_pmic, 8, OPMODE_OFF); max77686_set_buck_voltage(p_pmic, 8, 750000); max77686_set_buck_voltage(p_pmic, 8, 3300000); - max77686_set_buck_mode(p_pmic, 8, OPMODE_ON); } #endif