| Message ID | 1416268255-8925-1-git-send-email-suriyan.r@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
Hello Suriyan, On 11/18/2014 12:50 AM, Suriyan Ramasami wrote: > To indicate that U-Boot is active, turn on the blue LED. > > Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com> > > --- > > Changes in v2: > - Przemyslaw Marczak, Add gpio_request call. > > Changes in v1: > - First try > > board/samsung/odroid/odroid.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c > index 33003ee..e1a86f9 100644 > --- a/board/samsung/odroid/odroid.c > +++ b/board/samsung/odroid/odroid.c > @@ -382,6 +382,11 @@ static void board_gpio_init(void) > gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP); > gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X); > gpio_direction_input(EXYNOS4X12_GPIO_X31); > + > + /* Blue LED (Odroid X2/U2/U3) */ > + gpio_request(EXYNOS4X12_GPIO_C10, "Blue LED"); > + > + gpio_direction_output(EXYNOS4X12_GPIO_C10, 0); > } > > static int pmic_init_max77686(void) > Acked-by: Przemyslaw Marczak <p.marczak@samsung.com> Best regards,
Dear Suriyan Ramasami, On 18/11/14 08:50, Suriyan Ramasami wrote: > To indicate that U-Boot is active, turn on the blue LED. > > Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com> > > --- > > Changes in v2: > - Przemyslaw Marczak, Add gpio_request call. > > Changes in v1: > - First try > > board/samsung/odroid/odroid.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c > index 33003ee..e1a86f9 100644 > --- a/board/samsung/odroid/odroid.c > +++ b/board/samsung/odroid/odroid.c > @@ -382,6 +382,11 @@ static void board_gpio_init(void) > gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP); > gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X); > gpio_direction_input(EXYNOS4X12_GPIO_X31); > + > + /* Blue LED (Odroid X2/U2/U3) */ > + gpio_request(EXYNOS4X12_GPIO_C10, "Blue LED"); > + > + gpio_direction_output(EXYNOS4X12_GPIO_C10, 0); > } > > static int pmic_init_max77686(void) > Because board_gpio_init was changed by you, please rebase this patch. Thanks, Minkyu Kang.
diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c index 33003ee..e1a86f9 100644 --- a/board/samsung/odroid/odroid.c +++ b/board/samsung/odroid/odroid.c @@ -382,6 +382,11 @@ static void board_gpio_init(void) gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP); gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X); gpio_direction_input(EXYNOS4X12_GPIO_X31); + + /* Blue LED (Odroid X2/U2/U3) */ + gpio_request(EXYNOS4X12_GPIO_C10, "Blue LED"); + + gpio_direction_output(EXYNOS4X12_GPIO_C10, 0); } static int pmic_init_max77686(void)
To indicate that U-Boot is active, turn on the blue LED. Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com> --- Changes in v2: - Przemyslaw Marczak, Add gpio_request call. Changes in v1: - First try board/samsung/odroid/odroid.c | 5 +++++ 1 file changed, 5 insertions(+)