From patchwork Mon Sep 29 19:35:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 394615 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id DCF691400D5 for ; Tue, 30 Sep 2014 05:47:25 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C3892A73FF; Mon, 29 Sep 2014 21:47:02 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2RS0un7nMi9J; Mon, 29 Sep 2014 21:47:02 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B8BF1A742C; Mon, 29 Sep 2014 21:46:46 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 056164B64D for ; Mon, 29 Sep 2014 21:46:28 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rpvmwywRtEob for ; Mon, 29 Sep 2014 21:46:27 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-oi0-f74.google.com (mail-oi0-f74.google.com [209.85.218.74]) by theia.denx.de (Postfix) with ESMTPS id 85A074B650 for ; Mon, 29 Sep 2014 21:46:23 +0200 (CEST) Received: by mail-oi0-f74.google.com with SMTP id u20so3593318oif.1 for ; Mon, 29 Sep 2014 12:46:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AULYcDfHz1tH72p4osYLriVQvdoQlRaVSdmkFqFNLok=; b=loyNixjlaruK2l6HvpJJygG018vP7fcrU6Fw8zfzbpXLZWAxiwgwD72zTVYJY6+Tl5 0kM/49H0cID2Grq8SthwOhH86Bx2LrqGsvZ9E8yYwMpuAOLj/OkaxvvGJUQP/BM2+L/0 PRtXloylbhSr2aUUB3FwUlf1FpbLKiAYYOLSsCmigGlBtOd1sBJvE5czpW5grbWnUWJn ao51LMWY57uutVfRPDgUO1gfBHPEBYlIWnU127dhukbQJ+gg/yG+JR9UWPEQsNpQ8H2J pqWEspYxae0IlDMPPTwTNoOf7KU8VMBD68zqHVdk3lmoCp07Q/HXr8wa+aTbyyuTjxAv +4jQ== X-Gm-Message-State: ALoCoQlg+Pe/jrZYnRxZov6da6qiPyfF2zCwry6S2N9I6JRMzg1ooBJL9bVl5X9Nt3ksPwqlpUBe X-Received: by 10.182.126.196 with SMTP id na4mr34171757obb.10.1412019982496; Mon, 29 Sep 2014 12:46:22 -0700 (PDT) Received: from corpmail-nozzle1-1.hot.corp.google.com ([100.108.1.104]) by gmr-mx.google.com with ESMTPS id t28si772247yhb.4.2014.09.29.12.46.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Sep 2014 12:46:22 -0700 (PDT) Received: from kaki.bld.corp.google.com ([172.29.216.32]) by corpmail-nozzle1-1.hot.corp.google.com with ESMTP id XFxC3kjV.1; Mon, 29 Sep 2014 12:46:22 -0700 Received: by kaki.bld.corp.google.com (Postfix, from userid 121222) id 0F7CF222709; Mon, 29 Sep 2014 13:37:28 -0600 (MDT) From: Simon Glass To: U-Boot Mailing List Date: Mon, 29 Sep 2014 13:35:21 -0600 Message-Id: <1412019326-6721-25-git-send-email-sjg@chromium.org> X-Mailer: git-send-email 2.1.0.rc2.206.gedb03e5 In-Reply-To: <1412019326-6721-1-git-send-email-sjg@chromium.org> References: <1412019326-6721-1-git-send-email-sjg@chromium.org> Cc: u-boot-review@google.com, Jagannadha Sutradharudu Teki Subject: [U-Boot] [PATCH v3 24/29] dm: sf: Add tests for SPI flash X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.13 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Add a simple test for SPI that uses SPI flash. It operates by creating a SPI flash file and using the 'sf test' command to test that all operations work correctly. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None test/dm/Makefile | 1 + test/dm/sf.c | 43 +++++++++++++++++++++++++++++++++++++++++++ test/dm/test.dts | 17 ++++++++++++++++- 3 files changed, 60 insertions(+), 1 deletion(-) create mode 100644 test/dm/sf.c diff --git a/test/dm/Makefile b/test/dm/Makefile index d1b9c9a..75d3d41 100644 --- a/test/dm/Makefile +++ b/test/dm/Makefile @@ -19,4 +19,5 @@ obj-$(CONFIG_DM_TEST) += ut.o ifneq ($(CONFIG_SANDBOX),) obj-$(CONFIG_DM_GPIO) += gpio.o obj-$(CONFIG_DM_SPI) += spi.o +obj-$(CONFIG_DM_SPI_FLASH) += sf.o endif diff --git a/test/dm/sf.c b/test/dm/sf.c new file mode 100644 index 0000000..57dd134 --- /dev/null +++ b/test/dm/sf.c @@ -0,0 +1,43 @@ +/* + * Copyright (C) 2013 Google, Inc + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* Test that sandbox SPI flash works correctly */ +static int dm_test_spi_flash(struct dm_test_state *dms) +{ + /* + * Create an empty test file and run the SPI flash tests. This is a + * long way from being a unit test, but it does test SPI device and + * emulator binding, probing, the SPI flash emulator including + * device tree decoding, plus the file-based backing store of SPI. + * + * More targeted tests could be created to perform the above steps + * one at a time. This might not increase test coverage much, but + * it would make bugs easier to find. It's not clear whether the + * benefit is worth the extra complexity. + */ + ut_asserteq(0, run_command_list( + "sb save hostfs - spi.bin 0 200000;" + "sf probe;" + "sf test 0 10000", -1, 0)); + /* + * Since we are about to destroy all devices, we must tell sandbox + * to forget the emulation device + */ + sandbox_sf_unbind_emul(state_get_current(), 0, 0); + + return 0; +} +DM_TEST(dm_test_spi_flash, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT); diff --git a/test/dm/test.dts b/test/dm/test.dts index 8489595..1fba792 100644 --- a/test/dm/test.dts +++ b/test/dm/test.dts @@ -81,7 +81,7 @@ compatible = "google,another-fdt-test"; }; - base-gpios { + gpio_a: base-gpios { compatible = "sandbox,gpio"; gpio-bank-name = "a"; num-gpios = <20>; @@ -92,4 +92,19 @@ gpio-bank-name = "b"; num-gpios = <10>; }; + + spi@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + compatible = "sandbox,spi"; + cs-gpios = <0>, <&gpio_a 0>; + spi.bin@0 { + reg = <0>; + compatible = "spansion,m25p16", "spi-flash"; + spi-max-frequency = <40000000>; + sandbox,filename = "spi.bin"; + }; + }; + };