diff mbox

[U-Boot,2/3] Makefile: fix ctags/etags clean targets

Message ID 1405428722-31624-3-git-send-email-grinberg@compulab.co.il
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Igor Grinberg July 15, 2014, 12:52 p.m. UTC
Commit efcf861 (kbuild: use scripts/Makefile.clean)
refactored the cleaning targets and accidentially replaced the actually
generated "ctags" and "etags" files in the file list by "tags" and "TAGS".
"tags" and "TAGS" are not part of the Makefile build targets and
therefore should not be a part of the list for clean targets.

Substitute the actually generated files instead, to fix the clean
targets behavior.

Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini July 22, 2014, 7:23 p.m. UTC | #1
On Tue, Jul 15, 2014 at 03:52:01PM +0300, Igor Grinberg wrote:

> Commit efcf861 (kbuild: use scripts/Makefile.clean)
> refactored the cleaning targets and accidentially replaced the actually
> generated "ctags" and "etags" files in the file list by "tags" and "TAGS".
> "tags" and "TAGS" are not part of the Makefile build targets and
> therefore should not be a part of the list for clean targets.
> 
> Substitute the actually generated files instead, to fix the clean
> targets behavior.
> 
> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 26b29d1..bfe801c 100644
--- a/Makefile
+++ b/Makefile
@@ -1222,7 +1222,7 @@  CLOBBER_FILES += u-boot* MLO* SPL System.map
 MRPROPER_DIRS  += include/config include/generated          \
 		  .tmp_objdiff
 MRPROPER_FILES += .config .config.old \
-		  tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \
+		  ctags etags cscope* GPATH GTAGS GRTAGS GSYMS \
 		  include/config.h include/config.mk
 
 # clean - Delete most, but leave enough to build external modules