diff mbox

[U-Boot,3/3] ext4: correctly zero filename

Message ID 1402320540-17058-4-git-send-email-jeroen@myspectrum.nl
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Jeroen Hofstee June 9, 2014, 1:29 p.m. UTC 
Since ALLOC_CACHE_ALIGN_BUFFER declares a char* for filename
sizeof(filename) is not the size of the buffer. Use the already
known length instead.

cc: Uma Shankar <uma.shankar@samsung.com>
cc: Manjunatha C Achar <a.manjunatha@samsung.com>
cc: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
 fs/ext4/ext4_write.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Vasut June 9, 2014, 5:58 p.m. UTC | #1 
On Monday, June 09, 2014 at 03:29:00 PM, Jeroen Hofstee wrote:
> Since ALLOC_CACHE_ALIGN_BUFFER declares a char* for filename
> sizeof(filename) is not the size of the buffer. Use the already
> known length instead.
> 
> cc: Uma Shankar <uma.shankar@samsung.com>
> cc: Manjunatha C Achar <a.manjunatha@samsung.com>
> cc: Marek Vasut <marek.vasut@gmail.com>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>

Nice :-)

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut
Tom Rini June 11, 2014, 10:19 p.m. UTC | #2 
On Mon, Jun 09, 2014 at 03:29:00PM +0200, Jeroen Hofstee wrote:

> Since ALLOC_CACHE_ALIGN_BUFFER declares a char* for filename
> sizeof(filename) is not the size of the buffer. Use the already
> known length instead.
> 
> cc: Uma Shankar <uma.shankar@samsung.com>
> cc: Manjunatha C Achar <a.manjunatha@samsung.com>
> cc: Marek Vasut <marek.vasut@gmail.com>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> Acked-by: Marek Vasut <marex@denx.de>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/fs/ext4/ext4_write.c b/fs/ext4/ext4_write.c
index c42add9..648a596 100644
--- a/fs/ext4/ext4_write.c
+++ b/fs/ext4/ext4_write.c
@@ -840,7 +840,7 @@  int ext4fs_write(const char *fname, unsigned char *buffer,
 	unsigned int ibmap_idx;
 	struct ext_filesystem *fs = get_fs();
 	ALLOC_CACHE_ALIGN_BUFFER(char, filename, 256);
-	memset(filename, 0x00, sizeof(filename));
+	memset(filename, 0x00, 256);
 
 	g_parent_inode = zalloc(sizeof(struct ext2_inode));
 	if (!g_parent_inode)